Feature: Use active pane’s path when splitting

yaira2 · yaira2 · commit 183f073c3dbc · 2025-08-10T16:08:00.000-04:00
diff --git a/src/Files.App/Actions/Navigation/SplitPaneHorizontallyAction.cs b/src/Files.App/Actions/Navigation/SplitPaneHorizontallyAction.cs
@@ -6,7 +6,6 @@ namespace Files.App.Actions
 	internal sealed partial class SplitPaneHorizontallyAction : ObservableObject, IAction
 	{
 		private readonly IContentPageContext ContentPageContext = Ioc.Default.GetRequiredService<IContentPageContext>();
-		private readonly IGeneralSettingsService GeneralSettingsService = Ioc.Default.GetRequiredService<IGeneralSettingsService>();
 
 		public string Label
 			=> Strings.SplitPaneHorizontally.GetLocalizedResource();
@@ -31,7 +30,7 @@ public SplitPaneHorizontallyAction()
 
 		public Task ExecuteAsync(object? parameter = null)
 		{
-			ContentPageContext.ShellPage!.PaneHolder.OpenSecondaryPane(arrangement: ShellPaneArrangement.Horizontal);
+			ContentPageContext.ShellPage!.PaneHolder.OpenSecondaryPane(ContentPageContext.ShellPage!.ShellViewModel.WorkingDirectory, ShellPaneArrangement.Horizontal);
 
 			return Task.CompletedTask;
 		}
diff --git a/src/Files.App/Actions/Navigation/SplitPaneVerticallyAction.cs b/src/Files.App/Actions/Navigation/SplitPaneVerticallyAction.cs
@@ -6,7 +6,6 @@ namespace Files.App.Actions
 	internal sealed partial class SplitPaneVerticallyAction : ObservableObject, IAction
 	{
 		private readonly IContentPageContext ContentPageContext = Ioc.Default.GetRequiredService<IContentPageContext>();
-		private readonly IGeneralSettingsService GeneralSettingsService = Ioc.Default.GetRequiredService<IGeneralSettingsService>();
 
 		public string Label
 			=> Strings.SplitPaneVertically.GetLocalizedResource();
@@ -31,7 +30,7 @@ public SplitPaneVerticallyAction()
 
 		public Task ExecuteAsync(object? parameter = null)
 		{
-			ContentPageContext.ShellPage!.PaneHolder.OpenSecondaryPane(arrangement: ShellPaneArrangement.Vertical);
+			ContentPageContext.ShellPage!.PaneHolder.OpenSecondaryPane(ContentPageContext.ShellPage!.ShellViewModel.WorkingDirectory, ShellPaneArrangement.Vertical);
 
 			return Task.CompletedTask;
 		}
diff --git a/src/Files.App/Actions/Show/ToggleDualPaneAction.cs b/src/Files.App/Actions/Show/ToggleDualPaneAction.cs
@@ -27,7 +27,7 @@ public Task ExecuteAsync(object? parameter = null)
 			if (IsOn)
 				ContentPageContext.ShellPage?.PaneHolder.CloseOtherPane();
 			else
-				ContentPageContext.ShellPage?.PaneHolder.OpenSecondaryPane(arrangement: generalSettingsService.ShellPaneArrangementOption);
+				ContentPageContext.ShellPage?.PaneHolder.OpenSecondaryPane(ContentPageContext.ShellPage!.ShellViewModel.WorkingDirectory, generalSettingsService.ShellPaneArrangementOption);
 
 			return Task.CompletedTask;
 		}

Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,6 @@ namespace Files.App.Actions`
`6`	`6`	`internal sealed partial class SplitPaneHorizontallyAction : ObservableObject, IAction`
`7`	`7`	`{`
`8`	`8`	`private readonly IContentPageContext ContentPageContext = Ioc.Default.GetRequiredService<IContentPageContext>();`
`9`		`- private readonly IGeneralSettingsService GeneralSettingsService = Ioc.Default.GetRequiredService<IGeneralSettingsService>();`
`10`	`9`
`11`	`10`	`public string Label`
`12`	`11`	`=> Strings.SplitPaneHorizontally.GetLocalizedResource();`
`@@ -31,7 +30,7 @@ public SplitPaneHorizontallyAction()`
`31`	`30`
`32`	`31`	`public Task ExecuteAsync(object? parameter = null)`
`33`	`32`	`{`
`34`		`- ContentPageContext.ShellPage!.PaneHolder.OpenSecondaryPane(arrangement: ShellPaneArrangement.Horizontal);`
	`33`	`+ ContentPageContext.ShellPage!.PaneHolder.OpenSecondaryPane(ContentPageContext.ShellPage!.ShellViewModel.WorkingDirectory, ShellPaneArrangement.Horizontal);`
`35`	`34`
`36`	`35`	`return Task.CompletedTask;`
`37`	`36`	`}`
Original file line number	Diff line number	Diff line change
`@@ -27,7 +27,7 @@ public Task ExecuteAsync(object? parameter = null)`
`27`	`27`	`if (IsOn)`
`28`	`28`	`ContentPageContext.ShellPage?.PaneHolder.CloseOtherPane();`
`29`	`29`	`else`
`30`		`- ContentPageContext.ShellPage?.PaneHolder.OpenSecondaryPane(arrangement: generalSettingsService.ShellPaneArrangementOption);`
	`30`	`+ ContentPageContext.ShellPage?.PaneHolder.OpenSecondaryPane(ContentPageContext.ShellPage!.ShellViewModel.WorkingDirectory, generalSettingsService.ShellPaneArrangementOption);`
`31`	`31`
`32`	`32`	`return Task.CompletedTask;`
`33`	`33`	`}`