Skip to content

Commit 1a3a4ff

Browse files
committed
Fix: Fixed icon overlay alignment
1 parent 4b72678 commit 1a3a4ff

File tree

2 files changed

+23
-39
lines changed

2 files changed

+23
-39
lines changed

src/Files.App/Views/Layouts/DetailsLayoutPage.xaml

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -907,16 +907,13 @@
907907
Loaded="StackPanel_Loaded"
908908
Orientation="Horizontal">
909909
<!-- Item Thumbnail -->
910-
<Grid
911-
Width="24"
912-
HorizontalAlignment="Left"
913-
VerticalAlignment="Stretch">
910+
<Grid HorizontalAlignment="Left" VerticalAlignment="Stretch">
914911

915912
<!-- Thumbnail -->
916913
<Grid
917914
x:Name="IconBox"
918-
Width="20"
919-
Height="Auto"
915+
Width="24"
916+
Height="24"
920917
HorizontalAlignment="Center"
921918
VerticalAlignment="Center"
922919
AutomationProperties.Name="{helpers:ResourceString Name=FileBrowserThumbnailIconColumnGrid/AutomationProperties/Name}"
@@ -1285,7 +1282,7 @@
12851282
<VisualState x:Name="ShowCheckbox">
12861283
<VisualState.Setters>
12871284
<Setter Target="SelectionCheckbox.Opacity" Value="1" />
1288-
<Setter Target="IconBox.Visibility" Value="Collapsed" />
1285+
<Setter Target="IconBox.Opacity" Value="0" />
12891286
</VisualState.Setters>
12901287
</VisualState>
12911288
</VisualStateGroup>

src/Files.App/Views/Layouts/GridLayoutPage.xaml

Lines changed: 19 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -299,22 +299,22 @@
299299
PointerEntered="Grid_PointerEntered"
300300
ToolTipService.ToolTip="{x:Bind ItemTooltipText, Mode=OneWay}">
301301
<Grid.ColumnDefinitions>
302-
<ColumnDefinition Width="24" />
302+
<ColumnDefinition Width="Auto" />
303303
<ColumnDefinition Width="*" />
304304
<ColumnDefinition Width="Auto" />
305305
</Grid.ColumnDefinitions>
306306

307307
<!-- Item Thumbnail -->
308308
<Grid
309-
Width="24"
309+
Grid.Column="0"
310310
HorizontalAlignment="Left"
311311
VerticalAlignment="Stretch">
312312

313313
<!-- Thumbnail -->
314314
<Grid
315315
x:Name="IconBox"
316-
Width="20"
317-
Height="Auto"
316+
Width="24"
317+
Height="24"
318318
HorizontalAlignment="Center"
319319
VerticalAlignment="Center"
320320
AutomationProperties.Name="{helpers:ResourceString Name=FileBrowserThumbnailIconColumnGrid/AutomationProperties/Name}"
@@ -338,8 +338,8 @@
338338
x:Name="TypeUnknownGlyph"
339339
Width="20"
340340
Height="20"
341-
HorizontalAlignment="Stretch"
342-
VerticalAlignment="Stretch"
341+
HorizontalAlignment="Center"
342+
VerticalAlignment="Center"
343343
x:Load="{x:Bind NeedsPlaceholderGlyph, Mode=OneWay}"
344344
Background="{ThemeResource SystemChromeHighColor}"
345345
CornerRadius="4" />
@@ -386,7 +386,6 @@
386386
DoubleTapped="SelectionCheckbox_DoubleTapped"
387387
Opacity="0"
388388
Unchecked="ItemSelected_Unchecked" />
389-
390389
</Grid>
391390

392391
<!-- Item Name -->
@@ -417,38 +416,26 @@
417416
</TextBox.Resources>
418417
</TextBox>
419418

420-
<Grid Grid.Column="2">
421-
<StackPanel Orientation="Horizontal" Spacing="4">
422-
<!-- Cloud Status -->
423-
<uc:OpacityIcon
424-
x:Name="CloudDriveSyncStatusGlyph"
425-
Width="16"
426-
Height="16"
427-
HorizontalAlignment="Center"
428-
VerticalAlignment="Center"
429-
x:Load="{x:Bind ((cloud:CloudDriveSyncStatusUI)SyncStatusUI).LoadSyncStatus, Mode=OneWay}"
430-
x:Phase="2"
431-
Style="{x:Bind ((cloud:CloudDriveSyncStatusUI)SyncStatusUI).OpacityIcon, Mode=OneWay}" />
432-
433-
<!-- Tag -->
434-
<Ellipse
435-
Width="12"
436-
Height="12"
437-
Margin="8,0,4,0"
438-
x:Phase="2"
439-
Fill="{x:Bind FileTagsUI[0].Color, Mode=OneWay, Converter={StaticResource StringToBrushConverter}}"
440-
ToolTipService.ToolTip="{x:Bind FileTagsUI[0].Name, Mode=OneWay}"
441-
Visibility="{x:Bind FileTagsUI, Converter={StaticResource EmptyObjectToObjectConverter}, Mode=OneWay}" />
442-
</StackPanel>
443-
</Grid>
419+
<!-- Cloud Status -->
420+
<uc:OpacityIcon
421+
x:Name="CloudDriveSyncStatusGlyph"
422+
Grid.Column="2"
423+
Width="16"
424+
Height="16"
425+
HorizontalAlignment="Center"
426+
VerticalAlignment="Center"
427+
x:Load="{x:Bind ((cloud:CloudDriveSyncStatusUI)SyncStatusUI).LoadSyncStatus, Mode=OneWay}"
428+
x:Phase="2"
429+
Style="{x:Bind ((cloud:CloudDriveSyncStatusUI)SyncStatusUI).OpacityIcon, Mode=OneWay}" />
430+
444431
<!-- Visual Status Managing -->
445432
<VisualStateManager.VisualStateGroups>
446433
<VisualStateGroup x:Name="CheckboxVisibilityStates">
447434
<VisualState x:Name="HideCheckbox" />
448435
<VisualState x:Name="ShowCheckbox">
449436
<VisualState.Setters>
450437
<Setter Target="SelectionCheckbox.Opacity" Value="1" />
451-
<Setter Target="IconBox.Visibility" Value="Collapsed" />
438+
<Setter Target="IconBox.Opacity" Value="0" />
452439
</VisualState.Setters>
453440
</VisualState>
454441
</VisualStateGroup>

0 commit comments

Comments
 (0)