Fixed a crash that would occur when viewing properties for drives and multiple items (#2345)

Author: gave92

Files/View Models/Properties/CombinedProperties.cs

@@ -27,6 +27,7 @@ public CombinedProperties(SelectedItemsPropertiesViewModel viewModel, Cancellati
             List = listedItems;
             AppInstance = instance;
             GetBaseProperties();
+            ViewModel.PropertyChanged += ViewModel_PropertyChanged;
         }
 
         public override void GetBaseProperties()
@@ -49,6 +50,12 @@ public override void GetBaseProperties()
 
         public override async void GetSpecialProperties()
         {
+            if (List.All(x => x.PrimaryItemAttribute == StorageItemTypes.File))
+            {
+                ViewModel.IsReadOnly = List.All(x => NativeFileOperationsHelper.HasFileAttribute(x.ItemPath, System.IO.FileAttributes.ReadOnly));
+            }
+            ViewModel.IsHidden = List.All(x => NativeFileOperationsHelper.HasFileAttribute(x.ItemPath, System.IO.FileAttributes.Hidden));
+
             ViewModel.LastSeparatorVisibility = Visibility.Collapsed;
             ViewModel.ItemSizeVisibility = Visibility.Visible;
 
@@ -86,5 +93,36 @@ public override async void GetSpecialProperties()
                 + " (" + ByteSize.FromBytes(totalSize).Bytes.ToString("#,##0") + " " + "ItemSizeBytes".GetLocalized() + ")";
             SetItemsCountString();
         }
+
+        private void ViewModel_PropertyChanged(object sender, System.ComponentModel.PropertyChangedEventArgs e)
+        {
+            switch (e.PropertyName)
+            {
+                case "IsReadOnly":
+                    if (ViewModel.IsReadOnly)
+                    {
+                        List.ForEach(x => NativeFileOperationsHelper.SetFileAttribute(
+                            x.ItemPath, System.IO.FileAttributes.ReadOnly));
+                    }
+                    else
+                    {
+                        List.ForEach(x => NativeFileOperationsHelper.UnsetFileAttribute(
+                            x.ItemPath, System.IO.FileAttributes.ReadOnly));
+                    }
+                    break;
+                case "IsHidden":
+                    if (ViewModel.IsHidden)
+                    {
+                        List.ForEach(x => NativeFileOperationsHelper.SetFileAttribute(
+                            x.ItemPath, System.IO.FileAttributes.Hidden));
+                    }
+                    else
+                    {
+                        List.ForEach(x => NativeFileOperationsHelper.UnsetFileAttribute(
+                            x.ItemPath, System.IO.FileAttributes.Hidden));
+                    }
+                    break;
+            }
+        }
     }
 }

Files/View Models/Properties/FileProperties.cs

@@ -218,6 +218,11 @@ public override void GetBaseProperties()
 
         public override async void GetSpecialProperties()
         {
+            ViewModel.IsReadOnly = NativeFileOperationsHelper.HasFileAttribute(
+                Item.ItemPath, System.IO.FileAttributes.ReadOnly);
+            ViewModel.IsHidden = NativeFileOperationsHelper.HasFileAttribute(
+                Item.ItemPath, System.IO.FileAttributes.Hidden);
+
             ViewModel.ItemSizeVisibility = Visibility.Visible;
             ViewModel.ItemSize = ByteSize.FromBytes(Item.FileSizeBytes).ToBinaryString().ConvertSizeAbbreviation()
                 + " (" + ByteSize.FromBytes(Item.FileSizeBytes).Bytes.ToString("#,##0") + " " + "ItemSizeBytes".GetLocalized() + ")";
@@ -463,6 +468,30 @@ private async void ViewModel_PropertyChanged(object sender, System.ComponentMode
         {
             switch (e.PropertyName)
             {
+                case "IsReadOnly":
+                    if (ViewModel.IsReadOnly)
+                    {
+                        NativeFileOperationsHelper.SetFileAttribute(
+                            Item.ItemPath, System.IO.FileAttributes.ReadOnly);
+                    }
+                    else
+                    {
+                        NativeFileOperationsHelper.UnsetFileAttribute(
+                            Item.ItemPath, System.IO.FileAttributes.ReadOnly);
+                    }
+                    break;
+                case "IsHidden":
+                    if (ViewModel.IsHidden)
+                    {
+                        NativeFileOperationsHelper.SetFileAttribute(
+                            Item.ItemPath, System.IO.FileAttributes.Hidden);
+                    }
+                    else
+                    {
+                        NativeFileOperationsHelper.UnsetFileAttribute(
+                            Item.ItemPath, System.IO.FileAttributes.Hidden);
+                    }
+                    break;
                 case "ShortcutItemPath":
                 case "ShortcutItemWorkingDir":
                 case "ShortcutItemArguments":

Files/View Models/Properties/FolderProperties.cs

@@ -74,6 +74,9 @@ public override void GetBaseProperties()
 
         public async override void GetSpecialProperties()
         {
+            ViewModel.IsHidden = NativeFileOperationsHelper.HasFileAttribute(
+                Item.ItemPath, System.IO.FileAttributes.Hidden);
+
             if (Item.IsShortcutItem)
             {
                 ViewModel.ItemSizeVisibility = Visibility.Visible;
@@ -227,6 +230,18 @@ private async void ViewModel_PropertyChanged(object sender, System.ComponentMode
         {
             switch (e.PropertyName)
             {
+                case "IsHidden":
+                    if (ViewModel.IsHidden)
+                    {
+                        NativeFileOperationsHelper.SetFileAttribute(
+                            Item.ItemPath, System.IO.FileAttributes.Hidden);
+                    }
+                    else
+                    {
+                        NativeFileOperationsHelper.UnsetFileAttribute(
+                            Item.ItemPath, System.IO.FileAttributes.Hidden);
+                    }
+                    break;
                 case "ShortcutItemPath":
                 case "ShortcutItemWorkingDir":
                 case "ShortcutItemArguments":

Files/View Models/SelectedItemsPropertiesViewModel.cs

@@ -768,52 +768,32 @@ public Visibility DetailsSectionVisibility_Media
             set => SetProperty(ref detailsSectionVisibility_Media, value);
         }
 
+        private bool isReadOnly;
+
         public bool IsReadOnly
         {
-            get
-            {
-                return NativeFileOperationsHelper.HasFileAttribute(
-                    Path.Combine(ItemPath, ItemName), FileAttributes.ReadOnly);
-            }
-
+            get => isReadOnly;
             set
             {
-                if (value)
-                {
-                    NativeFileOperationsHelper.SetFileAttribute(
-                        Path.Combine(ItemPath, ItemName), FileAttributes.ReadOnly);
-                }
-                else
-                {
-                    NativeFileOperationsHelper.UnsetFileAttribute(
-                        Path.Combine(ItemPath, ItemName), FileAttributes.ReadOnly);
-                }
-                base.OnPropertyChanged(nameof(IsReadOnly));
+                IsReadOnlyEnabled = true;
+                SetProperty(ref isReadOnly, value);
             }
         }
 
-        public bool IsHidden
+        private bool isReadOnlyEnabled;
+
+        public bool IsReadOnlyEnabled
         {
-            get
-            {
-                return NativeFileOperationsHelper.HasFileAttribute(
-                    Path.Combine(ItemPath, ItemName), FileAttributes.Hidden);
-            }
+            get => isReadOnlyEnabled;
+            set => SetProperty(ref isReadOnlyEnabled, value);
+        }
 
-            set
-            {
-                if (value)
-                {
-                    NativeFileOperationsHelper.SetFileAttribute(
-                        Path.Combine(ItemPath, ItemName), FileAttributes.Hidden);
-                }
-                else
-                {
-                    NativeFileOperationsHelper.UnsetFileAttribute(
-                        Path.Combine(ItemPath, ItemName), FileAttributes.Hidden);
-                }
-                base.OnPropertyChanged(nameof(IsHidden));
-            }
+        private bool isHidden;
+
+        public bool IsHidden
+        {
+            get => isHidden;
+            set => SetProperty(ref isHidden, value);
         }
     }
 }

Files/Views/Pages/PropertiesGeneral.xaml

@@ -362,6 +362,7 @@
                 <CheckBox
                     x:Uid="PropertiesDialogReadOnly"
                     Content="Read-only"
+                    IsEnabled="{x:Bind ViewModel.IsReadOnlyEnabled, Mode=OneWay}"
                     IsChecked="{x:Bind ViewModel.IsReadOnly, Mode=TwoWay}"/>
                 <CheckBox
                     x:Uid="PropertiesDialogHidden"