progress on #16149 -- cleanup (pre-PR)

StorageDevicesService
    Fix spacing of concatenated string that somehow got changed.

GoogleDriveCloudDetector
    Change back to early yield break at end of `GetProviders` to reduce nesting.

GoogleDriveCloudDetector
    Change `AddMyDriveToPathAndValidate` back to private.

GoogleDriveCloudDetector
    Remove call stack logging from `AddMyDriveToPathAndValidate`.

Author: wharvex

src/Files.App/Services/Storage/StorageDevicesService.cs

@@ -23,21 +23,22 @@ public async IAsyncEnumerable<ILocatableFolder> GetDrivesAsync()
 			foreach (var drive in list)
 			{
 				var driveLabel = DriveHelpers.GetExtendedDriveLabel(drive);
-				// We don't want cloud drives to appear in a plain "Drives" section.
+				// Cloud Drive Filter If (CDFI)
+				// We don't want cloud drives to appear in the plain "Drives" sections.
 				if (driveLabel.Equals("Google Drive") || drive.Name.Equals(pCloudDrivePath))
 					continue;
 
 				var res = await FilesystemTasks.Wrap(() => StorageFolder.GetFolderFromPathAsync(drive.Name).AsTask());
 				if (res.ErrorCode is FileSystemStatusCode.Unauthorized)
 				{
 					App.Logger.LogWarning($"{res.ErrorCode}: Attempting to add the device, {drive.Name},"
-					                      + " failed at the StorageFolder initialization step. This device will be ignored.");
+						+ " failed at the StorageFolder initialization step. This device will be ignored.");
 					continue;
 				}
 				else if (!res)
 				{
 					App.Logger.LogWarning($"{res.ErrorCode}: Attempting to add the device, {drive.Name},"
-					                      + " failed at the StorageFolder initialization step. This device will be ignored.");
+						+ " failed at the StorageFolder initialization step. This device will be ignored.");
 					continue;
 				}
 

src/Files.App/Utils/Cloud/Detector/GoogleDriveCloudDetector.cs

@@ -114,14 +114,15 @@ await FilesystemTasks.Wrap(() => StorageFile.GetFileFromPathAsync(Path.Combine(a
 			sw.Stop();
 			Debug.WriteLine($"Google Drive path registry check took {sw.Elapsed} seconds.");
 
-			// Add "My Drive" to the base GD path and return the resulting cloud provider.
-			if (AddMyDriveToPathAndValidate(ref googleDrivePath))
-				yield return new CloudProvider(CloudProviders.GoogleDrive)
-				{
-					Name = "Google Drive",
-					SyncFolder = googleDrivePath,
-					IconData = iconFile is not null ? await iconFile.ToByteArrayAsync() : null
-				};
+			// Add "My Drive" to the base GD path; validate; return the resulting cloud provider.
+			if (!AddMyDriveToPathAndValidate(ref googleDrivePath))
+				yield break;
+			yield return new CloudProvider(CloudProviders.GoogleDrive)
+			{
+				Name = "Google Drive",
+				SyncFolder = googleDrivePath,
+				IconData = iconFile is not null ? await iconFile.ToByteArrayAsync() : null
+			};
 		}
 
 		private static async Task Inspect(SqliteConnection database, string sqlCommand, string targetDescription)
@@ -264,7 +265,7 @@ private static bool ValidatePath(string path)
 			return await FilesystemTasks.Wrap(() => StorageFile.GetFileFromPathAsync(iconPath).AsTask());
 		}
 
-		public static bool AddMyDriveToPathAndValidate(ref string path)
+		private static bool AddMyDriveToPathAndValidate(ref string path)
 		{ 
 			// If `path` contains a shortcut named "My Drive", store its target in `shellFolderBaseFirst`.
 			// This happens when "My Drive syncing options" is set to "Mirror files".
@@ -275,8 +276,7 @@ public static bool AddMyDriveToPathAndValidate(ref string path)
 						si.Name?.Equals("My Drive") ?? false) as ShellLink)?.TargetPath
 				?? string.Empty);
 
-			var callingMethod = new StackFrame(1).GetMethod();
-			Debug.WriteLine($"SHELL FOLDER LOGGING (Context: `{callingMethod?.Name}` in `{callingMethod?.DeclaringType}`)");
+			Debug.WriteLine("SHELL FOLDER LOGGING");
 			rootFolder?.ForEach(si => Debug.WriteLine(si.Name));
 
 			if (!string.IsNullOrEmpty(myDriveFolder))