Skip to content

Commit 2070ee8

Browse files
LamparterLamparter
authored
Merge branch 'files-community:main' into editorconfig
2 parents bc1e574 + 3214f89 commit 2070ee8

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

54 files changed

+1623
-596
lines changed

‎.github/ISSUE_TEMPLATE/bug_report.yml‎

Lines changed: 17 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,13 @@ type: 'Bug'
44
title: 'Bug: '
55
body:
66

7+
# Tip to warn of checking for existing issues
8+
- type: markdown
9+
attributes:
10+
value: |
11+
> [!TIP]
12+
> Have you checked for similar issues? There's a possibility the bug you are experiencing has already been reported. Please do a thorough search before creating a new issue.
13+
714
# Description
815
- type: textarea
916
attributes:
@@ -24,16 +31,6 @@ body:
2431
validations:
2532
required: true
2633

27-
# Requirements
28-
- type: textarea
29-
attributes:
30-
label: Requirements
31-
description: describe the expected behavior (eg. Fix crash that occurs when...). If left blank, the issue will likely be closed without discussion.
32-
value: |
33-
- e.g. Fix crash that occurs when...
34-
validations:
35-
required: true
36-
3734
# Files Version
3835
- type: input
3936
id: files_version
@@ -54,7 +51,7 @@ body:
5451
validations:
5552
required: true
5653

57-
# User ID
54+
# User ID
5855
- type: input
5956
id: user_id
6057
attributes:
@@ -64,6 +61,15 @@ body:
6461
validations:
6562
required: false
6663

64+
# Note that the user should always upload the report rather than pasting it.
65+
- type: markdown
66+
attributes:
67+
value: |
68+
> [!IMPORTANT]
69+
> Please **upload** the log file rather than pasting it here.
70+
>
71+
> Feel free to remove sensitive information such as your usernames or drive names.
72+
6773
# Log File
6874
- type: textarea
6975
attributes:

‎.github/ISSUE_TEMPLATE/code_quality_issue.yml‎

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,18 +3,31 @@ description: Create a code quality issue to help Files keep a clean codebase
33
type: 'Code quality'
44
title: 'Code Quality: '
55
body:
6+
7+
# Tip to warn of checking for existing issues
8+
- type: markdown
9+
attributes:
10+
value: |
11+
> [!TIP]
12+
> Have you checked for similar code quality issues? There's a possibility your suggestion is already being tracked. Please do a thorough search before creating a new issue.
13+
14+
# Issue body
615
- type: textarea
716
attributes:
817
label: Description
918
description: A clear and concise description of what the code quality issue is.
1019
validations:
1120
required: true
21+
22+
# Related code
1223
- type: textarea
1324
attributes:
1425
label: Concerned code
1526
description: A list of the different files and/or areas of the code concerned by the issue.
1627
validations:
1728
required: true
29+
30+
# Gains
1831
- type: textarea
1932
attributes:
2033
label: Gains
@@ -25,6 +38,8 @@ body:
2538
- eg. Clarifying the responsibility of class C.
2639
validations:
2740
required: true
41+
42+
# Requirements
2843
- type: textarea
2944
attributes:
3045
label: Requirements
@@ -33,6 +48,8 @@ body:
3348
- eg. Using a specific design pattern.
3449
- eg. Separating Interface I into three new interfaces I1, I2 and I3.
3550
- eg. Regrouping the duplicated process into a new helper.
51+
52+
# Remarks
3653
- type: textarea
3754
attributes:
3855
label: Comments

‎.github/ISSUE_TEMPLATE/feature_request.yml‎

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,13 @@ type: 'Feature request'
44
title: 'Feature: '
55
body:
66

7+
# Tip to warn of checking for existing issues
8+
- type: markdown
9+
attributes:
10+
value: |
11+
> [!TIP]
12+
>Have you checked for similar feature requests? There's a possibility your suggestion is already being tracked. Please do a thorough search before creating a new issue.
13+
714
# Description
815
- type: textarea
916
attributes:

‎crowdin.yml‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
commit_message: 'fix: new translations in %original_file_name% (%original_file_name%) from Crowdin'
1+
commit_message: 'Translate resources in `%original_file_name%` via Crowdin'
2+
pull_request_title: 'Code Quality: Updated translations'
23
append_commit_message:
34
files:
45
- source: /src/Files.App/Strings/en-US/*.resw

‎src/Files.App.CsWin32/Windows.Win32.ComHeapPtr.cs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ public unsafe struct ComHeapPtr<T> : IDisposable where T : unmanaged
1616
private T* _ptr;
1717

1818
public bool IsNull
19-
=> _ptr == default;
19+
=> _ptr == null;
2020

2121
public ComHeapPtr(T* ptr)
2222
{

‎src/Files.App.CsWin32/Windows.Win32.ComPtr.cs‎

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ public unsafe struct ComPtr<T> : IDisposable where T : unmanaged
1616
private T* _ptr;
1717

1818
public bool IsNull
19-
=> _ptr == default;
19+
=> _ptr == null;
2020

2121
public ComPtr(T* ptr)
2222
{
@@ -38,6 +38,14 @@ public ComPtr(T* ptr)
3838
return (T**)Unsafe.AsPointer(ref Unsafe.AsRef(in this));
3939
}
4040

41+
[MethodImpl(MethodImplOptions.AggressiveInlining)]
42+
public readonly ComPtr<U> As<U>(Guid riid) where U : unmanaged
43+
{
44+
ComPtr<U> pNewPtr = default;
45+
((IUnknown*)_ptr)->QueryInterface(&riid, (void**)pNewPtr.GetAddressOf());
46+
return pNewPtr;
47+
}
48+
4149
[MethodImpl(MethodImplOptions.AggressiveInlining)]
4250
public void Dispose()
4351
{

‎src/Files.App/Strings/af/Resources.resw‎

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -126,6 +126,9 @@
126126
<data name="CopyPathWithQuotes" xml:space="preserve">
127127
<value>Kopieer pad met aanhalings</value>
128128
</data>
129+
<data name="CopyItemPathWithQuotes" xml:space="preserve">
130+
<value>Copy selected item path with quotes</value>
131+
</data>
129132
<data name="Browse" xml:space="preserve">
130133
<value>Blaai</value>
131134
</data>
@@ -249,6 +252,9 @@
249252
<data name="Paste" xml:space="preserve">
250253
<value>Plak</value>
251254
</data>
255+
<data name="PasteShortcut" xml:space="preserve">
256+
<value>Paste shortcut</value>
257+
</data>
252258
<data name="BaseLayoutContextFlyoutNew.Label" xml:space="preserve">
253259
<value>Nuwe</value>
254260
</data>
@@ -1935,6 +1941,9 @@
19351941
<data name="CloseOtherTabs" xml:space="preserve">
19361942
<value>Sluit ander duimgidse</value>
19371943
</data>
1944+
<data name="CloseAllTabs" xml:space="preserve">
1945+
<value>Close all tabs</value>
1946+
</data>
19381947
<data name="Music" xml:space="preserve">
19391948
<value>Musiek</value>
19401949
</data>
@@ -2394,6 +2403,12 @@
23942403
<data name="CopyPathDescription" xml:space="preserve">
23952404
<value>Copy path of selected items to the clipboard</value>
23962405
</data>
2406+
<data name="CopyItemPathDescription" xml:space="preserve">
2407+
<value>Copy path of selected items to the clipboard</value>
2408+
</data>
2409+
<data name="CopyItemPathWithQuotesDescription" xml:space="preserve">
2410+
<value>Copy path of selected items with quotes to the clipboard</value>
2411+
</data>
23972412
<data name="CopyPathWithQuotesDescription" xml:space="preserve">
23982413
<value>Copy path of selected items with quotes to the clipboard</value>
23992414
</data>
@@ -2403,6 +2418,9 @@
24032418
<data name="PasteItemDescription" xml:space="preserve">
24042419
<value>Paste item(s) from clipboard to current folder</value>
24052420
</data>
2421+
<data name="PasteShortcutDescription" xml:space="preserve">
2422+
<value>Paste item(s) from clipboard to current folder as shortcuts</value>
2423+
</data>
24062424
<data name="PasteItemToSelectionDescription" xml:space="preserve">
24072425
<value>Paste item(s) from clipboard to selected folder</value>
24082426
</data>
@@ -2682,6 +2700,9 @@
26822700
<data name="CloseOtherTabsSelectedDescription" xml:space="preserve">
26832701
<value>Close tabs other than selected tab</value>
26842702
</data>
2703+
<data name="CloseAllTabsDescription" xml:space="preserve">
2704+
<value>Close all tabs including the current tab</value>
2705+
</data>
26852706
<data name="ReopenClosedTabDescription" xml:space="preserve">
26862707
<value>Reopen last closed tab</value>
26872708
</data>

‎src/Files.App/Strings/ar/Resources.resw‎

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -126,6 +126,9 @@
126126
<data name="CopyPathWithQuotes" xml:space="preserve">
127127
<value>نسخ المسار مع الاقتباس</value>
128128
</data>
129+
<data name="CopyItemPathWithQuotes" xml:space="preserve">
130+
<value>Copy selected item path with quotes</value>
131+
</data>
129132
<data name="Browse" xml:space="preserve">
130133
<value>تصفح</value>
131134
</data>
@@ -249,6 +252,9 @@
249252
<data name="Paste" xml:space="preserve">
250253
<value>لصق</value>
251254
</data>
255+
<data name="PasteShortcut" xml:space="preserve">
256+
<value>Paste shortcut</value>
257+
</data>
252258
<data name="BaseLayoutContextFlyoutNew.Label" xml:space="preserve">
253259
<value>جديدة</value>
254260
</data>
@@ -1935,6 +1941,9 @@
19351941
<data name="CloseOtherTabs" xml:space="preserve">
19361942
<value>إغلاق علامات التبويب الأخرى</value>
19371943
</data>
1944+
<data name="CloseAllTabs" xml:space="preserve">
1945+
<value>Close all tabs</value>
1946+
</data>
19381947
<data name="Music" xml:space="preserve">
19391948
<value>موسيقى</value>
19401949
</data>
@@ -2394,6 +2403,12 @@
23942403
<data name="CopyPathDescription" xml:space="preserve">
23952404
<value>نسخ مسار العناصر المحددة إلى الحافظة</value>
23962405
</data>
2406+
<data name="CopyItemPathDescription" xml:space="preserve">
2407+
<value>Copy path of selected items to the clipboard</value>
2408+
</data>
2409+
<data name="CopyItemPathWithQuotesDescription" xml:space="preserve">
2410+
<value>Copy path of selected items with quotes to the clipboard</value>
2411+
</data>
23972412
<data name="CopyPathWithQuotesDescription" xml:space="preserve">
23982413
<value>نسخ مسار العناصر المحددة مع الاقتباسات إلى الحافظة</value>
23992414
</data>
@@ -2403,6 +2418,9 @@
24032418
<data name="PasteItemDescription" xml:space="preserve">
24042419
<value>لصق العناصر من الحافظة إلى المجلد الحالي</value>
24052420
</data>
2421+
<data name="PasteShortcutDescription" xml:space="preserve">
2422+
<value>Paste item(s) from clipboard to current folder as shortcuts</value>
2423+
</data>
24062424
<data name="PasteItemToSelectionDescription" xml:space="preserve">
24072425
<value>لصق العناصر من الحافظة إلى المجلد المحدد</value>
24082426
</data>
@@ -2682,6 +2700,9 @@
26822700
<data name="CloseOtherTabsSelectedDescription" xml:space="preserve">
26832701
<value>إغلاق علامات التبويب غير علامة التبويب المحددة</value>
26842702
</data>
2703+
<data name="CloseAllTabsDescription" xml:space="preserve">
2704+
<value>Close all tabs including the current tab</value>
2705+
</data>
26852706
<data name="ReopenClosedTabDescription" xml:space="preserve">
26862707
<value>إعادة فتح آخر علامة تبويب مغلقة</value>
26872708
</data>

‎src/Files.App/Strings/be-BY/Resources.resw‎

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -126,6 +126,9 @@
126126
<data name="CopyPathWithQuotes" xml:space="preserve">
127127
<value>Скапіяваць шлях з двукоссем</value>
128128
</data>
129+
<data name="CopyItemPathWithQuotes" xml:space="preserve">
130+
<value>Copy selected item path with quotes</value>
131+
</data>
129132
<data name="Browse" xml:space="preserve">
130133
<value>Агляд</value>
131134
</data>
@@ -249,6 +252,9 @@
249252
<data name="Paste" xml:space="preserve">
250253
<value>Уставіць</value>
251254
</data>
255+
<data name="PasteShortcut" xml:space="preserve">
256+
<value>Paste shortcut</value>
257+
</data>
252258
<data name="BaseLayoutContextFlyoutNew.Label" xml:space="preserve">
253259
<value>Новы</value>
254260
</data>
@@ -1934,6 +1940,9 @@
19341940
<data name="CloseOtherTabs" xml:space="preserve">
19351941
<value>Close other tabs</value>
19361942
</data>
1943+
<data name="CloseAllTabs" xml:space="preserve">
1944+
<value>Close all tabs</value>
1945+
</data>
19371946
<data name="Music" xml:space="preserve">
19381947
<value>Music</value>
19391948
</data>
@@ -2393,6 +2402,12 @@
23932402
<data name="CopyPathDescription" xml:space="preserve">
23942403
<value>Copy path of selected items to the clipboard</value>
23952404
</data>
2405+
<data name="CopyItemPathDescription" xml:space="preserve">
2406+
<value>Copy path of selected items to the clipboard</value>
2407+
</data>
2408+
<data name="CopyItemPathWithQuotesDescription" xml:space="preserve">
2409+
<value>Copy path of selected items with quotes to the clipboard</value>
2410+
</data>
23962411
<data name="CopyPathWithQuotesDescription" xml:space="preserve">
23972412
<value>Copy path of selected items with quotes to the clipboard</value>
23982413
</data>
@@ -2402,6 +2417,9 @@
24022417
<data name="PasteItemDescription" xml:space="preserve">
24032418
<value>Paste item(s) from clipboard to current folder</value>
24042419
</data>
2420+
<data name="PasteShortcutDescription" xml:space="preserve">
2421+
<value>Paste item(s) from clipboard to current folder as shortcuts</value>
2422+
</data>
24052423
<data name="PasteItemToSelectionDescription" xml:space="preserve">
24062424
<value>Paste item(s) from clipboard to selected folder</value>
24072425
</data>
@@ -2681,6 +2699,9 @@
26812699
<data name="CloseOtherTabsSelectedDescription" xml:space="preserve">
26822700
<value>Close tabs other than selected tab</value>
26832701
</data>
2702+
<data name="CloseAllTabsDescription" xml:space="preserve">
2703+
<value>Close all tabs including the current tab</value>
2704+
</data>
26842705
<data name="ReopenClosedTabDescription" xml:space="preserve">
26852706
<value>Reopen last closed tab</value>
26862707
</data>

0 commit comments

Comments
 (0)