avoid async call if not needed

marcofranzen99 · marcofranzen99 · commit 210999688aa6 · 2025-08-08T09:52:20.000+02:00
diff --git a/src/Files.App/Helpers/Win32/Win32Helper.Storage.cs b/src/Files.App/Helpers/Win32/Win32Helper.Storage.cs
@@ -29,7 +29,13 @@ public static partial class Win32Helper
 		public static async Task<string?> GetFileAssociationAsync(string filename, bool checkDesktopFirst = false)
 		{
 			if (checkDesktopFirst)
-				return GetDesktopFileAssociation(filename) ?? (await GetUwpFileAssociations(filename)).FirstOrDefault();
+			{
+				var desktopAssociation = GetDesktopFileAssociation(filename);
+				if (desktopAssociation is not null)
+					return desktopAssociation;
+
+				return (await GetUwpFileAssociations(filename)).FirstOrDefault();
+			}
 
 			return (await GetUwpFileAssociations(filename)).FirstOrDefault() ?? GetDesktopFileAssociation(filename);
 		}

Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,13 @@ public static partial class Win32Helper`
`29`	`29`	`public static async Task<string?> GetFileAssociationAsync(string filename, bool checkDesktopFirst = false)`
`30`	`30`	`{`
`31`	`31`	`if (checkDesktopFirst)`
`32`		`- return GetDesktopFileAssociation(filename) ?? (await GetUwpFileAssociations(filename)).FirstOrDefault();`
	`32`	`+ {`
	`33`	`+ var desktopAssociation = GetDesktopFileAssociation(filename);`
	`34`	`+ if (desktopAssociation is not null)`
	`35`	`+ return desktopAssociation;`
	`36`	`+`
	`37`	`+ return (await GetUwpFileAssociations(filename)).FirstOrDefault();`
	`38`	`+ }`
`33`	`39`
`34`	`40`	`return (await GetUwpFileAssociations(filename)).FirstOrDefault() ?? GetDesktopFileAssociation(filename);`
`35`	`41`	`}`