Skip to content

Commit 229be37

Browse files
committed
Revert "Code Quality: Fixed WMC1506 & WMC1507 build warning"
This reverts commit 6672f94.
1 parent 6672f94 commit 229be37

File tree

8 files changed

+24
-24
lines changed

8 files changed

+24
-24
lines changed

src/Files.App/UserControls/Pane/InfoPane.xaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -396,7 +396,7 @@
396396
Height="28"
397397
Padding="12,0,12,0"
398398
VerticalAlignment="Center"
399-
x:Load="{x:Bind IsTag, Mode=OneTime}"
399+
x:Load="{x:Bind IsTag, Mode=OneWay}"
400400
AutomationProperties.Name="{x:Bind AsTag.Tag.Name, Mode=OneWay}"
401401
Orientation="Horizontal"
402402
Spacing="8"
@@ -425,11 +425,11 @@
425425
Height="28"
426426
Padding="12,0,12,0"
427427
VerticalAlignment="Center"
428-
x:Load="{x:Bind IsFlyout, Mode=OneTime}"
428+
x:Load="{x:Bind IsFlyout, Mode=OneWay}"
429429
AutomationProperties.Name="{helpers:ResourceString Name=EditTags}"
430430
Background="Transparent"
431431
BorderThickness="0"
432-
Flyout="{x:Bind AsFlyout.Flyout, Mode=OneTime}"
432+
Flyout="{x:Bind AsFlyout.Flyout, Mode=OneWay}"
433433
ToolTipService.ToolTip="{helpers:ResourceString Name=EditTags}">
434434
<Button.Resources>
435435
<SolidColorBrush x:Key="ButtonBackgroundPointerOver" Color="Transparent" />

src/Files.App/UserControls/PathBreadcrumb.xaml

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -24,14 +24,14 @@
2424
<StackPanel
2525
x:Name="ListViewItemContentGrid"
2626
AllowDrop="True"
27-
AutomationProperties.Name="{x:Bind Title, Mode=OneTime}"
27+
AutomationProperties.Name="{x:Bind Title, Mode=OneWay}"
2828
Background="Transparent"
2929
DragLeave="PathBoxItem_DragLeave"
3030
DragOver="PathBoxItem_DragOver"
3131
Drop="PathBoxItem_Drop"
3232
Orientation="Horizontal"
3333
Spacing="4"
34-
Tag="{x:Bind Path, Mode=OneTime}">
34+
Tag="{x:Bind Path, Mode=OneWay}">
3535
<i:Interaction.Behaviors>
3636
<i:EventTriggerBehavior EventName="PointerEntered">
3737
<i:ChangePropertyAction PropertyName="Opacity" Value="0.7" />
@@ -45,7 +45,7 @@
4545
<TextBlock
4646
FontSize="12"
4747
FontWeight="Medium"
48-
Text="{x:Bind Title, Mode=OneTime}" />
48+
Text="{x:Bind Title, Mode=OneWay}" />
4949

5050
</StackPanel>
5151
</DataTemplate>
@@ -56,22 +56,22 @@
5656
x:Name="ListViewItemContentGrid"
5757
VerticalAlignment="Center"
5858
AllowDrop="True"
59-
AutomationProperties.Name="{x:Bind Title, Mode=OneTime}"
59+
AutomationProperties.Name="{x:Bind Title, Mode=OneWay}"
6060
Background="Transparent"
6161
DragLeave="PathBoxItem_DragLeave"
6262
DragOver="PathBoxItem_DragOver"
6363
Drop="PathBoxItem_Drop"
6464
Orientation="Horizontal"
6565
Spacing="4"
66-
Tag="{x:Bind Path, Mode=OneTime}">
66+
Tag="{x:Bind Path, Mode=OneWay}">
6767

6868
<!-- Header -->
6969
<TextBlock
7070
Padding="0,4"
7171
FontSize="12"
7272
PointerPressed="PathBoxItem_PointerPressed"
7373
Tapped="PathBoxItem_Tapped"
74-
Text="{x:Bind Title, Mode=OneTime}">
74+
Text="{x:Bind Title, Mode=OneWay}">
7575
<i:Interaction.Behaviors>
7676
<i:EventTriggerBehavior EventName="PointerEntered">
7777
<i:ChangePropertyAction PropertyName="Opacity" Value="0.7" />

src/Files.App/Views/Layouts/ColumnLayoutPage.xaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -249,7 +249,7 @@
249249
x:Load="{x:Bind NeedsPlaceholderGlyph, Mode=OneWay}" />
250250

251251
<Image
252-
x:Name="_IconOverlay"
252+
x:Name="IconOverlay"
253253
Width="16"
254254
Height="16"
255255
Margin="2"

src/Files.App/Views/Layouts/DetailsLayoutPage.xaml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -938,7 +938,7 @@
938938
x:Load="{x:Bind NeedsPlaceholderGlyph, Mode=OneWay}" />
939939

940940
<Image
941-
x:Name="_IconOverlay"
941+
x:Name="IconOverlay"
942942
Width="16"
943943
Height="16"
944944
Margin="2"
@@ -1166,7 +1166,7 @@
11661166

11671167
<!-- Item Path -->
11681168
<TextBlock
1169-
x:Name="_ItemPath"
1169+
x:Name="ItemPath"
11701170
Width="{Binding ColumnsViewModel.PathColumn.LengthIncludingGridSplitter.Value, ElementName=PageRoot, Mode=OneWay}"
11711171
Padding="10,0,0,0"
11721172
HorizontalAlignment="Stretch"
@@ -1207,7 +1207,7 @@
12071207

12081208
<!-- Item Modified Date -->
12091209
<TextBlock
1210-
x:Name="_ItemDateModified"
1210+
x:Name="ItemDateModified"
12111211
Width="{Binding ColumnsViewModel.DateModifiedColumn.LengthIncludingGridSplitter.Value, ElementName=PageRoot, Mode=OneWay}"
12121212
Padding="10,0,0,0"
12131213
HorizontalAlignment="Stretch"
@@ -1220,7 +1220,7 @@
12201220

12211221
<!-- Item Created Date -->
12221222
<TextBlock
1223-
x:Name="_ItemDateCreated"
1223+
x:Name="ItemDateCreated"
12241224
Width="{Binding ColumnsViewModel.DateCreatedColumn.LengthIncludingGridSplitter.Value, ElementName=PageRoot, Mode=OneWay}"
12251225
Padding="10,0,0,0"
12261226
HorizontalAlignment="Stretch"
@@ -1233,7 +1233,7 @@
12331233

12341234
<!-- Item Type -->
12351235
<TextBlock
1236-
x:Name="_ItemType"
1236+
x:Name="ItemType"
12371237
Width="{Binding ColumnsViewModel.ItemTypeColumn.LengthIncludingGridSplitter.Value, ElementName=PageRoot, Mode=OneWay}"
12381238
Padding="10,0,0,0"
12391239
HorizontalAlignment="Stretch"

src/Files.App/Views/Layouts/GridLayoutPage.xaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,7 @@
134134
x:Load="{x:Bind NeedsPlaceholderGlyph, Mode=OneWay}" />
135135

136136
<Image
137-
x:Name="_IconOverlay"
137+
x:Name="IconOverlay"
138138
Width="32"
139139
Height="32"
140140
Margin="16"
@@ -326,7 +326,7 @@
326326
x:Load="{x:Bind NeedsPlaceholderGlyph, Mode=OneWay}" />
327327

328328
<Image
329-
x:Name="_IconOverlay"
329+
x:Name="IconOverlay"
330330
Width="16"
331331
Height="16"
332332
Margin="2"
@@ -475,7 +475,7 @@
475475
x:Load="{x:Bind NeedsPlaceholderGlyph, Mode=OneWay}" />
476476

477477
<Image
478-
x:Name="_IconOverlay"
478+
x:Name="IconOverlay"
479479
Width="32"
480480
Height="32"
481481
Margin="-10"

src/Files.App/Views/Properties/CustomizationPage.xaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@
8787
x:Name="PickDllFileButton"
8888
Grid.Column="1"
8989
Command="{x:Bind CustomizationViewModel.OpenFilePickerCommand, Mode=OneWay}"
90-
CommandParameter="{x:Bind XamlRoot, Mode=OneTime}"
90+
CommandParameter="{x:Bind XamlRoot, Mode=OneWay}"
9191
Content="{helpers:ResourceString Name=Browse}" />
9292

9393
</Grid>

src/Files.App/Views/Settings/AppearancePage.xaml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,11 +27,11 @@
2727
<DataTemplate x:Key="AppThemeResourcesItemTemplate" x:DataType="dataitem:AppThemeResourceItem">
2828
<Grid
2929
Width="120"
30-
AutomationProperties.Name="{x:Bind Name, Mode=OneTime}"
30+
AutomationProperties.Name="{x:Bind Name, Mode=OneWay}"
3131
BorderBrush="{ThemeResource ControlElevationBorderBrush}"
3232
BorderThickness="1"
3333
CornerRadius="6"
34-
ToolTipService.ToolTip="{x:Bind Name, Mode=OneTime}">
34+
ToolTipService.ToolTip="{x:Bind Name, Mode=OneWay}">
3535
<Grid.RowDefinitions>
3636
<RowDefinition Height="16" />
3737
<RowDefinition Height="50" />
@@ -41,7 +41,7 @@
4141
<Border
4242
Grid.RowSpan="2"
4343
Height="66"
44-
Background="{x:Bind BackgroundColor, Converter={StaticResource StringToBrushConverter}, Mode=OneTime}"
44+
Background="{x:Bind BackgroundColor, Converter={StaticResource StringToBrushConverter}, Mode=OneWay}"
4545
CornerRadius="4,4,0,0" />
4646

4747
<!-- Tab Bar -->
@@ -79,7 +79,7 @@
7979
Grid.Row="2"
8080
Padding="4"
8181
HorizontalAlignment="Center"
82-
Text="{x:Bind Name, Mode=OneTime}"
82+
Text="{x:Bind Name, Mode=OneWay}"
8383
TextTrimming="CharacterEllipsis" />
8484
</Grid>
8585
</DataTemplate>

src/Files.App/Views/Settings/TagsPage.xaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -166,7 +166,7 @@
166166
Padding="12"
167167
HorizontalAlignment="Stretch"
168168
AllowDrop="True"
169-
CanReorderItems="{x:Bind AllowItemsDrag, Mode=OneTime}"
169+
CanReorderItems="{x:Bind AllowItemsDrag, Mode=OneWay}"
170170
IsItemClickEnabled="True"
171171
ItemsSource="{x:Bind ViewModel.Tags, Mode=TwoWay}"
172172
ReorderMode="Enabled"

0 commit comments

Comments
 (0)