Code Quality: Refactor icon loading in PinnedFoldersManager

Extracted icon loading logic into asynchronous helper methods for better separation of concerns and error handling. This improves code readability and robustness when setting icons for location items.

Author: yaira2

src/Files.App/Data/Models/PinnedFoldersManager.cs

@@ -104,30 +104,53 @@ public async Task<LocationItem> CreateLocationItemFromPathAsync(string path)
 			{
 				locationItem.IsInvalid = false;
 				if (res.Result is not null)
-				{
-					var result = await FileThumbnailHelper.GetIconAsync(
-						res.Result.Path,
-						Constants.ShellIconSizes.Small,
-						true,
-						IconOptions.ReturnIconOnly | IconOptions.UseCurrentScale);
-
-					locationItem.IconData = result;
-
-					var bitmapImage = await MainWindow.Instance.DispatcherQueue.EnqueueOrInvokeAsync(() => locationItem.IconData.ToBitmapAsync(), Microsoft.UI.Dispatching.DispatcherQueuePriority.Normal);
-					if (bitmapImage is not null)
-						locationItem.Icon = bitmapImage;
-				}
+					_ = LoadIconForLocationItemAsync(locationItem, res.Result.Path);
 			}
 			else
 			{
-				locationItem.Icon = await MainWindow.Instance.DispatcherQueue.EnqueueOrInvokeAsync(() => UIHelpers.GetSidebarIconResource(Constants.ImageRes.Folder));
 				locationItem.IsInvalid = true;
 				Debug.WriteLine($"Pinned item was invalid {res?.ErrorCode}, item: {path}");
+				_ = LoadDefaultIconForLocationItemAsync(locationItem);
 			}
 
 			return locationItem;
 		}
 
+		private async Task LoadIconForLocationItemAsync(LocationItem locationItem, string path)
+		{
+			try
+			{
+				var result = await FileThumbnailHelper.GetIconAsync(
+					path,
+					Constants.ShellIconSizes.Small,
+					true,
+					IconOptions.ReturnIconOnly | IconOptions.UseCurrentScale);
+
+				locationItem.IconData = result;
+
+				var bitmapImage = await MainWindow.Instance.DispatcherQueue.EnqueueOrInvokeAsync(() => locationItem.IconData.ToBitmapAsync(), Microsoft.UI.Dispatching.DispatcherQueuePriority.Normal);
+				if (bitmapImage is not null)
+					locationItem.Icon = bitmapImage;
+			}
+			catch (Exception ex)
+			{
+				Debug.WriteLine($"Error loading icon for {path}: {ex.Message}");
+			}
+		}
+
+		private async Task LoadDefaultIconForLocationItemAsync(LocationItem locationItem)
+		{
+			try
+			{
+				var defaultIcon = await MainWindow.Instance.DispatcherQueue.EnqueueOrInvokeAsync(() => UIHelpers.GetSidebarIconResource(Constants.ImageRes.Folder));
+				locationItem.Icon = defaultIcon;
+			}
+			catch (Exception ex)
+			{
+				Debug.WriteLine($"Error loading default icon: {ex.Message}");
+			}
+		}
+
 		/// <summary>
 		/// Adds the item (from a path) to the navigation sidebar
 		/// </summary>