Fix: Fixed issue where changing sort preferences didn't work properly when the sync option was on (#15228)

hishitetsu · web-flow · commit 27ec4a98c6bf · 2024-04-19T07:55:57.000-07:00
diff --git a/src/Files.App/Utils/Serialization/BaseJsonSettings.cs b/src/Files.App/Utils/Serialization/BaseJsonSettings.cs
@@ -95,7 +95,9 @@ protected virtual bool Set<TValue>(TValue? value, [CallerMemberName] string prop
 				return false;
 			}
 
-			if (JsonSettingsDatabase?.SetValue(propertyName, value) ?? false)
+			if (JsonSettingsDatabase is not null &&
+				(!JsonSettingsDatabase.GetValue<TValue>(propertyName)?.Equals(value) ?? true) &&
+				JsonSettingsDatabase.SetValue(propertyName, value))
 			{
 				RaiseOnSettingChangedEvent(this, new SettingChangedEventArgs(propertyName, value));
 				return true;

Original file line number	Diff line number	Diff line change
`@@ -95,7 +95,9 @@ protected virtual bool Set<TValue>(TValue? value, [CallerMemberName] string prop`
`95`	`95`	`return false;`
`96`	`96`	`}`
`97`	`97`
`98`		`- if (JsonSettingsDatabase?.SetValue(propertyName, value) ?? false)`
	`98`	`+ if (JsonSettingsDatabase is not null &&`
	`99`	`+ (!JsonSettingsDatabase.GetValue<TValue>(propertyName)?.Equals(value) ?? true) &&`
	`100`	`+ JsonSettingsDatabase.SetValue(propertyName, value))`
`99`	`101`	`{`
`100`	`102`	`RaiseOnSettingChangedEvent(this, new SettingChangedEventArgs(propertyName, value));`
`101`	`103`	`return true;`