Added border to status bar to match design spec (#6003)

Author: yaira2

Files/ViewModels/ColumnsViewModel.cs

@@ -8,7 +8,7 @@ public class ColumnsViewModel : ObservableObject
     {
         private ColumnViewModel iconColumn = new ColumnViewModel()
         {
-            UserLength = new GridLength(44, GridUnitType.Pixel),
+            UserLength = new GridLength(24, GridUnitType.Pixel),
             IsResizeable = false,
         };
 

Files/Views/LayoutModes/DetailsLayoutBrowser.xaml

@@ -54,6 +54,7 @@
                 TargetType="controls:GridSplitter">
                 <Setter Property="Background" Value="Transparent" />
                 <Setter Property="Width" Value="1" />
+                <Setter Property="Margin" Value="0,4,0,4" />
                 <Setter Property="Opacity" Value="0.8" />
             </Style>
 
@@ -208,7 +209,6 @@
             <SemanticZoom.ZoomedInView>
                 <ListView
                     x:Name="FileList"
-                    Margin="0,4,0,0"
                     Padding="8,0,8,12"
                     HorizontalAlignment="Stretch"
                     VerticalContentAlignment="Stretch"
@@ -242,11 +242,10 @@
                     <ListView.Header>
                         <Grid
                             x:Name="HeaderGrid"
-                            Height="38"
-                            Margin="16,0,0,0"
-                            Padding="0"
+                            Height="40"
+                            Padding="16,0,0,0"
                             Background="{ThemeResource FileBrowserHeaderBackgroundBrush}"
-                            BorderBrush="{ThemeResource SystemChromeHighColor}"
+                            BorderBrush="{ThemeResource ControlStrokeColorDefault}"
                             BorderThickness="0,0,0,1"
                             PointerPressed="Grid_PointerPressed">
                             <Grid.ContextFlyout>

Files/Views/PaneHolderPage.xaml

@@ -65,59 +65,29 @@
                 <RowDefinition Height="*" />
             </Grid.RowDefinitions>
 
-            <Border x:Name="PaneLeftLoader" Grid.Row="1">
-                <local:ModernShellPage
-                    x:Name="PaneLeft"
-                    ContentChanged="Pane_ContentChanged"
-                    CurrentInstanceBorderThickness="0,0,0,2"
-                    IsPageMainPane="True"
-                    Loaded="PaneLeft_Loaded"
-                    NavParams="{x:Bind NavParamsLeft, Mode=OneWay}"
-                    PaneHolder="{x:Bind}" />
-            </Border>
+            <local:ModernShellPage
+                x:Name="PaneLeft"
+                Grid.Row="1"
+                BorderBrush="{ThemeResource ControlStrokeColorDefault}"
+                ContentChanged="Pane_ContentChanged"
+                CurrentInstanceBorderThickness="0,0,0,1"
+                IsPageMainPane="True"
+                Loaded="PaneLeft_Loaded"
+                NavParams="{x:Bind NavParamsLeft, Mode=OneWay}"
+                PaneHolder="{x:Bind}" />
 
-            <Border
-                x:Name="PaneRightLoader"
+            <local:ModernShellPage
+                x:Name="PaneRight"
                 Grid.Row="1"
                 Grid.Column="1"
                 x:Load="{x:Bind IsRightPaneVisible, Mode=OneWay}"
-                BorderBrush="{ThemeResource PaneBorderBrush}"
-                BorderThickness="2,0,0,0">
-
-                <local:ModernShellPage
-                    x:Name="PaneRight"
-                    ContentChanged="Pane_ContentChanged"
-                    CurrentInstanceBorderThickness="0,0,0,2"
-                    IsPageMainPane="False"
-                    Loaded="PaneRight_Loaded"
-                    NavParams="{x:Bind NavParamsRight, Mode=OneWay}"
-                    PaneHolder="{x:Bind}" />
-
-                <animations:Implicit.ShowAnimations>
-                    <animations:ScalarAnimation
-                        Target="Translation.X"
-                        From="300"
-                        To="0"
-                        Duration="0:0:0.2" />
-                    <animations:ScalarAnimation
-                        Target="Opacity"
-                        From="0"
-                        To="1"
-                        Duration="0:0:0.2" />
-                </animations:Implicit.ShowAnimations>
-                <animations:Implicit.HideAnimations>
-                    <animations:ScalarAnimation
-                        Target="Translation.X"
-                        From="0"
-                        To="300"
-                        Duration="0:0:0.2" />
-                    <animations:ScalarAnimation
-                        Target="Opacity"
-                        From="1"
-                        To="0"
-                        Duration="0:0:0.2" />
-                </animations:Implicit.HideAnimations>
-            </Border>
+                BorderBrush="{ThemeResource ControlStrokeColorDefault}"
+                ContentChanged="Pane_ContentChanged"
+                CurrentInstanceBorderThickness="0,0,0,1"
+                IsPageMainPane="False"
+                Loaded="PaneRight_Loaded"
+                NavParams="{x:Bind NavParamsRight, Mode=OneWay}"
+                PaneHolder="{x:Bind}" />
 
             <Custom:GridSplitter
                 x:Name="PaneResizer"
@@ -148,24 +118,40 @@
                         PropertyName="CurrentInstanceBorderBrush"
                         TargetObject="{Binding ElementName=PaneLeft}"
                         Value="{StaticResource PaneSelectedBorderBrush}" />
+                    <Core:ChangePropertyAction
+                        PropertyName="CurrentInstanceBorderThickness"
+                        TargetObject="{Binding ElementName=PaneLeft}"
+                        Value="0,0,0,2" />
                 </Core:DataTriggerBehavior>
                 <Core:DataTriggerBehavior Binding="{x:Bind converters:MultiBooleanConverter.AndConvert(IsLeftPaneActive, IsRightPaneVisible), Mode=OneWay}" Value="False">
                     <Core:ChangePropertyAction
                         PropertyName="CurrentInstanceBorderBrush"
                         TargetObject="{Binding ElementName=PaneLeft}"
-                        Value="{StaticResource SystemControlTransparentBrush}" />
+                        Value="{StaticResource ControlStrokeColorDefault}" />
+                    <Core:ChangePropertyAction
+                        PropertyName="CurrentInstanceBorderThickness"
+                        TargetObject="{Binding ElementName=PaneLeft}"
+                        Value="0,0,0,1" />
                 </Core:DataTriggerBehavior>
                 <Core:DataTriggerBehavior Binding="{x:Bind converters:MultiBooleanConverter.AndConvert(IsRightPaneActive, IsRightPaneVisible), Mode=OneWay}" Value="True">
                     <Core:ChangePropertyAction
                         PropertyName="CurrentInstanceBorderBrush"
                         TargetObject="{Binding ElementName=PaneRight}"
                         Value="{StaticResource PaneSelectedBorderBrush}" />
+                    <Core:ChangePropertyAction
+                        PropertyName="CurrentInstanceBorderThickness"
+                        TargetObject="{Binding ElementName=PaneRight}"
+                        Value="0,0,0,2" />
                 </Core:DataTriggerBehavior>
                 <Core:DataTriggerBehavior Binding="{x:Bind converters:MultiBooleanConverter.AndConvert(IsRightPaneActive, IsRightPaneVisible), Mode=OneWay}" Value="False">
                     <Core:ChangePropertyAction
                         PropertyName="CurrentInstanceBorderBrush"
                         TargetObject="{Binding ElementName=PaneRight}"
-                        Value="{StaticResource SystemControlTransparentBrush}" />
+                        Value="{StaticResource ControlStrokeColorDefault}" />
+                    <Core:ChangePropertyAction
+                        PropertyName="CurrentInstanceBorderThickness"
+                        TargetObject="{Binding ElementName=PaneRight}"
+                        Value="0,0,0,1" />
                 </Core:DataTriggerBehavior>
                 <Core:DataTriggerBehavior Binding="{x:Bind IsRightPaneVisible, Mode=OneWay}" Value="True">
                     <Core:ChangePropertyAction