Code Quality: Switch DirectN to CsWin32 (#15385)

Author: gave92

src/Files.App/Files.App.csproj

@@ -69,7 +69,6 @@
     <ItemGroup>
         <PackageReference Include="ByteSize" Version="2.1.2" />
         <PackageReference Include="CommunityToolkit.Mvvm" Version="8.2.2" />
-        <PackageReference Include="DirectNCore" Version="1.16.0" />
         <PackageReference Include="DiscUtils.Udf" Version="0.16.13" />
         <PackageReference Include="FluentFTP" Version="43.0.1" />
         <PackageReference Include="ini-parser-netstandard" Version="2.5.2" />

src/Files.App/NativeMethods.txt

@@ -45,4 +45,12 @@ MoveFileFromApp
 DeleteFileFromApp
 RemoveDirectoryFromApp
 GetKeyState
-CreateDirectoryFromApp
+CreateDirectoryFromApp
+D3D_DRIVER_TYPE
+D3D_FEATURE_LEVEL
+ID3D11Device
+ID3D11DeviceContext
+D3D11CreateDevice
+IDXGIDevice
+DCompositionCreateDevice
+IDCompositionDevice

src/Files.App/ViewModels/UserControls/Previews/ShellPreviewViewModel.cs

@@ -1,11 +1,15 @@
-using DirectN;
-using Files.App.ViewModels.Properties;
+using Files.App.ViewModels.Properties;
 using Microsoft.UI.Content;
 using Microsoft.UI.Xaml;
 using Microsoft.UI.Xaml.Hosting;
 using System.Runtime.InteropServices;
 using System.Text;
 using Vanara.PInvoke;
+using Windows.Win32;
+using Windows.Win32.Graphics.Direct3D;
+using Windows.Win32.Graphics.Direct3D11;
+using Windows.Win32.Graphics.Dxgi;
+using Windows.Win32.Graphics.DirectComposition;
 using WinRT;
 using static Vanara.PInvoke.ShlwApi;
 using static Vanara.PInvoke.User32;
@@ -112,7 +116,7 @@ public void LoadPreview(UIElement presenter)
 			_ = ChildWindowToXaml(parent, presenter);
 		}
 
-		private bool ChildWindowToXaml(IntPtr parent, UIElement presenter)
+		private unsafe bool ChildWindowToXaml(IntPtr parent, UIElement presenter)
 		{
 			D3D_DRIVER_TYPE[] driverTypes =
 			[
@@ -122,36 +126,36 @@ private bool ChildWindowToXaml(IntPtr parent, UIElement presenter)
 
 			ID3D11Device? d3d11Device = null;
 			ID3D11DeviceContext? d3d11DeviceContext = null;
-			D3D_FEATURE_LEVEL featureLevelSupported;
 
 			foreach (var driveType in driverTypes)
 			{
-				var hr = D3D11Functions.D3D11CreateDevice(
+				var hr = PInvoke.D3D11CreateDevice(
 					null,
 					driveType,
-					IntPtr.Zero,
-					(uint)D3D11_CREATE_DEVICE_FLAG.D3D11_CREATE_DEVICE_BGRA_SUPPORT,
+					new(IntPtr.Zero),
+					D3D11_CREATE_DEVICE_FLAG.D3D11_CREATE_DEVICE_BGRA_SUPPORT,
 					null,
 					0,
 					7,
 					out d3d11Device,
-					out featureLevelSupported,
+					null,
 					out d3d11DeviceContext);
 
-				if (hr.IsSuccess)
+				if (hr.Succeeded)
 					break;
 			}
 
 			if (d3d11Device is null)
 				return false;
 			IDXGIDevice dxgiDevice = (IDXGIDevice)d3d11Device;
-			if (Functions.DCompositionCreateDevice(dxgiDevice, typeof(IDCompositionDevice).GUID, out var compDevicePtr).IsError)
+			if (PInvoke.DCompositionCreateDevice(dxgiDevice, typeof(IDCompositionDevice).GUID, out var compDevicePtr).Failed)
 				return false;
-			IDCompositionDevice compDevice = (IDCompositionDevice)Marshal.GetObjectForIUnknown(compDevicePtr);
+			IDCompositionDevice compDevice = (IDCompositionDevice)compDevicePtr;
 
-			if (compDevice.CreateVisual(out var childVisual).IsError ||
-				compDevice.CreateSurfaceFromHwnd(hwnd.DangerousGetHandle(), out var controlSurface).IsError ||
-				childVisual.SetContent(controlSurface).IsError)
+			compDevice.CreateVisual(out var childVisual);
+			compDevice.CreateSurfaceFromHwnd(new(hwnd.DangerousGetHandle()), out var controlSurface);
+			childVisual.SetContent(controlSurface);
+			if (childVisual is null || controlSurface is null)
 				return false;
 
 			var compositor = ElementCompositionPreview.GetElementVisual(presenter).Compositor;
@@ -169,7 +173,7 @@ private bool ChildWindowToXaml(IntPtr parent, UIElement presenter)
 			Marshal.ReleaseComObject(childVisual);
 			Marshal.ReleaseComObject(controlSurface);
 			Marshal.ReleaseComObject(compDevice);
-			Marshal.Release(compDevicePtr);
+			Marshal.ReleaseComObject(compDevicePtr);
 			Marshal.ReleaseComObject(dxgiDevice);
 			Marshal.ReleaseComObject(d3d11Device);
 			Marshal.ReleaseComObject(d3d11DeviceContext);