Fixed an issue where the devices FullPath would show instead of FullName on hover (#3215)

Author: d2dyno1

Files/App.xaml.cs

@@ -504,9 +504,23 @@ public static async void CloseApp()
     public class WSLDistroItem : INavigationControlItem
     {
         public string Glyph { get; set; } = null;
+
         public string Text { get; set; }
-        public string Path { get; set; }
+
+        private string path;
+        public string Path
+        {
+            get => path;
+            set
+            {
+                path = value;
+                HoverDisplayText = Path.Contains("?") ? Text : Path;
+            }
+        }
+        public string HoverDisplayText { get; private set; }
+
         public NavigationControlItemType ItemType => NavigationControlItemType.LinuxDistro;
+
         public Uri Logo { get; set; }
     }
 }

Files/Filesystem/DriveItem.cs

@@ -15,7 +15,19 @@ namespace Files.Filesystem
     public class DriveItem : ObservableObject, INavigationControlItem
     {
         public string Glyph { get; set; }
-        public string Path { get; set; }
+
+        private string path;
+        public string Path
+        {
+            get => path;
+            set
+            {
+                path = value;
+                HoverDisplayText = Path.Contains("?") ? Text : Path;
+            }
+        }
+
+        public string HoverDisplayText { get; private set; }
         public string DeviceID { get; set; }
         public StorageFolder Root { get; set; }
         public NavigationControlItemType ItemType { get; set; } = NavigationControlItemType.Drive;

Files/Filesystem/INavigationControlItem.cs

@@ -3,8 +3,13 @@
     public interface INavigationControlItem
     {
         public string Glyph { get; }
+
         public string Text { get; }
+
         public string Path { get; }
+
+        public string HoverDisplayText { get; }
+
         public NavigationControlItemType ItemType { get; }
     }
 

Files/Filesystem/LocationItem.cs

@@ -6,7 +6,19 @@ public class LocationItem : INavigationControlItem
     {
         public string Glyph { get; set; }
         public string Text { get; set; }
-        public string Path { get; set; }
+
+        private string path;
+        public string Path
+        {
+            get => path;
+            set
+            {
+                path = value;
+                HoverDisplayText = Path.Contains("?") ? Text : Path;
+            }
+        }
+
+        public string HoverDisplayText { get; private set; }
         public FontFamily Font { get; set; } = new FontFamily("Segoe MDL2 Assets");
         public NavigationControlItemType ItemType => NavigationControlItemType.Location;
         public bool IsDefaultLocation { get; set; }
@@ -15,8 +27,22 @@ public class LocationItem : INavigationControlItem
     public class HeaderTextItem : INavigationControlItem
     {
         public string Glyph { get; set; } = null;
+
         public string Text { get; set; }
-        public string Path { get; set; } = null;
+
+        private string path;
+        public string Path
+        {
+            get => path;
+            set
+            {
+                path = value;
+                HoverDisplayText = Path.Contains("?") ? Text : Path;
+            }
+        }
+
+        public string HoverDisplayText { get; private set; }
+
         public NavigationControlItemType ItemType => NavigationControlItemType.Header;
     }
 }

Files/UserControls/SidebarControl.xaml

@@ -56,7 +56,7 @@
                     IsRightTapEnabled="True"
                     RightTapped="NavigationViewLocationItem_RightTapped"
                     Tag="{x:Bind Path}"
-                    ToolTipService.ToolTip="{x:Bind Path}">
+                    ToolTipService.ToolTip="{x:Bind HoverDisplayText}">
                     <muxc:NavigationViewItem.Icon>
                         <FontIcon
                             FontFamily="{x:Bind Font}"
@@ -80,7 +80,7 @@
                     IsRightTapEnabled="True"
                     RightTapped="NavigationViewDriveItem_RightTapped"
                     Tag="{x:Bind Path}"
-                    ToolTipService.ToolTip="{x:Bind Path, Mode=OneWay}"
+                    ToolTipService.ToolTip="{x:Bind HoverDisplayText, Mode=OneWay}"
                     Visibility="{x:Bind ItemVisibility}">
                     <muxc:NavigationViewItem.Icon>
                         <FontIcon
@@ -100,7 +100,7 @@
                     DragEnter="NavigationViewItem_DragEnter"
                     DragLeave="NavigationViewItem_DragLeave"
                     Tag="{x:Bind Path}"
-                    ToolTipService.ToolTip="{x:Bind Path, Mode=OneWay}">
+                    ToolTipService.ToolTip="{x:Bind HoverDisplayText, Mode=OneWay}">
                     <muxc:NavigationViewItem.Icon>
                         <BitmapIcon
                             Width="30"