Skip to content

Commit 34eb9ef

Browse files
committed
Fix RightTapped Selection Bug
1 parent 9e07dc8 commit 34eb9ef

File tree

3 files changed

+22
-26
lines changed

3 files changed

+22
-26
lines changed

Files UWP/FilesUWP.csproj

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -17,14 +17,14 @@
1717
<FileAlignment>512</FileAlignment>
1818
<ProjectTypeGuids>{A5A43C5B-DE2A-4C0C-9213-0A381AF9435A};{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}</ProjectTypeGuids>
1919
<WindowsXamlEnableOverview>true</WindowsXamlEnableOverview>
20-
<PackageCertificateKeyFile>Files_TemporaryKey.pfx</PackageCertificateKeyFile>
20+
<PackageCertificateKeyFile>FilesUwp.Package_TemporaryKey.pfx</PackageCertificateKeyFile>
2121
<GenerateAppInstallerFile>False</GenerateAppInstallerFile>
2222
<AppxAutoIncrementPackageRevision>False</AppxAutoIncrementPackageRevision>
2323
<AppxBundlePlatforms>x86|x64|arm</AppxBundlePlatforms>
2424
<AppInstallerUpdateFrequency>1</AppInstallerUpdateFrequency>
2525
<AppInstallerCheckForUpdateFrequency>OnApplicationRun</AppInstallerCheckForUpdateFrequency>
2626
<AppxPackageDir>C:\Users\Luke\Documents\Packages\</AppxPackageDir>
27-
<PackageCertificateThumbprint>28AE037A1F13461E0372E31085451A86570D5A1B</PackageCertificateThumbprint>
27+
<PackageCertificateThumbprint>EDB926CA7770B2992722830C048F36DD5077691C</PackageCertificateThumbprint>
2828
<AppxBundle>Never</AppxBundle>
2929
</PropertyGroup>
3030
<PropertyGroup Condition="'$(Configuration)|$(Platform)' == 'Debug|x86'">
@@ -154,11 +154,6 @@
154154
<DependentUpon>YourHome.xaml</DependentUpon>
155155
</Compile>
156156
</ItemGroup>
157-
<ItemGroup>
158-
<AppxManifest Include="Package.appxmanifest">
159-
<SubType>Designer</SubType>
160-
</AppxManifest>
161-
</ItemGroup>
162157
<ItemGroup>
163158
<Content Include="Assets\abstract_HeroImage.jpg" />
164159
<Content Include="Assets\Cards\Gradients\Blue.png" />
@@ -251,14 +246,19 @@
251246
<Version>2.1.190405004.1</Version>
252247
</PackageReference>
253248
</ItemGroup>
254-
<ItemGroup>
255-
<None Include="Files_TemporaryKey.pfx" />
256-
</ItemGroup>
257249
<ItemGroup>
258250
<SDKReference Include="WindowsDesktop, Version=10.0.18362.0">
259251
<Name>Windows Desktop Extensions for the UWP</Name>
260252
</SDKReference>
261253
</ItemGroup>
254+
<ItemGroup>
255+
<AppxManifest Include="Package.appxmanifest">
256+
<SubType>Designer</SubType>
257+
</AppxManifest>
258+
</ItemGroup>
259+
<ItemGroup>
260+
<None Include="FilesUwp.Package_TemporaryKey.pfx" />
261+
</ItemGroup>
262262
<PropertyGroup Condition=" '$(VisualStudioVersion)' == '' or '$(VisualStudioVersion)' &lt; '14.0' ">
263263
<VisualStudioVersion>14.0</VisualStudioVersion>
264264
</PropertyGroup>

Files UWP/Interacts/Interaction.cs

Lines changed: 10 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -325,19 +325,18 @@ public static void AllView_RightTapped(object sender, RightTappedRoutedEventArgs
325325
{
326326
dataGrid = (DataGrid)sender;
327327
var RowPressed = FindParent<DataGridRow>(e.OriginalSource as DependencyObject);
328-
// If user clicks on header
329-
if (RowPressed == null)
328+
var ObjectPressed = ((ReadOnlyObservableCollection<ListedItem>)dataGrid.ItemsSource)[RowPressed.GetIndex()];
329+
// Check if RightTapped row is currently selected
330+
foreach (ListedItem listedItem in GenericFileBrowser.data.SelectedItems)
330331
{
331-
GenericFileBrowser.HeaderContextMenu.ShowAt(dataGrid, e.GetPosition(dataGrid));
332-
}
333-
// If user clicks on actual row
334-
else
335-
{
336-
var ObjectPressed = ((ReadOnlyObservableCollection<ListedItem>)dataGrid.ItemsSource)[RowPressed.GetIndex()];
337-
dataGrid.SelectedItems.Add(ObjectPressed);
338-
GenericFileBrowser.context.ShowAt(dataGrid, e.GetPosition(dataGrid));
332+
if (RowPressed.GetIndex() == listedItem.RowIndex)
333+
{
334+
return;
335+
}
339336
}
340-
337+
// The following code is only reachable when a user RightTapped an unselected row
338+
dataGrid.SelectedItems.Clear();
339+
dataGrid.SelectedItems.Add(ObjectPressed);
341340
}
342341

343342
public static void FindChildren<T>(List<T> results, DependencyObject startNode) where T : DependencyObject

FilesUwp.Package/FilesUwp.Package.wapproj

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@
4040
<DefaultLanguage>en-US</DefaultLanguage>
4141
<PackageCertificateKeyFile>FilesUwp.Package_TemporaryKey.pfx</PackageCertificateKeyFile>
4242
<EntryPointProjectUniqueName>..\Files UWP\FilesUWP.csproj</EntryPointProjectUniqueName>
43-
<PackageCertificateThumbprint>D90FDFED5D096AAD472FE13BA80DBFD16C25914E</PackageCertificateThumbprint>
43+
<PackageCertificateThumbprint>EDB926CA7770B2992722830C048F36DD5077691C</PackageCertificateThumbprint>
4444
<GenerateAppInstallerFile>False</GenerateAppInstallerFile>
4545
<AppxAutoIncrementPackageRevision>False</AppxAutoIncrementPackageRevision>
4646
<AppInstallerUpdateFrequency>1</AppInstallerUpdateFrequency>
@@ -69,10 +69,6 @@
6969
<AppxManifest Include="Package.appxmanifest">
7070
<SubType>Designer</SubType>
7171
</AppxManifest>
72-
<None Include="FilesUwp.Package_TemporaryKey.pfx" />
73-
</ItemGroup>
74-
<ItemGroup>
75-
<None Include="Files_TemporaryKey.pfx" />
7672
</ItemGroup>
7773
<ItemGroup>
7874
<ProjectReference Include="..\ExecutableLauncher\ExecutableLauncher.csproj">
@@ -134,6 +130,7 @@
134130
<Content Include="Assets\Wide310x150Logo.scale-150.png" />
135131
<Content Include="Assets\Wide310x150Logo.scale-200.png" />
136132
<Content Include="Assets\Wide310x150Logo.scale-400.png" />
133+
<None Include="FilesUwp.Package_TemporaryKey.pfx" />
137134
</ItemGroup>
138135
<Import Project="$(WapProjPath)\Microsoft.DesktopBridge.targets" />
139136
</Project>

0 commit comments

Comments
 (0)