Code Quality: Sorting and removing useless usings. (#11010)

QuaintMako · web-flow · commit 3e26ad1ec9b0 · 2023-01-14T18:50:15.000-05:00
Sorting and cleaning usings
diff --git a/src/Files.App/DataModels/NavigationControlItems/DriveItem.cs b/src/Files.App/DataModels/NavigationControlItems/DriveItem.cs
@@ -9,10 +9,8 @@
 using Microsoft.UI.Xaml.Media.Imaging;
 using System;
 using System.Threading.Tasks;
-using Windows.Media.Capture;
 using Windows.Storage;
 using Windows.Storage.Streams;
-using static Vanara.PInvoke.Shell32;
 
 namespace Files.App.DataModels.NavigationControlItems
 {
diff --git a/src/Files.App/DataModels/NavigationControlItems/LocationItem.cs b/src/Files.App/DataModels/NavigationControlItems/LocationItem.cs
@@ -9,7 +9,6 @@
 using Microsoft.UI.Xaml.Media.Imaging;
 using System;
 using System.IO;
-using System.Threading.Tasks;
 
 namespace Files.App.DataModels.NavigationControlItems
 {
diff --git a/src/Files.App/Filesystem/ListedItem.cs b/src/Files.App/Filesystem/ListedItem.cs
@@ -15,7 +15,6 @@
 using System.Collections.Generic;
 using System.Collections.ObjectModel;
 using System.IO;
-using System.Linq;
 using System.Threading;
 using System.Threading.Tasks;
 using Windows.Storage;
diff --git a/src/Files.App/Filesystem/StorageEnumerators/Win32StorageEnumerator.cs b/src/Files.App/Filesystem/StorageEnumerators/Win32StorageEnumerator.cs
@@ -3,19 +3,16 @@
 using Files.App.Filesystem.StorageItems;
 using Files.App.Helpers;
 using Files.App.Helpers.FileListCache;
-using Files.App.Shell;
 using Files.Backend.Extensions;
 using Files.Backend.Services.Settings;
 using Files.Backend.Services.SizeProvider;
-using Files.Shared;
 using Microsoft.UI.Xaml.Media.Imaging;
 using System;
 using System.Collections.Generic;
 using System.IO;
 using System.Threading;
 using System.Threading.Tasks;
 using Vanara.PInvoke;
-using Vanara.Windows.Shell;
 using Windows.Storage;
 using static Files.Backend.Helpers.NativeFindStorageItemHelper;
 using FileAttributes = System.IO.FileAttributes;
diff --git a/src/Files.App/Filesystem/StorageItems/ShellStorageFile.cs b/src/Files.App/Filesystem/StorageItems/ShellStorageFile.cs
@@ -1,6 +1,5 @@
 using Files.App.Shell;
 using Files.Shared;
-using Files.Shared.Extensions;
 using System;
 using System.Runtime.InteropServices.WindowsRuntime;
 using System.Threading.Tasks;
diff --git a/src/Files.App/Helpers/AppThemeResourcesHelper.cs b/src/Files.App/Helpers/AppThemeResourcesHelper.cs
@@ -1,5 +1,4 @@
 using Microsoft.UI.Xaml;
-using Microsoft.UI.Xaml.Media;
 using Windows.UI;
 
 namespace Files.App.Helpers
diff --git a/src/Files.App/Helpers/FileOperationsHelpers.cs b/src/Files.App/Helpers/FileOperationsHelpers.cs
@@ -1,4 +1,3 @@
-using Files.App.DataModels;
 using Files.App.Filesystem;
 using Files.App.Filesystem.Permissions;
 using Files.App.Shell;
@@ -17,7 +16,6 @@
 using System.Security.Principal;
 using System.Threading;
 using System.Threading.Tasks;
-using System.Windows.Forms;
 using Tulpep.ActiveDirectoryObjectPicker;
 using Vanara.PInvoke;
 using Vanara.Windows.Shell;
diff --git a/src/Files.App/Helpers/NativeFileOperationsHelper.cs b/src/Files.App/Helpers/NativeFileOperationsHelper.cs
@@ -1,4 +1,3 @@
-using Files.Shared.Extensions;
 using Microsoft.Win32.SafeHandles;
 using System;
 using System.Collections.Generic;
diff --git a/src/Files.App/Helpers/RecycleBinHelpers.cs b/src/Files.App/Helpers/RecycleBinHelpers.cs
@@ -1,4 +1,3 @@
-using Files.App.DataModels.NavigationControlItems;
 using Files.App.Extensions;
 using Files.App.Filesystem;
 using Files.App.Shell;
diff --git a/src/Files.App/ServicesImplementation/Settings/AppearanceSettingsService.cs b/src/Files.App/ServicesImplementation/Settings/AppearanceSettingsService.cs
@@ -2,7 +2,6 @@
 using Files.Backend.Services.Settings;
 using Files.Shared.EventArguments;
 using Microsoft.AppCenter.Analytics;
-using Microsoft.UI.Xaml.Media;
 using System;
 
 namespace Files.App.ServicesImplementation.Settings
diff --git a/src/Files.App/ServicesImplementation/Settings/PreviewPaneSettingsService.cs b/src/Files.App/ServicesImplementation/Settings/PreviewPaneSettingsService.cs
@@ -1,6 +1,5 @@
 using Files.App.Serialization;
 using Files.Backend.Services.Settings;
-using Files.Shared.Enums;
 using Files.Shared.EventArguments;
 using Microsoft.AppCenter.Analytics;
 using System;
diff --git a/src/Files.App/Shell/Win32API.cs b/src/Files.App/Shell/Win32API.cs
@@ -13,7 +13,6 @@
 using System.Runtime.InteropServices;
 using System.Runtime.Versioning;
 using System.Text;
-using System.Text.RegularExpressions;
 using System.Threading;
 using System.Threading.Tasks;
 using System.Windows.Forms;
diff --git a/src/Files.App/Shell/Win32Shell.cs b/src/Files.App/Shell/Win32Shell.cs
@@ -1,5 +1,4 @@
-﻿using Files.App.Helpers;
-using Files.Shared;
+﻿using Files.Shared;
 using System;
 using System.Collections.Generic;
 using System.IO;
diff --git a/src/Files.App/UserControls/FilePreviews/HtmlPreview.xaml.cs b/src/Files.App/UserControls/FilePreviews/HtmlPreview.xaml.cs
@@ -1,6 +1,6 @@
-using System;
 using Files.App.ViewModels.Previews;
 using Microsoft.UI.Xaml.Controls;
+using System;
 
 // The User Control item template is documented at https://go.microsoft.com/fwlink/?LinkId=234236
 
diff --git a/src/Files.App/UserControls/StatusBarControl.xaml.cs b/src/Files.App/UserControls/StatusBarControl.xaml.cs
@@ -1,4 +1,3 @@
-using Files.App.DataModels;
 using Files.App.ViewModels;
 using Microsoft.UI.Xaml;
 using Microsoft.UI.Xaml.Controls;
diff --git a/src/Files.App/UserControls/Widgets/RecentFilesWidget.xaml.cs b/src/Files.App/UserControls/Widgets/RecentFilesWidget.xaml.cs
@@ -7,7 +7,6 @@
 using Microsoft.UI.Xaml;
 using Microsoft.UI.Xaml.Controls;
 using System;
-using System.Collections.Generic;
 using System.Collections.ObjectModel;
 using System.Collections.Specialized;
 using System.ComponentModel;
diff --git a/src/Files.App/ViewModels/MainPageViewModel.cs b/src/Files.App/ViewModels/MainPageViewModel.cs
@@ -1,6 +1,5 @@
 using CommunityToolkit.Mvvm.ComponentModel;
 using CommunityToolkit.Mvvm.DependencyInjection;
-using CommunityToolkit.WinUI.Helpers;
 using CommunityToolkit.Mvvm.Input;
 using Files.App.Extensions;
 using Files.App.Filesystem;
diff --git a/src/Files.App/ViewModels/SettingsViewModel.cs b/src/Files.App/ViewModels/SettingsViewModel.cs
@@ -1,12 +1,9 @@
 using CommunityToolkit.Mvvm.ComponentModel;
 using CommunityToolkit.Mvvm.Input;
-using Files.App.Extensions;
-using Files.App.Helpers;
 using System;
 using System.Diagnostics.CodeAnalysis;
 using System.Reflection;
 using System.Runtime.CompilerServices;
-using System.Text.Json;
 using System.Windows.Input;
 using Windows.Storage;
 
diff --git a/src/Files.App/ViewModels/SettingsViewModels/AboutViewModel.cs b/src/Files.App/ViewModels/SettingsViewModels/AboutViewModel.cs
@@ -5,14 +5,12 @@
 using Files.App.Extensions;
 using Files.Backend.Services.Settings;
 using Files.Shared.Extensions;
-using Microsoft.UI.Xaml.Controls;
 using System;
 using System.Threading.Tasks;
 using System.Windows.Input;
 using Windows.ApplicationModel;
 using Windows.ApplicationModel.DataTransfer;
 using Windows.Storage;
-using Windows.Storage.Pickers;
 using Windows.System;
 
 namespace Files.App.ViewModels.SettingsViewModels
diff --git a/src/Files.App/ViewModels/SettingsViewModels/AdvancedViewModel.cs b/src/Files.App/ViewModels/SettingsViewModels/AdvancedViewModel.cs
@@ -5,7 +5,6 @@
 using Files.App.Filesystem;
 using Files.App.Filesystem.StorageItems;
 using Files.App.Helpers;
-using Files.App.ServicesImplementation.Settings;
 using Files.App.Shell;
 using Files.Backend.Services.Settings;
 using Files.Shared.Extensions;
diff --git a/src/Files.App/ViewModels/SettingsViewModels/AppearanceViewModel.cs b/src/Files.App/ViewModels/SettingsViewModels/AppearanceViewModel.cs
@@ -1,6 +1,5 @@
 using CommunityToolkit.Mvvm.ComponentModel;
 using CommunityToolkit.Mvvm.DependencyInjection;
-using CommunityToolkit.Mvvm.Input;
 using CommunityToolkit.WinUI.Helpers;
 using Files.App.Extensions;
 using Files.App.Helpers;
@@ -12,7 +11,6 @@
 using System.Collections.Generic;
 using System.Collections.ObjectModel;
 using System.Linq;
-using System.Windows.Input;
 using Windows.UI;
 
 namespace Files.App.ViewModels.SettingsViewModels
diff --git a/src/Files.App/ViewModels/StatusCenterViewModel.cs b/src/Files.App/ViewModels/StatusCenterViewModel.cs
@@ -11,7 +11,6 @@
 using Microsoft.UI.Xaml.Media;
 using System;
 using System.Collections.ObjectModel;
-using System.Diagnostics;
 using System.Linq;
 using System.Threading;
 using System.Windows.Input;
diff --git a/src/Files.App/ViewModels/ToolbarViewModel.cs b/src/Files.App/ViewModels/ToolbarViewModel.cs
@@ -7,7 +7,6 @@
 using Files.App.Filesystem;
 using Files.App.Filesystem.StorageItems;
 using Files.App.Helpers;
-using Files.App.ServicesImplementation;
 using Files.App.Shell;
 using Files.App.UserControls;
 using Files.App.Views;
@@ -27,10 +26,8 @@
 using System.ComponentModel;
 using System.IO;
 using System.Linq;
-using System.Net.Http;
 using System.Threading.Tasks;
 using System.Windows.Input;
-using Vanara.PInvoke;
 using Windows.ApplicationModel.DataTransfer;
 using Windows.Storage;
 using Windows.UI.Text;
diff --git a/src/Files.App/Views/MainPage.xaml.cs b/src/Files.App/Views/MainPage.xaml.cs
@@ -12,9 +12,7 @@
 using Files.App.ViewModels;
 using Files.Backend.Extensions;
 using Files.Backend.Services.Settings;
-using Files.Shared.Enums;
 using Files.Shared.EventArguments;
-using Microsoft.UI;
 using Microsoft.UI.Windowing;
 using Microsoft.UI.Xaml;
 using Microsoft.UI.Xaml.Controls;
diff --git a/src/Files.App/Views/Pages/Properties.xaml.cs b/src/Files.App/Views/Pages/Properties.xaml.cs
@@ -10,7 +10,6 @@
 using Microsoft.UI.Xaml;
 using Microsoft.UI.Xaml.Controls;
 using Microsoft.UI.Xaml.Input;
-using Microsoft.UI.Xaml.Markup;
 using Microsoft.UI.Xaml.Navigation;
 using System;
 using System.Linq;
diff --git a/src/Files.App/Views/Pages/PropertiesCustomization.xaml.cs b/src/Files.App/Views/Pages/PropertiesCustomization.xaml.cs
@@ -1,4 +1,3 @@
-using Files.App.Filesystem;
 using Files.App.Helpers;
 using Files.App.ViewModels.Properties;
 using Microsoft.UI.Xaml;
diff --git a/src/Files.App/Views/Pages/PropertiesDetails.xaml.cs b/src/Files.App/Views/Pages/PropertiesDetails.xaml.cs
@@ -1,5 +1,4 @@
 using Files.App.Dialogs;
-using Files.App.Filesystem;
 using Files.App.Helpers;
 using Files.App.ViewModels.Properties;
 using Files.Shared.Enums;
diff --git a/src/Files.App/Views/Pages/PropertiesSecurityAdvanced.xaml.cs b/src/Files.App/Views/Pages/PropertiesSecurityAdvanced.xaml.cs
@@ -10,7 +10,6 @@
 using Microsoft.UI.Xaml;
 using Microsoft.UI.Xaml.Controls;
 using Microsoft.UI.Xaml.Input;
-using Microsoft.UI.Xaml.Markup;
 using Microsoft.UI.Xaml.Navigation;
 using Microsoft.Windows.ApplicationModel.Resources;
 using System;
diff --git a/src/Files.App/Views/Pages/PropertiesShortcut.xaml.cs b/src/Files.App/Views/Pages/PropertiesShortcut.xaml.cs
@@ -1,4 +1,3 @@
-using Files.App.Filesystem;
 using Files.App.ViewModels.Properties;
 using System.Threading.Tasks;
 
diff --git a/src/Files.App/Views/SettingsPages/Appearance.xaml.cs b/src/Files.App/Views/SettingsPages/Appearance.xaml.cs
@@ -1,8 +1,3 @@
-using CommunityToolkit.WinUI.UI;
-using Files.App.Dialogs;
-using Files.App.Helpers.XamlHelpers;
-using Files.App.UserControls.Settings;
-using Microsoft.UI.Xaml;
 using Microsoft.UI.Xaml.Controls;
 
 namespace Files.App.SettingsPages
diff --git a/src/Files.App/Views/SettingsPages/Appearance/AppThemeResource.cs b/src/Files.App/Views/SettingsPages/Appearance/AppThemeResource.cs
@@ -1,9 +1,4 @@
 ﻿using Microsoft.UI.Xaml.Media;
-using System;
-using System.Collections.Generic;
-using System.Linq;
-using System.Text;
-using System.Threading.Tasks;
 using Windows.UI;
 
 namespace Files.App.Views.SettingsPages.Appearance
diff --git a/src/Files.App/Views/SettingsPages/Appearance/AppThemeResourcesFactory.cs b/src/Files.App/Views/SettingsPages/Appearance/AppThemeResourcesFactory.cs
@@ -1,5 +1,4 @@
-﻿using Files.App.Views.SettingsPages.Appearance;
-using Microsoft.UI.Xaml.Media;
+﻿using Microsoft.UI.Xaml.Media;
 using System.Collections.ObjectModel;
 using Windows.UI;
 
diff --git a/src/Files.App/Views/WidgetsPage.xaml.cs b/src/Files.App/Views/WidgetsPage.xaml.cs
@@ -1,5 +1,4 @@
 using CommunityToolkit.Mvvm.DependencyInjection;
-using Files.App.DataModels.NavigationControlItems;
 using Files.App.Dialogs;
 using Files.App.Extensions;
 using Files.App.Filesystem;
diff --git a/src/Files.Backend/Services/IUpdateService.cs b/src/Files.Backend/Services/IUpdateService.cs
@@ -1,6 +1,4 @@
-﻿using System;
-using System.Collections.Generic;
-using System.ComponentModel;
+﻿using System.ComponentModel;
 using System.Threading;
 using System.Threading.Tasks;
 
diff --git a/src/Files.Backend/Services/Settings/IPreviewPaneSettingsService.cs b/src/Files.Backend/Services/Settings/IPreviewPaneSettingsService.cs
@@ -1,5 +1,4 @@
-﻿using Files.Shared.Enums;
-using System.ComponentModel;
+﻿using System.ComponentModel;
 
 namespace Files.Backend.Services.Settings
 {
diff --git a/src/Files.Shared/Logger.cs b/src/Files.Shared/Logger.cs
@@ -2,7 +2,6 @@
 using System.Diagnostics;
 using System.Runtime.CompilerServices;
 using System.Threading;
-using System.Threading.Tasks;
 
 namespace Files.Shared
 {
diff --git a/tests/Files.InteractionTests/Tests/FolderTests.cs b/tests/Files.InteractionTests/Tests/FolderTests.cs
@@ -1,8 +1,6 @@
 ﻿using OpenQA.Selenium;
 using OpenQA.Selenium.Interactions;
-using System;
 using System.Threading;
-using static System.Collections.Specialized.BitVector32;
 
 namespace Files.InteractionTests.Tests
 {

Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,6 @@`
`9`	`9`	`using Microsoft.UI.Xaml.Media.Imaging;`
`10`	`10`	`using System;`
`11`	`11`	`using System.IO;`
`12`		`-using System.Threading.Tasks;`
`13`	`12`
`14`	`13`	`namespace Files.App.DataModels.NavigationControlItems`
`15`	`14`	`{`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,4 @@`
`1`	`1`	`using Microsoft.UI.Xaml;`
`2`		`-using Microsoft.UI.Xaml.Media;`
`3`	`2`	`using Windows.UI;`
`4`	`3`
`5`	`4`	`namespace Files.App.Helpers`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,3 @@`
`1`		`-using Files.Shared.Extensions;`
`2`	`1`	`using Microsoft.Win32.SafeHandles;`
`3`	`2`	`using System;`
`4`	`3`	`using System.Collections.Generic;`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,3 @@`
`1`		`-using Files.App.DataModels.NavigationControlItems;`
`2`	`1`	`using Files.App.Extensions;`
`3`	`2`	`using Files.App.Filesystem;`
`4`	`3`	`using Files.App.Shell;`