Improved the focus management from outside

Author: 0x5bfa

src/Files.App.Controls/Omnibar/Omnibar.Events.cs

@@ -17,11 +17,6 @@ private void Omnibar_SizeChanged(object sender, SizeChangedEventArgs e)
 		private void AutoSuggestBox_GotFocus(object sender, RoutedEventArgs e)
 		{
 			IsFocused = true;
-
-			VisualStateManager.GoToState(CurrentSelectedMode, "Focused", true);
-			VisualStateManager.GoToState(_textBox, "InputAreaVisible", true);
-
-			TryToggleIsSuggestionsPopupOpen(true);
 		}
 
 		private void AutoSuggestBox_LostFocus(object sender, RoutedEventArgs e)
@@ -31,14 +26,6 @@ private void AutoSuggestBox_LostFocus(object sender, RoutedEventArgs e)
 				return;
 
 			IsFocused = false;
-
-			if (CurrentSelectedMode?.ContentOnInactive is not null)
-			{
-				VisualStateManager.GoToState(CurrentSelectedMode, "CurrentUnfocused", true);
-				VisualStateManager.GoToState(_textBox, "InputAreaCollapsed", true);
-			}
-
-			TryToggleIsSuggestionsPopupOpen(false);
 		}
 
 		private void AutoSuggestBox_KeyDown(object sender, KeyRoutedEventArgs e)

src/Files.App.Controls/Omnibar/Omnibar.Properties.cs

@@ -26,5 +26,27 @@ partial void OnCurrentSelectedModePropertyChanged(DependencyPropertyChangedEvent
 
 			ChangeMode(e.OldValue as OmnibarMode, newMode);
 		}
+
+		partial void OnIsFocusedChanged(bool newValue)
+		{
+			if (CurrentSelectedMode is null)
+				return;
+
+			if (newValue)
+			{
+				VisualStateManager.GoToState(CurrentSelectedMode, "Focused", true);
+				VisualStateManager.GoToState(_textBox, "InputAreaVisible", true);
+			}
+			else
+			{
+				if (CurrentSelectedMode?.ContentOnInactive is not null)
+				{
+					VisualStateManager.GoToState(CurrentSelectedMode, "CurrentUnfocused", true);
+					VisualStateManager.GoToState(_textBox, "InputAreaCollapsed", true);
+				}
+			}
+
+			TryToggleIsSuggestionsPopupOpen(newValue);
+		}
 	}
 }

src/Files.App.Controls/Omnibar/Omnibar.cs

@@ -182,7 +182,8 @@ internal protected void FocusTextBox()
 
 		public bool TryToggleIsSuggestionsPopupOpen(bool wantToOpen)
 		{
-			if (wantToOpen && (!IsFocused || CurrentSelectedMode?.SuggestionItemsSource is null || (CurrentSelectedMode?.SuggestionItemsSource is IList collection && collection.Count is 0)))
+			if (wantToOpen && (!IsFocused || CurrentSelectedMode?.SuggestionItemsSource is null || (CurrentSelectedMode?.SuggestionItemsSource is IList collection && collection.Count is 0)) ||
+				_textBoxSuggestionsPopup is null)
 				return false;
 
 			_textBoxSuggestionsPopup.IsOpen = wantToOpen;