Skip to content

Commit 430a521

Browse files
committed
Fixed "Mode icons aren't updating when switching themes"
1 parent 74c62a1 commit 430a521

File tree

1 file changed

+21
-8
lines changed

1 file changed

+21
-8
lines changed

src/Files.App.Controls/Omnibar/Omnibar.xaml

Lines changed: 21 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -145,11 +145,21 @@
145145
<BrushTransition Duration="0:0:0.083" />
146146
</Border.BackgroundTransition>
147147

148-
<ContentPresenter
149-
x:Name="PART_ModeButtonIconPresenter"
150-
HorizontalAlignment="Center"
151-
VerticalAlignment="Center"
152-
Content="{Binding IconOnInactive, RelativeSource={RelativeSource TemplatedParent}, Mode=OneWay}" />
148+
<Grid>
149+
<ContentPresenter
150+
x:Name="PART_ModeButtonInactiveIconPresenter"
151+
HorizontalAlignment="Center"
152+
VerticalAlignment="Center"
153+
Content="{Binding IconOnInactive, RelativeSource={RelativeSource TemplatedParent}, Mode=OneWay}"
154+
Visibility="Visible" />
155+
156+
<ContentPresenter
157+
x:Name="PART_ModeButtonActiveIconPresenter"
158+
HorizontalAlignment="Center"
159+
VerticalAlignment="Center"
160+
Content="{Binding IconOnActive, RelativeSource={RelativeSource TemplatedParent}, Mode=OneWay}"
161+
Visibility="Collapsed" />
162+
</Grid>
153163
</Border>
154164

155165
<ContentPresenter
@@ -172,7 +182,8 @@
172182
<VisualState x:Name="PointerPressed">
173183
<VisualState.Setters>
174184
<Setter Target="PART_ModeButton.Background" Value="{ThemeResource SubtleFillColorTertiaryBrush}" />
175-
<Setter Target="PART_ModeButtonIconPresenter.Content" Value="{Binding IconOnActive, RelativeSource={RelativeSource TemplatedParent}, Mode=OneWay}" />
185+
<Setter Target="PART_ModeButtonInactiveIconPresenter.Visibility" Value="Collapsed" />
186+
<Setter Target="PART_ModeButtonActiveIconPresenter.Visibility" Value="Visible" />
176187
</VisualState.Setters>
177188
</VisualState>
178189
</VisualStateGroup>
@@ -181,13 +192,15 @@
181192
<VisualState x:Name="Unfocused" />
182193
<VisualState x:Name="CurrentUnfocused">
183194
<VisualState.Setters>
184-
<Setter Target="PART_ModeButtonIconPresenter.Visibility" Value="Collapsed" />
195+
<Setter Target="PART_ModeButtonInactiveIconPresenter.Visibility" Value="Collapsed" />
196+
<Setter Target="PART_ModeButtonActiveIconPresenter.Visibility" Value="Collapsed" />
185197
<Setter Target="PART_InactiveContent.Visibility" Value="Visible" />
186198
</VisualState.Setters>
187199
</VisualState>
188200
<VisualState x:Name="Focused">
189201
<VisualState.Setters>
190-
<Setter Target="PART_ModeButtonIconPresenter.Content" Value="{Binding IconOnActive, RelativeSource={RelativeSource TemplatedParent}, Mode=OneWay}" />
202+
<Setter Target="PART_ModeButtonInactiveIconPresenter.Visibility" Value="Collapsed" />
203+
<Setter Target="PART_ModeButtonActiveIconPresenter.Visibility" Value="Visible" />
191204
</VisualState.Setters>
192205
</VisualState>
193206
</VisualStateGroup>

0 commit comments

Comments
 (0)