Fix 'When using Edit path mode, switching tabs and then switching back reopens the Omnibar flyout'

Author: yaira2

src/Files.App.Controls/Omnibar/Omnibar.Events.cs

@@ -24,16 +24,6 @@ private void AutoSuggestBox_GettingFocus(UIElement sender, GettingFocusEventArgs
 			_previouslyFocusedElement = new(args.OldFocusedElement as UIElement);
 		}
 
-		private void AutoSuggestBox_LosingFocus(UIElement sender, LosingFocusEventArgs args)
-		{
-			if (IsModeButtonPressed)
-			{
-				IsModeButtonPressed = false;
-				args.TryCancel();
-				return;
-			}
-		}
-
 		private void AutoSuggestBox_GotFocus(object sender, RoutedEventArgs e)
 		{
 			GlobalHelper.WriteDebugStringForOmnibar("The TextBox got the focus.");

src/Files.App.Controls/Omnibar/Omnibar.cs

@@ -33,9 +33,6 @@ public partial class Omnibar : Control
 
 		private WeakReference<UIElement?> _previouslyFocusedElement = new(null);
 
-		// NOTE: This is a workaround to keep Omnibar's focus on a mode button being clicked
-		internal bool IsModeButtonPressed { get; set; }
-
 		// Events
 
 		public event TypedEventHandler<Omnibar, OmnibarQuerySubmittedEventArgs>? QuerySubmitted;
@@ -77,7 +74,6 @@ protected override void OnApplyTemplate()
 			SizeChanged += Omnibar_SizeChanged;
 			_textBox.GettingFocus += AutoSuggestBox_GettingFocus;
 			_textBox.GotFocus += AutoSuggestBox_GotFocus;
-			_textBox.LosingFocus += AutoSuggestBox_LosingFocus;
 			_textBox.LostFocus += AutoSuggestBox_LostFocus;
 			_textBox.KeyDown += AutoSuggestBox_KeyDown;
 			_textBox.TextChanged += AutoSuggestBox_TextChanged;

src/Files.App.Controls/Omnibar/OmnibarMode.Events.cs

@@ -49,7 +49,6 @@ private void ModeButton_Click(object sender, RoutedEventArgs e)
 			if (_ownerRef is null || _ownerRef.TryGetTarget(out var owner) is false || owner.CurrentSelectedMode == this)
 				return;
 
-			owner.IsModeButtonPressed = true;
 			owner.CurrentSelectedMode = this;
 		}
 	}