Fix: Fixed crash when opening folders with invalid git configs (#16141)

Author: yaira2

src/Files.App/Utils/Git/GitHelpers.cs

@@ -3,13 +3,11 @@
 
 using Files.App.Dialogs;
 using LibGit2Sharp;
-using Sentry;
 using Microsoft.Extensions.Logging;
+using Sentry;
 using System.Net.Http;
 using System.Net.Http.Json;
-using System.Net.Sockets;
 using System.Text;
-using System.Text.Json;
 
 namespace Files.App.Utils.Git
 {
@@ -78,7 +76,7 @@ private set
 
 			try
 			{
-				if (Repository.IsValid(path))
+				if (IsRepoValid(path))
 					return path;
 				else
 				{
@@ -99,7 +97,7 @@ private set
 
 		public static string GetOriginRepositoryName(string? path)
 		{
-			if (string.IsNullOrWhiteSpace(path) || !Repository.IsValid(path))
+			if (string.IsNullOrWhiteSpace(path) || !IsRepoValid(path))
 				return string.Empty;
 
 			using var repository = new Repository(path);
@@ -114,7 +112,7 @@ public static string GetOriginRepositoryName(string? path)
 
 		public static async Task<BranchItem[]> GetBranchesNames(string? path)
 		{
-			if (string.IsNullOrWhiteSpace(path) || !Repository.IsValid(path))
+			if (string.IsNullOrWhiteSpace(path) || !IsRepoValid(path))
 				return [];
 
 			var (result, returnValue) = await DoGitOperationAsync<(GitOperationResult, BranchItem[])>(() =>
@@ -146,7 +144,7 @@ public static async Task<BranchItem[]> GetBranchesNames(string? path)
 
 		public static async Task<BranchItem?> GetRepositoryHead(string? path)
 		{
-			if (string.IsNullOrWhiteSpace(path) || !Repository.IsValid(path))
+			if (string.IsNullOrWhiteSpace(path) || !IsRepoValid(path))
 				return null;
 
 			var (_, returnValue) = await DoGitOperationAsync<(GitOperationResult, BranchItem?)>(() =>
@@ -181,7 +179,7 @@ public static async Task<bool> Checkout(string? repositoryPath, string? branch)
 			// Re-enable when Metris feature is available again
 			// SentrySdk.Metrics.Increment("Triggered git checkout");
 
-			if (string.IsNullOrWhiteSpace(repositoryPath) || !Repository.IsValid(repositoryPath))
+			if (string.IsNullOrWhiteSpace(repositoryPath) || !IsRepoValid(repositoryPath))
 				return false;
 
 			using var repository = new Repository(repositoryPath);
@@ -289,7 +287,7 @@ public static async Task DeleteBranchAsync(string? repositoryPath, string? activ
 				string.IsNullOrWhiteSpace(activeBranch) ||
 				string.IsNullOrWhiteSpace(branchToDelete) ||
 				activeBranch.Equals(branchToDelete, StringComparison.OrdinalIgnoreCase) ||
-				!Repository.IsValid(repositoryPath))
+				!IsRepoValid(repositoryPath))
 			{
 				return;
 			}
@@ -322,7 +320,7 @@ await DoGitOperationAsync<GitOperationResult>(() =>
 
 		public static bool ValidateBranchNameForRepository(string branchName, string repositoryPath)
 		{
-			if (string.IsNullOrEmpty(branchName) || !Repository.IsValid(repositoryPath))
+			if (string.IsNullOrEmpty(branchName) || !IsRepoValid(repositoryPath))
 				return false;
 
 			var nameValidator = RegexHelpers.GitBranchName();
@@ -649,7 +647,7 @@ public static bool IsRepositoryEx(string path, out string repoRootPath)
 			if (string.IsNullOrEmpty(repositoryRootPath))
 				return false;
 
-			if (Repository.IsValid(repositoryRootPath))
+			if (!IsRepoValid(repositoryRootPath))
 			{
 				repoRootPath = repositoryRootPath;
 				return true;
@@ -737,6 +735,11 @@ public static async Task InitializeRepositoryAsync(string? path)
 			}
 		}
 
+		private static bool IsRepoValid(string path)
+		{
+			return SafetyExtensions.IgnoreExceptions(() => Repository.IsValid(path));
+		}
+
 		private static IEnumerable<Branch> GetValidBranches(BranchCollection branches)
 		{
 			foreach (var branch in branches)