CQ: Update

Author: XTorLukas

src/Files.App/Data/Contracts/IRealTimeLayoutService.cs

@@ -17,35 +17,44 @@ public interface IRealTimeLayoutService
 		FlowDirection FlowDirection { get; }
 
 		/// <summary>
-		/// Adds a callback to be executed when a specific target requires updates.
+		/// Updates the culture settings for the layout.
 		/// </summary>
-		/// <param name="target">The target object for which the callback is registered.</param>
-		/// <param name="callback">The action to execute during updates.</param>
-		void AddCallback(object target, Action callback);
+		/// <param name="culture">The culture information to apply.</param>
+		void UpdateCulture(CultureInfo culture);
 
 		/// <summary>
-		/// Updates the content layout of the specified framework element.
+		/// Adds a callback for a <see cref="Window"/> implementing <see cref="IRealTimeWindow"/>.
+		/// The callback is automatically removed when the window is closed.
 		/// </summary>
-		/// <param name="frameworkElement">The framework element to update.</param>
-		void UpdateContent(FrameworkElement frameworkElement);
+		/// <param name="target">The <see cref="Window"/> instance that implements <see cref="IRealTimeWindow"/>.</param>
+		/// <param name="callback">The action to be executed when the callback is triggered.</param>
+		void AddCallback(Window target, Action callback);
 
 		/// <summary>
-		/// Updates the content layout of the specified window.
+		/// Adds a callback for a <see cref="FrameworkElement"/> implementing <see cref="IRealTimeControl"/>.
+		/// The callback is automatically removed when the element is unloaded.
 		/// </summary>
-		/// <param name="window">The window whose content layout needs updating.</param>
-		void UpdateContent(Window window);
+		/// <param name="target">The <see cref="FrameworkElement"/> instance that implements <see cref="IRealTimeControl"/>.</param>
+		/// <param name="callback">The action to be executed when the callback is triggered.</param>
+		void AddCallback(FrameworkElement target, Action callback);
 
 		/// <summary>
-		/// Updates the culture settings for the layout.
+		/// Updates the title bar layout of the specified window based on the current flow direction.
 		/// </summary>
-		/// <param name="culture">The culture information to apply.</param>
-		void UpdateCulture(CultureInfo culture);
+		/// <param name="window">The window whose title bar layout needs updating.</param>
+		/// <returns>True if the title bar layout was successfully updated; otherwise, false.</returns>
+		bool UpdateTitleBar(Window window);
 
 		/// <summary>
-		/// Updates the title bar of the specified window.
+		/// Updates the content layout of the specified window to match the current flow direction.
 		/// </summary>
-		/// <param name="window">The window whose title bar needs updating.</param>
-		/// <returns>True if the title bar was successfully updated; otherwise, false.</returns>
-		bool UpdateTitleBar(Window window);
+		/// <param name="window">The window whose content layout needs updating.</param>
+		void UpdateContent(Window window);
+
+		/// <summary>
+		/// Updates the content layout of the specified framework element to match the current flow direction.
+		/// </summary>
+		/// <param name="frameworkElement">The framework element whose content layout needs updating.</param>
+		void UpdateContent(FrameworkElement frameworkElement);
 	}
 }

src/Files.App/Services/Content/RealTimeLayoutService.cs

@@ -21,15 +21,10 @@ internal sealed class RealTimeLayoutService : IRealTimeLayoutService
 		/// </summary>
 		private readonly List<(WeakReference<object> Reference, Action Callback)> _callbacks = [];
 
-		/// <summary>
-		/// Gets the current flow direction based on the current UI culture (RightToLeft or LeftToRight).
-		/// </summary>
+		/// <inheritdoc/>
 		public FlowDirection FlowDirection => CultureInfo.CurrentUICulture.TextInfo.IsRightToLeft ? FlowDirection.RightToLeft : FlowDirection.LeftToRight;
 
-		/// <summary>
-		/// Updates the culture for the layout service and invokes the necessary callbacks if the flow direction changes.
-		/// </summary>
-		/// <param name="culture">The new culture information to apply.</param>
+		/// /// <inheritdoc/>
 		public void UpdateCulture(CultureInfo culture)
 		{
 			FlowDirection tmp = FlowDirection;
@@ -41,28 +36,23 @@ public void UpdateCulture(CultureInfo culture)
 				InvokeCallbacks();
 		}
 
-		/// <summary>
-		/// Registers a callback to be invoked when the layout needs to be updated for the specified target.
-		/// </summary>
-		/// <param name="target">The target object to associate with the callback.</param>
-		/// <param name="callback">The callback to invoke when the layout is updated.</param>
-		public void AddCallback(object target, Action callback)
+		/// <inheritdoc/>
+		public void AddCallback(Window target, Action callback)
 		{
 			var weakReference = new WeakReference<object>(target);
 			_callbacks.Add((weakReference, callback));
+			target.Closed += (sender, args) => RemoveCallback(target);
+		}
 
-			if (target is Window window)
-				window.Closed += (sender, args) => RemoveCallback(target);
-
-			if (target is FrameworkElement element)
-				element.Unloaded += (sender, args) => RemoveCallback(target);
+		/// <inheritdoc/>
+		public void AddCallback(FrameworkElement target, Action callback)
+		{
+			var weakReference = new WeakReference<object>(target);
+			_callbacks.Add((weakReference, callback));
+			target.Unloaded += (sender, args) => RemoveCallback(target);
 		}
 
-		/// <summary>
-		/// Updates the title bar layout of the specified window based on the current flow direction.
-		/// </summary>
-		/// <param name="window">The window whose title bar layout needs updating.</param>
-		/// <returns>True if the title bar layout was successfully updated; otherwise, false.</returns>
+		/// <inheritdoc/>
 		public bool UpdateTitleBar(Window window)
 		{
 			try
@@ -85,20 +75,14 @@ public bool UpdateTitleBar(Window window)
 			return true;
 		}
 
-		/// <summary>
-		/// Updates the content layout of the specified window to match the current flow direction.
-		/// </summary>
-		/// <param name="window">The window whose content layout needs updating.</param>
+		/// <inheritdoc/>
 		public void UpdateContent(Window window)
 		{
 			if (window.Content is FrameworkElement frameworkElement)
 				frameworkElement.FlowDirection = FlowDirection;
 		}
 
-		/// <summary>
-		/// Updates the content layout of the specified framework element to match the current flow direction.
-		/// </summary>
-		/// <param name="frameworkElement">The framework element whose content layout needs updating.</param>
+		/// <inheritdoc/>
 		public void UpdateContent(FrameworkElement frameworkElement)
 		{
 			frameworkElement.FlowDirection = FlowDirection;