Titlebar button visibility improvements

lukeblevins · lukeblevins · commit 5c437db8ebfd · 2019-02-28T20:22:58.000-05:00
diff --git a/Files UWP/MainPage.xaml.cs b/Files UWP/MainPage.xaml.cs
@@ -39,18 +39,19 @@ public MainPage()
             Window.Current.SetTitleBar(DragArea);
             var titleBar = ApplicationView.GetForCurrentView().TitleBar;
             titleBar.ButtonBackgroundColor = Color.FromArgb(0, 255, 255, 255);
-            titleBar.ButtonHoverBackgroundColor = Color.FromArgb(75, 10, 10, 10);
+            titleBar.ButtonInactiveBackgroundColor = Color.FromArgb(0, 255, 255, 255);
             titleBar.ButtonHoverBackgroundColor = Color.FromArgb(75, 10, 10, 10);
             nv = navView;
             accessibleAutoSuggestBox = auto_suggest;
             PopulateNavViewWithExternalDrives();
             permissionBox = PermissionDialog;
             
 
-            //make the minimize, maximize and close button visible in light theme
+            // Make the minimize, maximize, and close button visible in different themes
             if (App.Current.RequestedTheme == ApplicationTheme.Dark)
             {
                 titleBar.ButtonForegroundColor = Colors.White;
+                titleBar.ButtonHoverBackgroundColor = Color.FromArgb(75, 240, 240, 240);
             }
             else if (App.Current.RequestedTheme == ApplicationTheme.Light)
             {
@@ -60,6 +61,7 @@ public MainPage()
             if (this.RequestedTheme == ElementTheme.Dark)
             {
                 titleBar.ButtonForegroundColor = Colors.White;
+                titleBar.ButtonHoverBackgroundColor = Color.FromArgb(75, 240, 240, 240);
             }
             else if (this.RequestedTheme == ElementTheme.Light)
             {

Original file line number	Diff line number	Diff line change
`@@ -39,18 +39,19 @@ public MainPage()`
`39`	`39`	`Window.Current.SetTitleBar(DragArea);`
`40`	`40`	`var titleBar = ApplicationView.GetForCurrentView().TitleBar;`
`41`	`41`	`titleBar.ButtonBackgroundColor = Color.FromArgb(0, 255, 255, 255);`
`42`		`- titleBar.ButtonHoverBackgroundColor = Color.FromArgb(75, 10, 10, 10);`
	`42`	`+ titleBar.ButtonInactiveBackgroundColor = Color.FromArgb(0, 255, 255, 255);`
`43`	`43`	`titleBar.ButtonHoverBackgroundColor = Color.FromArgb(75, 10, 10, 10);`
`44`	`44`	`nv = navView;`
`45`	`45`	`accessibleAutoSuggestBox = auto_suggest;`
`46`	`46`	`PopulateNavViewWithExternalDrives();`
`47`	`47`	`permissionBox = PermissionDialog;`
`48`	`48`
`49`	`49`
`50`		`- //make the minimize, maximize and close button visible in light theme`
	`50`	`+ // Make the minimize, maximize, and close button visible in different themes`
`51`	`51`	`if (App.Current.RequestedTheme == ApplicationTheme.Dark)`
`52`	`52`	`{`
`53`	`53`	`titleBar.ButtonForegroundColor = Colors.White;`
	`54`	`+ titleBar.ButtonHoverBackgroundColor = Color.FromArgb(75, 240, 240, 240);`
`54`	`55`	`}`
`55`	`56`	`else if (App.Current.RequestedTheme == ApplicationTheme.Light)`
`56`	`57`	`{`
`@@ -60,6 +61,7 @@ public MainPage()`
`60`	`61`	`if (this.RequestedTheme == ElementTheme.Dark)`
`61`	`62`	`{`
`62`	`63`	`titleBar.ButtonForegroundColor = Colors.White;`
	`64`	`+ titleBar.ButtonHoverBackgroundColor = Color.FromArgb(75, 240, 240, 240);`
`63`	`65`	`}`
`64`	`66`	`else if (this.RequestedTheme == ElementTheme.Light)`
`65`	`67`	`{`