Fix: uninitialized setting; Typed Settings

Author: FelixZacher

Files/Files.csproj

@@ -207,6 +207,7 @@
     <Compile Include="Search.xaml.cs">
       <DependentUpon>Search.xaml</DependentUpon>
     </Compile>
+    <Compile Include="Settings.cs" />
     <Compile Include="Settings.xaml.cs">
       <DependentUpon>Settings.xaml</DependentUpon>
     </Compile>

Files/Filesystem/ListedItem.cs

@@ -42,7 +42,8 @@ public static string GetFriendlyDate(DateTimeOffset d)
         {
             Windows.Storage.ApplicationDataContainer localSettings = Windows.Storage.ApplicationData.Current.LocalSettings;
             var elapsed = DateTimeOffset.Now - d;
-            string returnformat = Enum.Parse<TimeStyle>(localSettings.Values["datetimeformat"].ToString()) == TimeStyle.Application ? "D" : "g";
+
+            string returnformat = Enum.Parse<TimeStyle>(localSettings.Values[LocalSettings.DateTimeFormat].ToString()) == TimeStyle.Application ? "D" : "g";
 
             if (elapsed.TotalDays > 7)
             {

Files/Settings.cs

@@ -0,0 +1,13 @@
+using System;
+using System.Collections.Generic;
+using System.Linq;
+using System.Text;
+using System.Threading.Tasks;
+
+namespace Files
+{
+	public static class LocalSettings
+	{
+		public const string DateTimeFormat = "datetimeformat";
+	}
+}

Files/View Models/SettingsViewModel.cs

@@ -53,17 +53,21 @@ private void DetectSidebarOpacity()
 
         private void DetectDateTimeFormat()
         {
-            if (localSettings.Values["datetimeformat"] != null)
+            if (localSettings.Values[LocalSettings.DateTimeFormat] != null)
             {
-                if (localSettings.Values["datetimeformat"].ToString() == "Application")
+                if (localSettings.Values[LocalSettings.DateTimeFormat].ToString() == "Application")
                 {
                     DisplayedTimeStyle = TimeStyle.Application;
                 }
-                else if (localSettings.Values["datetimeformat"].ToString() == "System")
+                else if (localSettings.Values[LocalSettings.DateTimeFormat].ToString() == "System")
                 {
                     DisplayedTimeStyle = TimeStyle.System;
                 }
             }
+            else
+            {
+	            localSettings.Values[LocalSettings.DateTimeFormat] = "System";
+            }
         }
 
         private async void DetectCustomLocations()
@@ -243,11 +247,11 @@ public TimeStyle DisplayedTimeStyle
                 Set(ref _DisplayedTimeStyle, value);
                 if (value.Equals(TimeStyle.Application))
                 {
-                    localSettings.Values["datetimeformat"] = "Application";
+                    localSettings.Values[LocalSettings.DateTimeFormat] = "Application";
                 }
                 else if (value.Equals(TimeStyle.System))
                 {
-                    localSettings.Values["datetimeformat"] = "System";
+                    localSettings.Values[LocalSettings.DateTimeFormat] = "System";
                 }
             }
         }