Skip to content

Commit 69a02f1

Browse files
authored
Fix: Fixed InvalidOperationException in SideloadUpdateService.CheckForUpdatesAsync (#15930)
1 parent 0d743fb commit 69a02f1

File tree

1 file changed

+4
-8
lines changed

1 file changed

+4
-8
lines changed

src/Files.App/Services/App/AppUpdateSideloadService.cs

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -27,13 +27,8 @@ public sealed class SideloadUpdateService : ObservableObject, IUpdateService, ID
2727

2828
private const string TEMPORARY_UPDATE_PACKAGE_NAME = "UpdatePackage.msix";
2929

30-
private ILogger? Logger
31-
{
32-
get
33-
{
34-
return Ioc.Default.GetRequiredService<ILogger<App>>();
35-
}
36-
}
30+
private ILogger? Logger { get; } = Ioc.Default.GetRequiredService<ILogger<App>>();
31+
3732
private string PackageName { get; } = Package.Current.Id.Name;
3833

3934
private Version PackageVersion { get; } = new(
@@ -145,7 +140,8 @@ public async Task CheckForUpdatesAsync()
145140
}
146141
catch (Exception e)
147142
{
148-
Logger?.LogError(e, e.Message);
143+
// It seems that the logger may throw an exception, so we need to ignore it. (#15688)
144+
SafetyExtensions.IgnoreExceptions(() => Logger?.LogError(e, e.Message));
149145
}
150146
}
151147

0 commit comments

Comments
 (0)