Skip to content

Commit 69c7b48

Browse files
authored
Code Quality: Use CommandDescription on Actions Page (#17194)
1 parent 94e40ff commit 69c7b48

File tree

2 files changed

+16
-16
lines changed

2 files changed

+16
-16
lines changed

src/Files.App/Strings/en-US/Resources.resw

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1089,7 +1089,7 @@
10891089
<value>Toggle the info pane</value>
10901090
</data>
10911091
<data name="ToggleInfoPaneDescription" xml:space="preserve">
1092-
<value>Toggle the info pane to view the detail/preview panes</value>
1092+
<value>Toggle visibility of the detail/preview panes</value>
10931093
</data>
10941094
<data name="ToggleToolbar" xml:space="preserve">
10951095
<value>Toggle toolbar</value>
@@ -2421,31 +2421,31 @@
24212421
<value>Toggle whether to show sidebar</value>
24222422
</data>
24232423
<data name="CopyItemDescription" xml:space="preserve">
2424-
<value>Copy selected {0, plural, one {item} other {items}} to clipboard</value>
2424+
<value>Copy selected {0, plural, one {item} other {items}}</value>
24252425
</data>
24262426
<data name="CopyPathDescription" xml:space="preserve">
2427-
<value>Copy path of the current directory to the clipboard</value>
2427+
<value>Copy path of the current directory</value>
24282428
</data>
24292429
<data name="CopyItemPathDescription" xml:space="preserve">
2430-
<value>Copy path of selected items to the clipboard</value>
2430+
<value>Copy path of selected items</value>
24312431
</data>
24322432
<data name="CopyItemPathWithQuotesDescription" xml:space="preserve">
2433-
<value>Copy path of selected items with quotes to the clipboard</value>
2433+
<value>Copy path of selected items with quotes</value>
24342434
</data>
24352435
<data name="CopyPathWithQuotesDescription" xml:space="preserve">
2436-
<value>Copy path of the current directory with quotes to the clipboard</value>
2436+
<value>Copy path of the current directory with quotes</value>
24372437
</data>
24382438
<data name="CutItemDescription" xml:space="preserve">
2439-
<value>Cut selected {0, plural, one {item} other {items}} to clipboard</value>
2439+
<value>Cut selected {0, plural, one {item} other {items}}</value>
24402440
</data>
24412441
<data name="PasteItemDescription" xml:space="preserve">
2442-
<value>Paste clipboard items to the current folder</value>
2442+
<value>Paste items to the current folder</value>
24432443
</data>
24442444
<data name="PasteShortcutDescription" xml:space="preserve">
2445-
<value>Paste clipboard items to the current folder as shortcuts</value>
2445+
<value>Paste items to the current folder as shortcuts</value>
24462446
</data>
24472447
<data name="PasteItemToSelectionDescription" xml:space="preserve">
2448-
<value>Paste clipboard items to the selected folder</value>
2448+
<value>Paste items to the selected folder</value>
24492449
</data>
24502450
<data name="PasteToSelectedFolder" xml:space="preserve">
24512451
<value>Paste to selected folder</value>
@@ -2568,13 +2568,13 @@
25682568
<value>Create zip archive with selected {0, plural, one {item} other {items}}</value>
25692569
</data>
25702570
<data name="DecompressArchiveDescription" xml:space="preserve">
2571-
<value>Extract items from selected {0, plural, one {archive} other {archives}} to any folder</value>
2571+
<value>Extract selected {0, plural, one {archive} other {archives}} to any folder</value>
25722572
</data>
25732573
<data name="DecompressArchiveHereDescription" xml:space="preserve">
2574-
<value>Extract items from selected {0, plural, one {archive} other {archives}} to current folder</value>
2574+
<value>Extract selected {0, plural, one {archive} other {archives}} to the current folder</value>
25752575
</data>
25762576
<data name="DecompressArchiveToChildFolderDescription" xml:space="preserve">
2577-
<value>Extract items from selected {0, plural, one {archive} other {archives}} to new folder</value>
2577+
<value>Extract selected {0, plural, one {archive} other {archives}} to new folder</value>
25782578
</data>
25792579
<data name="RotateLeftDescription" xml:space="preserve">
25802580
<value>Rotate selected {0, plural, one {image} other {images}} to the left</value>
@@ -3746,7 +3746,7 @@
37463746
<value>There was an error applying this tag</value>
37473747
</data>
37483748
<data name="DecompressArchiveHereSmartDescription" xml:space="preserve">
3749-
<value>Extract items from selected {0, plural, one {archive} other {archives}} to current folder for single-item archive, or to new folder for multi-item archive</value>
3749+
<value>Extract selected {0, plural, one {archive} other {archives}} here for single-item or to new folder for multi-item</value>
37503750
</data>
37513751
<data name="ExtractHereSmart" xml:space="preserve">
37523752
<value>Extract here (Smart)</value>

src/Files.App/Views/Settings/ActionsPage.xaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,7 @@
139139
<!-- New Command Selector -->
140140
<uc:ComboBoxEx
141141
x:Name="NewKeyBindingItemPickerComboBox"
142-
DisplayMemberPath="CommandLabel"
142+
DisplayMemberPath="CommandDescription"
143143
DropDownClosed="NewKeyBindingItemPickerComboBox_DropDownClosed"
144144
ItemsSource="{x:Bind ViewModel.AllActionItems, Mode=OneWay}"
145145
PlaceholderText="{helpers:ResourceString Name=ChooseAnAction}"
@@ -211,7 +211,7 @@
211211
<DataTemplate x:DataType="dataitems:ModifiableActionItem">
212212
<UserControl PointerEntered="RootGrid_PointerEntered" PointerExited="RootGrid_PointerExited">
213213
<Grid x:Name="RootGrid">
214-
<controls:SettingsCard Description="{x:Bind CommandDescription}" Header="{x:Bind CommandLabel}">
214+
<controls:SettingsCard Header="{x:Bind CommandDescription}">
215215
<controls:SettingsCard.Content>
216216
<Grid MinHeight="36" ColumnSpacing="12">
217217
<Grid.ColumnDefinitions>

0 commit comments

Comments
 (0)