Added file picker

Author: ferrariofilippo

src/Files.App/Actions/Open/OpenInIDEAction.cs

@@ -48,7 +48,14 @@ private void Context_PropertyChanged(object? sender, PropertyChangedEventArgs e)
 		private void DevSettings_PropertyChanged(object? sender, PropertyChangedEventArgs e)
 		{
 			if (e.PropertyName == nameof(IDevToolsSettingsService.IDEPath))
+			{
 				OnPropertyChanged(nameof(IsExecutable));
+			}
+			else if (e.PropertyName == nameof(IDevToolsSettingsService.FriendlyIDEName))
+			{
+				OnPropertyChanged(nameof(Label));
+				OnPropertyChanged(nameof(Description));
+			}
 		}
 	}
 }

src/Files.App/Actions/Open/OpenRepoInIDEAction.cs

@@ -45,7 +45,14 @@ private void Context_PropertyChanged(object? sender, PropertyChangedEventArgs e)
 		private void DevSettings_PropertyChanged(object? sender, PropertyChangedEventArgs e)
 		{
 			if (e.PropertyName == nameof(IDevToolsSettingsService.IDEPath))
+			{
 				OnPropertyChanged(nameof(IsExecutable));
+			}
+			else if (e.PropertyName == nameof(IDevToolsSettingsService.FriendlyIDEName))
+			{
+				OnPropertyChanged(nameof(Label));
+				OnPropertyChanged(nameof(Description));
+			}
 		}
 	}
 }

src/Files.App/ViewModels/Settings/DevToolsViewModel.cs

@@ -9,6 +9,7 @@ public sealed partial class DevToolsViewModel : ObservableObject
 	{
 		protected readonly IFileTagsSettingsService FileTagsSettingsService = Ioc.Default.GetRequiredService<IFileTagsSettingsService>();
 		protected readonly IDevToolsSettingsService DevToolsSettingsService = Ioc.Default.GetRequiredService<IDevToolsSettingsService>();
+		private readonly ICommonDialogService CommonDialogService = Ioc.Default.GetRequiredService<ICommonDialogService>();
 
 		public Dictionary<OpenInIDEOption, string> OpenInIDEOptions { get; private set; } = [];
 		public ICommand RemoveCredentialsCommand { get; }
@@ -37,21 +38,42 @@ public bool IsEditingIDEConfig
 		public bool CanSaveIDEChanges
 		{
 			get => _CanSaveIDEChanges;
-			set => SetProperty(ref  _CanSaveIDEChanges, value);
+			set => SetProperty(ref _CanSaveIDEChanges, value);
+		}
+
+		private bool _IsFriendlyNameValid;
+		public bool IsFriendlyNameValid
+		{
+			get => _IsFriendlyNameValid;
+			set => SetProperty(ref _IsFriendlyNameValid, value);
 		}
 
 		private string _IDEPath;
 		public string IDEPath
 		{
 			get => _IDEPath;
-			set => SetProperty(ref _IDEPath, value);
+			set
+			{
+				if (SetProperty(ref _IDEPath, value))
+					CanSaveIDEChanges = IsFriendlyNameValid && !string.IsNullOrWhiteSpace(IDEPath);
+			}
 		}
 
 		private string _IDEFriendlyName;
 		public string IDEFriendlyName
 		{
 			get => _IDEFriendlyName;
-			set => SetProperty(ref _IDEFriendlyName, value);
+			set
+			{
+				if (SetProperty(ref _IDEFriendlyName, value))
+				{
+					IsFriendlyNameValid =
+						!string.IsNullOrEmpty(value) &&
+						!value.Contains('\"') &&
+						!value.Contains('\'');
+					CanSaveIDEChanges = IsFriendlyNameValid && !string.IsNullOrWhiteSpace(IDEPath);
+				}
+			}
 		}
 
 		public DevToolsViewModel()
@@ -63,6 +85,8 @@ public DevToolsViewModel()
 
 			IDEPath = DevToolsSettingsService.IDEPath;
 			IDEFriendlyName = DevToolsSettingsService.FriendlyIDEName;
+			IsFriendlyNameValid = true;
+			CanSaveIDEChanges = false;
 
 			IsLogoutEnabled = GitHelpers.GetSavedCredentials() != string.Empty;
 
@@ -112,6 +136,8 @@ private void DoCancelIDEChanges()
 		private void DoSaveIDEChanges()
 		{
 			IsEditingIDEConfig = false;
+			IsFriendlyNameValid = true;
+			CanSaveIDEChanges = false;
 			DevToolsSettingsService.IDEPath = IDEPath;
 			DevToolsSettingsService.FriendlyIDEName = IDEFriendlyName;
 		}
@@ -123,7 +149,15 @@ private void DoStartEditingIDE()
 
 		private void DoOpenFilePickerForIDE()
 		{
-
+			var result = CommonDialogService.Open_FileOpenDialog(
+				MainWindow.Instance.WindowHandle,
+				false,
+				[ "*.exe;*.bat;*.cmd;*.ahk" ],
+				Environment.SpecialFolder.ProgramFiles,
+				out var filePath
+			);
+
+			IDEPath = filePath;
 		}
 	}
 }

src/Files.App/Views/Settings/DevToolsPage.xaml

@@ -76,6 +76,13 @@
 							Text="{helpers:ResourceString Name=DefaultIDE}"
 							TextTrimming="CharacterEllipsis" />
 
+						<TextBlock
+							Grid.Column="1"
+							VerticalAlignment="Center"
+							FontWeight="SemiBold"
+							Text="{x:Bind ViewModel.IDEFriendlyName, Mode=TwoWay}"
+							Visibility="{x:Bind ViewModel.IsEditingIDEConfig, Converter={StaticResource InvertedBoolVisibilityConverter}, Mode=OneWay}" />
+
 						<StackPanel
 							Grid.Column="1"
 							Orientation="Horizontal"
@@ -85,8 +92,7 @@
 								x:Name="IDEFriendlyNameTextBox"
 								Width="200"
 								VerticalAlignment="Center"
-								Text="{x:Bind ViewModel.IDEFriendlyName, Mode=TwoWay}"
-								Visibility="{x:Bind ViewModel.IsEditingIDEConfig, Converter={StaticResource BoolVisibilityConverter}, Mode=OneWay}">
+								Text="{x:Bind ViewModel.IDEFriendlyName, Mode=TwoWay, UpdateSourceTrigger=PropertyChanged}">
 								<TextBox.Resources>
 									<SolidColorBrush x:Key="TextControlBackgroundFocused" Color="{ThemeResource SolidBackgroundFillColorSecondary}" />
 								</TextBox.Resources>
@@ -96,7 +102,6 @@
 								x:Name="PickIDEExe"
 								Grid.Column="1"
 								Command="{x:Bind ViewModel.OpenFilePickerForIDECommand, Mode=OneWay}"
-								CommandParameter="{x:Bind XamlRoot, Mode=OneWay}"
 								Content="{helpers:ResourceString Name=Browse}" />
 						</StackPanel>
 
@@ -124,7 +129,7 @@
 								ColumnSpacing="8"
 								CornerRadius="4"
 								ToolTipService.ToolTip="{helpers:ResourceString Name=ErrorInputEmpty}"
-								Visibility="{x:Bind ViewModel.CanSaveIDEChanges, Mode=OneWay, Converter={StaticResource InvertedBoolVisibilityConverter}}">
+								Visibility="{x:Bind ViewModel.IsFriendlyNameValid, Mode=OneWay, Converter={StaticResource InvertedBoolVisibilityConverter}}">
 								<Grid.ColumnDefinitions>
 									<ColumnDefinition Width="Auto" />
 									<ColumnDefinition Width="Auto" />