Skip to content

Commit 6bdb741

Browse files
committed
Improved xaml
1 parent 2e5a997 commit 6bdb741

File tree

2 files changed

+45
-34
lines changed

2 files changed

+45
-34
lines changed

src/Files.App/Strings/en-US/Resources.resw

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4029,4 +4029,7 @@
40294029
<data name="ClearItems" xml:space="preserve">
40304030
<value>Clear items</value>
40314031
</data>
4032+
<data name="RemoveFromShelf" xml:space="preserve">
4033+
<value>Remove from shelf</value>
4034+
</data>
40324035
</root>

src/Files.App/UserControls/Pane/ShelfPane.xaml

Lines changed: 42 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616

1717
<Grid
1818
Width="240"
19+
Padding="12"
1920
AllowDrop="True"
2021
Background="{ThemeResource App.Theme.InfoPane.BackgroundBrush}"
2122
BackgroundSizing="InnerBorderEdge"
@@ -27,56 +28,62 @@
2728
RowSpacing="8">
2829

2930
<Grid.RowDefinitions>
31+
<RowDefinition Height="Auto" />
3032
<RowDefinition Height="*" />
3133
<RowDefinition Height="Auto" />
3234
</Grid.RowDefinitions>
3335

34-
<StackPanel
35-
Grid.Row="0"
36-
Padding="12"
37-
Spacing="8">
36+
<StackPanel Grid.Row="0" Spacing="8">
3837

3938
<!-- Title -->
4039
<TextBlock
4140
HorizontalAlignment="Center"
42-
Foreground="{ThemeResource TextFillColorSecondaryBrush}"
43-
Style="{StaticResource App.Theme.BodyStrongTextBlockStyle}"
41+
Foreground="{ThemeResource TextFillColorTertiaryBrush}"
42+
Style="{StaticResource App.Theme.BodyTextBlockStyle}"
4443
Text="{helpers:ResourceString Name=Shelf}" />
4544

4645
<!-- (Divider) -->
4746
<Border Height="1" Background="{ThemeResource DividerStrokeColorDefaultBrush}" />
4847

49-
<!-- Items List -->
50-
<ListView
51-
DragItemsStarting="ListView_DragItemsStarting"
52-
ItemsSource="{x:Bind ItemsSource, Mode=OneWay}"
53-
SelectionMode="Extended">
54-
<ListView.ItemTemplate>
55-
<DataTemplate x:DataType="data:ShelfItem">
56-
<StackPanel Orientation="Horizontal" Spacing="8">
57-
<Image Height="20" Source="{x:Bind Icon, Mode=OneWay, Converter={StaticResource ImageModelToImageConverter}}" />
58-
<TextBlock Text="{x:Bind Name, Mode=OneWay}" />
59-
60-
<StackPanel.ContextFlyout>
61-
<MenuFlyout>
62-
<MenuFlyoutItem Command="{x:Bind RemoveCommand}" Text="{helpers:ResourceString Name=Remove}">
63-
<MenuFlyoutItem.Icon>
64-
<FontIcon Glyph="&#xE738;" />
65-
</MenuFlyoutItem.Icon>
66-
</MenuFlyoutItem>
67-
</MenuFlyout>
68-
</StackPanel.ContextFlyout>
69-
</StackPanel>
70-
</DataTemplate>
71-
</ListView.ItemTemplate>
72-
</ListView>
7348
</StackPanel>
7449

75-
76-
<StackPanel
50+
<!-- Items List -->
51+
<ListView
7752
Grid.Row="1"
78-
Padding="12,8,12,8"
79-
Spacing="4">
53+
DragItemsStarting="ListView_DragItemsStarting"
54+
ItemsSource="{x:Bind ItemsSource, Mode=OneWay}"
55+
ScrollViewer.VerticalScrollBarVisibility="Auto"
56+
ScrollViewer.VerticalScrollMode="Auto"
57+
SelectionMode="Extended">
58+
<ListView.ItemTemplate>
59+
<DataTemplate x:DataType="data:ShelfItem">
60+
<StackPanel Orientation="Horizontal" Spacing="8">
61+
<Image Height="20" Source="{x:Bind Icon, Mode=OneWay, Converter={StaticResource ImageModelToImageConverter}}" />
62+
<TextBlock Text="{x:Bind Name, Mode=OneWay}" />
63+
64+
<StackPanel.ContextFlyout>
65+
<MenuFlyout>
66+
<MenuFlyoutItem Command="{x:Bind RemoveCommand}" Text="{helpers:ResourceString Name=RemoveFromShelf}">
67+
<MenuFlyoutItem.Icon>
68+
<FontIcon Glyph="&#xE738;" />
69+
</MenuFlyoutItem.Icon>
70+
</MenuFlyoutItem>
71+
</MenuFlyout>
72+
</StackPanel.ContextFlyout>
73+
</StackPanel>
74+
</DataTemplate>
75+
</ListView.ItemTemplate>
76+
77+
<ListView.ItemContainerStyle>
78+
<Style BasedOn="{StaticResource DefaultListViewItemStyle}" TargetType="ListViewItem">
79+
<Setter Property="Margin" Value="-4,0,-4,0" />
80+
<Setter Property="MinHeight" Value="36" />
81+
</Style>
82+
</ListView.ItemContainerStyle>
83+
</ListView>
84+
85+
86+
<StackPanel Grid.Row="2" Spacing="4">
8087

8188
<!-- (Divider) -->
8289
<Border Height="1" Background="{ThemeResource DividerStrokeColorDefaultBrush}" />
@@ -87,6 +94,7 @@
8794
VerticalAlignment="Center"
8895
Command="{x:Bind ClearCommand, Mode=OneWay}"
8996
Content="{helpers:ResourceString Name=ClearItems}" />
97+
9098
</StackPanel>
9199
</Grid>
92100
</UserControl>

0 commit comments

Comments
 (0)