Skip to content

Commit 6d10970

Browse files
yaira2yaira2
authored
Code Quality: Fix async warnings (#13832)
1 parent 6cb059f commit 6d10970

File tree

9 files changed

+31
-31
lines changed

9 files changed

+31
-31
lines changed

‎src/Files.App/Actions/Content/Background/SetAsLockscreenBackgroundAction.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ public override RichGlyph Glyph
2121
public override Task ExecuteAsync()
2222
{
2323
if (context.SelectedItem is not null)
24-
WallpaperHelpers.SetAsBackgroundAsync(WallpaperType.LockScreen, context.SelectedItem.ItemPath);
24+
return WallpaperHelpers.SetAsBackgroundAsync(WallpaperType.LockScreen, context.SelectedItem.ItemPath);
2525

2626
return Task.CompletedTask;
2727
}

‎src/Files.App/Actions/Content/Background/SetAsWallpaperBackgroundAction.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ public override RichGlyph Glyph
2121
public override Task ExecuteAsync()
2222
{
2323
if (context.SelectedItem is not null)
24-
WallpaperHelpers.SetAsBackgroundAsync(WallpaperType.Desktop, context.SelectedItem.ItemPath);
24+
return WallpaperHelpers.SetAsBackgroundAsync(WallpaperType.Desktop, context.SelectedItem.ItemPath);
2525

2626
return Task.CompletedTask;
2727
}

‎src/Files.App/ViewModels/UserControls/SidebarViewModel.cs

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -597,7 +597,7 @@ public async Task UpdateSectionVisibilityAsync(SectionType sectionType, bool sho
597597
}
598598
}
599599

600-
private void UserSettingsService_OnSettingChangedEvent(object sender, SettingChangedEventArgs e)
600+
private async void UserSettingsService_OnSettingChangedEvent(object sender, SettingChangedEventArgs e)
601601
{
602602
switch (e.SettingName)
603603
{
@@ -608,31 +608,31 @@ private void UserSettingsService_OnSettingChangedEvent(object sender, SettingCha
608608
}
609609
break;
610610
case nameof(UserSettingsService.GeneralSettingsService.ShowFavoritesSection):
611-
UpdateSectionVisibilityAsync(SectionType.Favorites, ShowFavoritesSection);
611+
await UpdateSectionVisibilityAsync(SectionType.Favorites, ShowFavoritesSection);
612612
OnPropertyChanged(nameof(ShowFavoritesSection));
613613
break;
614614
case nameof(UserSettingsService.GeneralSettingsService.ShowLibrarySection):
615-
UpdateSectionVisibilityAsync(SectionType.Library, ShowLibrarySection);
615+
await UpdateSectionVisibilityAsync(SectionType.Library, ShowLibrarySection);
616616
OnPropertyChanged(nameof(ShowLibrarySection));
617617
break;
618618
case nameof(UserSettingsService.GeneralSettingsService.ShowCloudDrivesSection):
619-
UpdateSectionVisibilityAsync(SectionType.CloudDrives, ShowCloudDrivesSection);
619+
await UpdateSectionVisibilityAsync(SectionType.CloudDrives, ShowCloudDrivesSection);
620620
OnPropertyChanged(nameof(ShowCloudDrivesSection));
621621
break;
622622
case nameof(UserSettingsService.GeneralSettingsService.ShowDrivesSection):
623-
UpdateSectionVisibilityAsync(SectionType.Drives, ShowDrivesSection);
623+
await UpdateSectionVisibilityAsync(SectionType.Drives, ShowDrivesSection);
624624
OnPropertyChanged(nameof(ShowDrivesSection));
625625
break;
626626
case nameof(UserSettingsService.GeneralSettingsService.ShowNetworkDrivesSection):
627-
UpdateSectionVisibilityAsync(SectionType.Network, ShowNetworkDrivesSection);
627+
await UpdateSectionVisibilityAsync(SectionType.Network, ShowNetworkDrivesSection);
628628
OnPropertyChanged(nameof(ShowNetworkDrivesSection));
629629
break;
630630
case nameof(UserSettingsService.GeneralSettingsService.ShowWslSection):
631-
UpdateSectionVisibilityAsync(SectionType.WSL, ShowWslSection);
631+
await UpdateSectionVisibilityAsync(SectionType.WSL, ShowWslSection);
632632
OnPropertyChanged(nameof(ShowWslSection));
633633
break;
634634
case nameof(UserSettingsService.GeneralSettingsService.ShowFileTagsSection):
635-
UpdateSectionVisibilityAsync(SectionType.FileTag, ShowFileTagsSection);
635+
await UpdateSectionVisibilityAsync(SectionType.FileTag, ShowFileTagsSection);
636636
OnPropertyChanged(nameof(ShowFileTagsSection));
637637
break;
638638
}
@@ -1262,7 +1262,7 @@ private async void HandleLocationItemDroppedAsync(LocationItem locationItem, Ite
12621262
foreach (var item in storageItems)
12631263
{
12641264
if (item.ItemType == FilesystemItemType.Directory && !SidebarPinnedModel.FavoriteItems.Contains(item.Path))
1265-
QuickAccessService.PinToSidebarAsync(item.Path);
1265+
await QuickAccessService.PinToSidebarAsync(item.Path);
12661266
}
12671267
}
12681268
else

‎src/Files.App/Views/LayoutModes/DetailsLayoutBrowser.xaml.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -404,15 +404,15 @@ protected override async void FileList_PreviewKeyDown(object sender, KeyRoutedEv
404404
protected override bool CanGetItemFromElement(object element)
405405
=> element is ListViewItem;
406406

407-
private void FolderSettings_GridViewSizeChangeRequested(object? sender, EventArgs e)
407+
private async void FolderSettings_GridViewSizeChangeRequested(object? sender, EventArgs e)
408408
{
409409
var requestedIconSize = FolderSettings.GetIconSize(); // Get new icon size
410410

411411
// Prevents reloading icons when the icon size hasn't changed
412412
if (requestedIconSize != currentIconSize)
413413
{
414414
currentIconSize = requestedIconSize; // Update icon size before refreshing
415-
ReloadItemIconsAsync();
415+
await ReloadItemIconsAsync();
416416
}
417417
}
418418

‎src/Files.App/Views/LayoutModes/GridViewBrowser.xaml.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ protected override void OnNavigatingFrom(NavigatingCancelEventArgs e)
110110
FolderSettings.GridViewSizeChangeRequested -= FolderSettings_GridViewSizeChangeRequested;
111111
}
112112

113-
private void FolderSettings_LayoutModeChangeRequested(object? sender, LayoutModeEventArgs e)
113+
private async void FolderSettings_LayoutModeChangeRequested(object? sender, LayoutModeEventArgs e)
114114
{
115115
if (FolderSettings.LayoutMode == FolderLayoutModes.GridView || FolderSettings.LayoutMode == FolderLayoutModes.TilesView)
116116
{
@@ -121,7 +121,7 @@ private void FolderSettings_LayoutModeChangeRequested(object? sender, LayoutMode
121121
if (requestedIconSize != currentIconSize)
122122
{
123123
currentIconSize = requestedIconSize;
124-
ReloadItemIconsAsync();
124+
await ReloadItemIconsAsync();
125125
}
126126
}
127127
}
@@ -335,7 +335,7 @@ protected override async void FileList_PreviewKeyDown(object sender, KeyRoutedEv
335335
protected override bool CanGetItemFromElement(object element)
336336
=> element is GridViewItem;
337337

338-
private void FolderSettings_GridViewSizeChangeRequested(object? sender, EventArgs e)
338+
private async void FolderSettings_GridViewSizeChangeRequested(object? sender, EventArgs e)
339339
{
340340
SetItemMinWidth();
341341

@@ -347,7 +347,7 @@ private void FolderSettings_GridViewSizeChangeRequested(object? sender, EventArg
347347
{
348348
// Update icon size before refreshing
349349
currentIconSize = requestedIconSize;
350-
ReloadItemIconsAsync();
350+
await ReloadItemIconsAsync();
351351
}
352352
}
353353

‎src/Files.App/Views/LayoutModes/StandardLayoutMode.cs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -73,14 +73,14 @@ protected override void UnhookEvents()
7373
ItemManipulationModel.RefreshItemsThumbnailInvoked -= ItemManipulationModel_RefreshItemsThumbnail;
7474
}
7575

76-
protected virtual void ItemManipulationModel_RefreshItemsThumbnail(object? sender, EventArgs e)
76+
protected virtual async void ItemManipulationModel_RefreshItemsThumbnail(object? sender, EventArgs e)
7777
{
78-
ReloadSelectedItemsIconAsync();
78+
await ReloadSelectedItemsIconAsync();
7979
}
8080

81-
protected virtual void ItemManipulationModel_RefreshItemThumbnail(object? sender, EventArgs args)
81+
protected virtual async void ItemManipulationModel_RefreshItemThumbnail(object? sender, EventArgs args)
8282
{
83-
ReloadSelectedItemIconAsync();
83+
await ReloadSelectedItemIconAsync();
8484
}
8585

8686
protected virtual async Task ReloadSelectedItemIconAsync()

‎src/Files.App/Views/MainPage.xaml.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,7 @@ private void SetRectDragRegion()
150150
dragZoneLeftIndent: (int)(TabControl.ActualWidth + TabControl.Margin.Left - TabControl.DragArea.ActualWidth));
151151
}
152152

153-
public void TabItemContent_ContentChanged(object? sender, CustomTabViewItemParameter e)
153+
public async void TabItemContent_ContentChanged(object? sender, CustomTabViewItemParameter e)
154154
{
155155
if (SidebarAdaptiveViewModel.PaneHolder is null)
156156
return;
@@ -162,7 +162,7 @@ public void TabItemContent_ContentChanged(object? sender, CustomTabViewItemParam
162162
UpdateStatusBarProperties();
163163
LoadPaneChanged();
164164
UpdateNavToolbarProperties();
165-
ViewModel.UpdateInstancePropertiesAsync(paneArgs);
165+
await ViewModel.UpdateInstancePropertiesAsync(paneArgs);
166166
}
167167

168168
public void MultitaskingControl_CurrentInstanceChanged(object? sender, CurrentInstanceChangedEventArgs e)

‎src/Files.App/Views/Settings/AboutPage.xaml.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,10 @@ public AboutPage()
1414
InitializeComponent();
1515
}
1616

17-
private void ThirdPartyLicenses_Click(object sender, bool e)
17+
private async void ThirdPartyLicenses_Click(object sender, bool e)
1818
{
1919
if (e && ViewModel.ThirdPartyNotices is null)
20-
ViewModel.LoadThirdPartyNoticesAsync();
20+
await ViewModel.LoadThirdPartyNoticesAsync();
2121
}
2222

2323
private async void MarkdownTextBlock_LinkClicked(object sender, LinkClickedEventArgs e)

‎src/Files.App/Views/Shells/BaseShellPage.cs

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -364,9 +364,9 @@ protected async void ShellPage_TextChanged(ISearchBox sender, SearchBoxTextChang
364364
}
365365
}
366366

367-
protected void ShellPage_RefreshRequested(object sender, EventArgs e)
367+
protected async void ShellPage_RefreshRequested(object sender, EventArgs e)
368368
{
369-
Refresh_Click();
369+
await Refresh_Click();
370370
}
371371

372372
protected void AppSettings_SortDirectionPreferenceUpdated(object sender, SortDirection e)
@@ -401,9 +401,9 @@ protected async void ShellPage_PathBoxItemDropped(object sender, PathBoxItemDrop
401401
e.SignalEvent?.Set();
402402
}
403403

404-
protected void ShellPage_AddressBarTextEntered(object sender, AddressBarTextEnteredEventArgs e)
404+
protected async void ShellPage_AddressBarTextEntered(object sender, AddressBarTextEnteredEventArgs e)
405405
{
406-
ToolbarViewModel.SetAddressBarSuggestionsAsync(e.AddressBarTextField, this);
406+
await ToolbarViewModel.SetAddressBarSuggestionsAsync(e.AddressBarTextField, this);
407407
}
408408

409409
protected async void ShellPage_ToolbarPathItemLoaded(object sender, ToolbarPathItemLoadedEventArgs e)
@@ -430,10 +430,10 @@ protected void NavigationToolbar_EditModeEnabled(object sender, EventArgs e)
430430
: FilesystemViewModel.WorkingDirectory;
431431
}
432432

433-
protected void DrivesManager_PropertyChanged(object sender, PropertyChangedEventArgs e)
433+
protected async void DrivesManager_PropertyChanged(object sender, PropertyChangedEventArgs e)
434434
{
435435
if (e.PropertyName == "ShowUserConsentOnInit")
436-
DisplayFilesystemConsentDialogAsync();
436+
await DisplayFilesystemConsentDialogAsync();
437437
}
438438

439439
// Ensure that the path bar gets updated for user interaction

0 commit comments

Comments
 (0)