Added error dialog

Author: yaira2

src/Files.App/Actions/Open/OpenSettingsFileAction.cs

@@ -1,12 +1,15 @@
 // Copyright (c) Files Community
 // Licensed under the MIT License.
 
+using Microsoft.UI.Xaml.Controls;
+using Microsoft.UI.Xaml.Media;
+using Windows.Foundation.Metadata;
 using Windows.Storage;
 using Windows.System;
 
 namespace Files.App.Actions
 {
-	internal sealed partial class OpenSettingsFileAction :  IAction
+	internal sealed partial class OpenSettingsFileAction : IAction
 	{
 		public string Label
 			=> Strings.EditSettingsFile.GetLocalizedResource();
@@ -22,12 +25,30 @@ public RichGlyph Glyph
 
 		public async Task ExecuteAsync(object? parameter = null)
 		{
-			await SafetyExtensions.IgnoreExceptions(async () =>
+			try
 			{
 				var settingsJsonFile = await StorageFile.GetFileFromApplicationUriAsync(new Uri($"ms-appdata:///local/{Constants.LocalSettings.SettingsFolderName}/{Constants.LocalSettings.UserSettingsFileName}"));
 				if (!await Launcher.LaunchFileAsync(settingsJsonFile))
 					await ContextMenu.InvokeVerb("open", settingsJsonFile.Path);
-			});
+			}
+			catch (Exception ex)
+			{
+				// Only show the error dialog if no other popups are open
+				if (!VisualTreeHelper.GetOpenPopupsForXamlRoot(MainWindow.Instance.Content.XamlRoot).Any())
+				{
+					var errorDialog = new ContentDialog()
+					{
+						Title = Strings.FailedToOpenSettingsFile.GetLocalizedResource(),
+						Content = ex.Message,
+						PrimaryButtonText = Strings.OK.GetLocalizedResource(),
+					};
+
+					if (ApiInformation.IsApiContractPresent("Windows.Foundation.UniversalApiContract", 8))
+						errorDialog.XamlRoot = MainWindow.Instance.Content.XamlRoot;
+
+					await errorDialog.TryShowAsync();
+				}
+			}
 		}
 	}
-}
+}

src/Files.App/Strings/en-US/Resources.resw

@@ -3697,6 +3697,9 @@
   <data name="FailedToSetBackground" xml:space="preserve">
     <value>Failed to set the background wallpaper</value>
   </data>
+  <data name="FailedToOpenSettingsFile" xml:space="preserve">
+    <value>Failed to open the settings file</value>
+  </data>
   <data name="GitDeleteBranch" xml:space="preserve">
     <value>Delete Git branch</value>
   </data>