Use documented NavigationView adaptive behavior and always set titlebar (#2628)

Author: lukeblevins

Files/Views/Settings.xaml

@@ -52,14 +52,15 @@
         <muxc:NavigationView
             x:Name="SettingsPane"
             BackRequested="SettingsPane_BackRequested"
+            CompactModeThresholdWidth="0"
             IsBackButtonVisible="Visible"
             IsBackEnabled="True"
             IsPaneOpen="True"
             IsPaneToggleButtonVisible="False"
             IsSettingsVisible="False"
             IsTitleBarAutoPaddingEnabled="False"
             OpenPaneLength="250"
-            PaneDisplayMode="LeftCompact"
+            PaneDisplayMode="Auto"
             SelectionChanged="SettingsPane_SelectionChanged">
 
             <muxc:NavigationView.PaneHeader>
@@ -140,17 +141,5 @@
             </muxc:NavigationView.MenuItems>
             <Frame x:Name="SettingsContentFrame" Padding="14,30,0,0" />
         </muxc:NavigationView>
-        <VisualStateManager.VisualStateGroups>
-            <VisualStateGroup>
-                <VisualState>
-                    <VisualState.StateTriggers>
-                        <AdaptiveTrigger MinWindowWidth="{x:Bind SettingsPane.CompactModeThresholdWidth}" />
-                    </VisualState.StateTriggers>
-                    <VisualState.Setters>
-                        <Setter Target="SettingsPane.PaneDisplayMode" Value="Left" />
-                    </VisualState.Setters>
-                </VisualState>
-            </VisualStateGroup>
-        </VisualStateManager.VisualStateGroups>
     </Grid>
 </Page>

Files/Views/Settings.xaml.cs

@@ -5,6 +5,7 @@
 using Windows.UI.Core;
 using Windows.UI.Xaml;
 using Windows.UI.Xaml.Controls;
+using Windows.UI.Xaml.Navigation;
 
 namespace Files
 {
@@ -15,6 +16,11 @@ public sealed partial class Settings : Page
         public Settings()
         {
             this.InitializeComponent();
+        }
+
+        protected override void OnNavigatedTo(NavigationEventArgs eventArgs)
+        {
+            base.OnNavigatedTo(eventArgs);
 
             var CoreTitleBar = CoreApplication.GetCurrentView().TitleBar;
             CoreTitleBar.ExtendViewIntoTitleBar = true;
@@ -33,6 +39,12 @@ public Settings()
             SettingsPane.SelectedItem = SettingsPane.MenuItems[0];
         }
 
+        protected override void OnNavigatedFrom(NavigationEventArgs eventArgs)
+        {
+            var currentView = SystemNavigationManager.GetForCurrentView();
+            currentView.BackRequested -= OnBackRequested;
+        }
+
         private void OnBackRequested(object sender, BackRequestedEventArgs e)
         {
             Frame rootFrame = Window.Current.Content as Frame;