Skip to content

Commit 7589abe

Browse files
added comments to new properties, changed name from Run to Start window
1 parent 0c734ba commit 7589abe

File tree

3 files changed

+17
-3
lines changed

3 files changed

+17
-3
lines changed

src/Files.App/Data/Models/SelectedItemsPropertiesViewModel.cs

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -788,15 +788,26 @@ public bool RunAsAdminEnabled
788788
{ SHOW_WINDOW_CMD.SW_SHOWMINNOACTIVE, Strings.Minimized.GetLocalizedResource() },
789789
{ SHOW_WINDOW_CMD.SW_MAXIMIZE, Strings.Maximized.GetLocalizedResource() }
790790
}.AsReadOnly();
791+
792+
/// <summary>
793+
/// The available show window command types.
794+
/// </summary>
791795
public IReadOnlyDictionary<SHOW_WINDOW_CMD, string> ShowWindowCommandTypes { get => showWindowCommandTypes; }
792796

797+
/// <summary>
798+
/// The localized string of the currently selected ShowWindowCommand.
799+
/// This value can be used for display in the UI.
800+
/// </summary>
793801
public string SelectedShowWindowCommand
794802
{
795803
get => ShowWindowCommandTypes.GetValueOrDefault(ShowWindowCommandEditedValue)!;
796804
set => ShowWindowCommandEditedValue = ShowWindowCommandTypes.First(e => e.Value == value).Key;
797805
}
798806

799807
private SHOW_WINDOW_CMD showWindowCommand;
808+
/// <summary>
809+
/// The current <see cref="SHOW_WINDOW_CMD"/> property of the item.
810+
/// </summary>
800811
public SHOW_WINDOW_CMD ShowWindowCommand
801812
{
802813
get => showWindowCommand;
@@ -808,6 +819,9 @@ public SHOW_WINDOW_CMD ShowWindowCommand
808819
}
809820

810821
private SHOW_WINDOW_CMD showWindowCommandEditedValue;
822+
/// <summary>
823+
/// The edited <see cref="SHOW_WINDOW_CMD"/> property of the item.
824+
/// </summary>
811825
public SHOW_WINDOW_CMD ShowWindowCommandEditedValue
812826
{
813827
get => showWindowCommandEditedValue;

src/Files.App/Strings/en-US/Resources.resw

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1838,8 +1838,8 @@
18381838
<data name="CompatibilityRegisterThisProgramForRestart" xml:space="preserve">
18391839
<value>Register this program for restart</value>
18401840
</data>
1841-
<data name="Run" xml:space="preserve">
1842-
<value>Run</value>
1841+
<data name="StartWindow" xml:space="preserve">
1842+
<value>Start window</value>
18431843
</data>
18441844
<data name="NormalWindow" xml:space="preserve">
18451845
<value>Normal window</value>

src/Files.App/Views/Properties/ShortcutPage.xaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -137,7 +137,7 @@
137137
Text="{x:Bind ViewModel.ShortcutItemWorkingDirEditedValue, Mode=TwoWay}" />
138138
</Grid>
139139

140-
<settingsuc:SettingsBlockControl Title="{helpers:ResourceString Name=Run}" HorizontalAlignment="Stretch">
140+
<settingsuc:SettingsBlockControl Title="{helpers:ResourceString Name=StartWindow}" HorizontalAlignment="Stretch">
141141
<ComboBox ItemsSource="{x:Bind ViewModel.ShowWindowCommandTypes.Values, Mode=OneWay}" SelectedItem="{x:Bind ViewModel.SelectedShowWindowCommand, Mode=TwoWay}" />
142142
</settingsuc:SettingsBlockControl>
143143

0 commit comments

Comments
 (0)