Code improvements in properties details (#2136)

Author: Thomas1664

Files/ResourceDictionaries/PropertiesStyles.xaml

@@ -12,6 +12,8 @@
     <Thickness x:Key="PropertyNameMargin">0,7</Thickness>
     <Thickness x:Key="PropertyValueMargin">20,0,0,0</Thickness>
     <VerticalAlignment x:Key="PropertyValueVerticalAlignment">Center</VerticalAlignment>
+    <!--Might be used for Expander control-->
+    <SolidColorBrush Color="Transparent" x:Key="SystemControlBackgroundBaseHighBrush"/>
 
     <Style x:Key="PropertyName" TargetType="TextBlock">
         <Setter Property="Margin" Value="{StaticResource PropertyNameMargin}" />
@@ -33,7 +35,6 @@
         <Setter Property="Margin" Value="{StaticResource PropertyValueMargin}" />
         <Setter Property="VerticalAlignment" Value="{StaticResource PropertyValueVerticalAlignment}" />
         <Setter Property="IsTextSelectionEnabled" Value="True" />
-        <Setter Property="Margin" Value="20,0,0,0" />
     </Style>
 
     <Style
@@ -44,18 +45,8 @@
         <Setter Property="VerticalAlignment" Value="{StaticResource PropertyValueVerticalAlignment}" />
         <Setter Property="HorizontalAlignment" Value="Stretch" />
         <Setter Property="BorderThickness" Value="1" />
-        <Setter Property="Margin" Value="20,0,0,0" />
-        <Setter Property="BorderBrush">
-            <Setter.Value>
-                <SolidColorBrush Color="Transparent" />
-            </Setter.Value>
-        </Setter>
-
-        <Setter Property="Background">
-            <Setter.Value>
-                <SolidColorBrush Color="Transparent" />
-            </Setter.Value>
-        </Setter>
+        <Setter Property="BorderBrush" Value="Transparent" />
+        <Setter Property="Background" Value="Transparent" />
     </Style>
 
     <converters:StringArrayToString x:Key="StringArrayToString" />

Files/UserControls/PropertyListItem.xaml

@@ -34,7 +34,6 @@
             Grid.Column="1"
             IsReadOnly="{x:Bind IsReadOnly, Mode=OneWay}"
             Style="{StaticResource PropertyValueTextBox}"
-            Text="{x:Bind ValueText, Mode=TwoWay}"
-            TextChanged="TextBox_TextChanged" />
+            Text="{x:Bind ValueText, Mode=TwoWay}" />
     </Grid>
 </UserControl>

Files/UserControls/PropertyListItem.xaml.cs

@@ -31,9 +31,5 @@ public PropertyListItem()
         {
             this.InitializeComponent();
         }
-
-        private void TextBox_TextChanged(object sender, TextChangedEventArgs e)
-        {
-        }
     }
 }

Files/View Models/Properties/PropertiesTab.cs

@@ -15,7 +15,7 @@ public abstract class PropertiesTab : Page
 
         protected Microsoft.UI.Xaml.Controls.ProgressBar ItemMD5HashProgress = null;
 
-        protected void Properties_Loaded(object sender, RoutedEventArgs e)
+        protected virtual void Properties_Loaded(object sender, RoutedEventArgs e)
         {
             if (BaseProperties != null)
             {