Fix: Fixed crash that could occur when trying to open the settings file (#13719)

d2dyno1 · web-flow · commit 786a74d4a4b2 · 2023-11-07T16:24:40.000-05:00
diff --git a/src/Files.App/ViewModels/Settings/AdvancedViewModel.cs b/src/Files.App/ViewModels/Settings/AdvancedViewModel.cs
@@ -46,12 +46,12 @@ public AdvancedViewModel()
 
 		private async Task OpenSettingsJsonAsync()
 		{
-			var settingsJsonPath = await StorageFile.GetFileFromApplicationUriAsync(new Uri("ms-appdata:///local/settings/user_settings.json"));
-
-			if (!await Launcher.LaunchFileAsync(settingsJsonPath))
+			await SafetyExtensions.IgnoreExceptions(async () =>
 			{
-				await ContextMenu.InvokeVerb("open", settingsJsonPath.Path);
-			}
+				var settingsJsonFile = await StorageFile.GetFileFromApplicationUriAsync(new Uri("ms-appdata:///local/settings/user_settings.json"));
+				if (!await Launcher.LaunchFileAsync(settingsJsonFile))
+					await ContextMenu.InvokeVerb("open", settingsJsonFile.Path);
+			});
 		}
 
 		private async Task SetAsDefaultExplorerAsync()

Original file line number	Diff line number	Diff line change
`@@ -46,12 +46,12 @@ public AdvancedViewModel()`
`46`	`46`
`47`	`47`	`private async Task OpenSettingsJsonAsync()`
`48`	`48`	`{`
`49`		`- var settingsJsonPath = await StorageFile.GetFileFromApplicationUriAsync(new Uri("ms-appdata:///local/settings/user_settings.json"));`
`50`		`-`
`51`		`- if (!await Launcher.LaunchFileAsync(settingsJsonPath))`
	`49`	`+ await SafetyExtensions.IgnoreExceptions(async () =>`
`52`	`50`	`{`
`53`		`- await ContextMenu.InvokeVerb("open", settingsJsonPath.Path);`
`54`		`- }`
	`51`	`+ var settingsJsonFile = await StorageFile.GetFileFromApplicationUriAsync(new Uri("ms-appdata:///local/settings/user_settings.json"));`
	`52`	`+ if (!await Launcher.LaunchFileAsync(settingsJsonFile))`
	`53`	`+ await ContextMenu.InvokeVerb("open", settingsJsonFile.Path);`
	`54`	`+ });`
`55`	`55`	`}`
`56`	`56`
`57`	`57`	`private async Task SetAsDefaultExplorerAsync()`