Code Quality: Improved tooltip UX in BreadcrumbBar (#17277)

Author: 0x5bfa

src/Files.App.Controls/BreadcrumbBar/BreadcrumbBar.Properties.cs

@@ -21,5 +21,8 @@ public partial class BreadcrumbBar : Control
 
 		[GeneratedDependencyProperty]
 		public partial string? RootItemToolTip { get; set; }
+
+		[GeneratedDependencyProperty]
+		public partial string? RootItemChevronToolTip { get; set; }
 	}
 }

src/Files.App.Controls/BreadcrumbBar/BreadcrumbBar.xaml

@@ -56,6 +56,7 @@
 							x:Name="PART_RootBreadcrumbBarItem"
 							Grid.Column="0"
 							Padding="{StaticResource BreadcrumbBarRootItemPadding}"
+							ChevronToolTip="{TemplateBinding RootItemChevronToolTip}"
 							CornerRadius="{StaticResource BreadcrumbBarRootItemCornerRadius}"
 							ItemToolTip="{TemplateBinding RootItemToolTip}">
 							<ContentPresenter Content="{Binding RootItem, RelativeSource={RelativeSource TemplatedParent}, Mode=OneWay}" />

src/Files.App.Controls/BreadcrumbBar/BreadcrumbBarItem.Properties.cs

@@ -14,10 +14,10 @@ public partial class BreadcrumbBarItem
 		public partial bool IsLastItem { get; set; }
 
 		[GeneratedDependencyProperty]
-		public partial string ItemToolTip { get; set; }
+		public partial string? ItemToolTip { get; set; }
 
 		[GeneratedDependencyProperty]
-		public partial string ChevronToolTip { get; set; }
+		public partial string? ChevronToolTip { get; set; }
 
 		partial void OnIsEllipsisChanged(bool newValue)
 		{

src/Files.App.Controls/Omnibar/Omnibar.xaml

@@ -131,6 +131,8 @@
 							Width="{StaticResource OmnibarModeDefaultClickAreaWidth}"
 							Height="{StaticResource OmnibarModeDefaultHeight}"
 							Margin="1"
+							AutomationProperties.AccessibilityView="Content"
+							AutomationProperties.Name="{Binding ModeName, RelativeSource={RelativeSource TemplatedParent}, Mode=OneWay}"
 							Background="{TemplateBinding Background}"
 							BorderBrush="{TemplateBinding BorderBrush}"
 							BorderThickness="0"

src/Files.App/Data/Items/PathBoxItem.cs

@@ -8,5 +8,7 @@ public sealed class PathBoxItem
 		public string? Title { get; set; }
 
 		public string? Path { get; set; }
+
+		public string? ChevronToolTip { get; set; }
 	}
 }

src/Files.App/Strings/en-US/Resources.resw

@@ -4256,7 +4256,10 @@
     <value>Show collapsed path breadcrumbs</value>
   </data>
   <data name="BreadcrumbBarChevronButtonToolTip" xml:space="preserve">
-    <value>Show child folders</value>
+    <value>Show folders in {0}</value>
+  </data>
+  <data name="BreadcrumbBarRootChevronButtonToolTip" xml:space="preserve">
+    <value>Show folders in Home</value>
   </data>
   <data name="NoCommandsFound" xml:space="preserve">
     <value>There are no commands containing {0}</value>

src/Files.App/UserControls/NavigationToolbar.xaml

@@ -251,6 +251,7 @@
 						ItemDropDownFlyoutClosed="BreadcrumbBar_ItemDropDownFlyoutClosed"
 						ItemDropDownFlyoutOpening="BreadcrumbBar_ItemDropDownFlyoutOpening"
 						ItemsSource="{x:Bind ViewModel.PathComponents, Mode=OneWay}"
+						RootItemChevronToolTip="{helpers:ResourceString Name=BreadcrumbBarRootChevronButtonToolTip}"
 						RootItemToolTip="{helpers:ResourceString Name=Home}">
 						<controls:BreadcrumbBar.RootItem>
 							<Image
@@ -264,7 +265,7 @@
 									AllowDrop="True"
 									AutomationProperties.AccessibilityView="Content"
 									AutomationProperties.Name="{x:Bind Title, Mode=OneWay}"
-									ChevronToolTip="{helpers:ResourceString Name=BreadcrumbBarChevronButtonToolTip}"
+									ChevronToolTip="{x:Bind ChevronToolTip, Mode=OneWay}"
 									Content="{x:Bind Title, Mode=OneWay}"
 									DataContext="{x:Bind}"
 									DragLeave="BreadcrumbBarItem_DragLeave"

src/Files.App/Utils/Storage/Helpers/StorageFileExtensions.cs

@@ -152,6 +152,8 @@ public static async Task<List<PathBoxItem>> GetDirectoryPathComponentsWithDispla
 					if (!string.IsNullOrEmpty(folder?.DisplayName))
 						item.Title = folder.DisplayName;
 				}
+
+				item.ChevronToolTip = string.Format(Strings.BreadcrumbBarChevronButtonToolTip.GetLocalizedResource(), item.Title);
 			}
 
 			return pathBoxItems;
@@ -321,7 +323,8 @@ private static PathBoxItem GetPathItem(string component, string path)
 			return new PathBoxItem()
 			{
 				Title = title,
-				Path = path
+				Path = path,
+				ChevronToolTip = string.Format(Strings.BreadcrumbBarChevronButtonToolTip.GetLocalizedResource(), title),
 			};
 		}
 

src/Files.App/Views/HomePage.xaml.cs

@@ -69,6 +69,7 @@ protected override async void OnNavigatedTo(NavigationEventArgs e)
 			{
 				Title = componentLabel,
 				Path = tag,
+				ChevronToolTip = string.Format(Strings.BreadcrumbBarChevronButtonToolTip.GetLocalizedResource(), componentLabel),
 			};
 
 			AppInstance.ToolbarViewModel.PathComponents.Add(item);

src/Files.App/Views/ReleaseNotesPage.xaml.cs

@@ -68,6 +68,7 @@ protected override async void OnNavigatedTo(NavigationEventArgs e)
 			{
 				Title = componentLabel,
 				Path = tag,
+				ChevronToolTip = string.Format(Strings.BreadcrumbBarChevronButtonToolTip.GetLocalizedResource(), componentLabel),
 			};
 
 			AppInstance.ToolbarViewModel.PathComponents.Add(item);