Update

Author: 0x5bfa

src/Files.App.CsWin32/NativeMethods.txt

@@ -234,3 +234,5 @@ IContextMenu2
 GetSubMenu
 GetMenuItemCount
 GetMenuItemInfo
+IsWow64Process2
+GetCurrentProcess

src/Files.App.Storage/Storables/WindowsStorage/JumpListDestinationType.cs

@@ -0,0 +1,17 @@
+using System;
+using System.Collections.Generic;
+using System.Linq;
+using System.Text;
+using System.Threading.Tasks;
+
+namespace Files.App.Storage
+{
+	public enum JumpListDestinationType
+	{
+		Pinned,
+
+		Recent,
+
+		Frequent,
+	}
+}

src/Files.App.Storage/Storables/WindowsStorage/JumpListManager.cs

@@ -12,83 +12,29 @@ namespace Files.App.Storage
 {
 	public unsafe class JumpListManager : IDisposable
 	{
-		private ComPtr<ICustomDestinationList> pCustomDestinationList = default;
+		public string AppId { get; }
 
-		private static string? AppId
+		public JumpListManager(string appId)
 		{
-			get
-			{
-				PWSTR pszAppId = default;
-				HRESULT hr = PInvoke.GetCurrentProcessExplicitAppUserModelID(&pszAppId);
-				if (hr == HRESULT.E_FAIL)
-					hr = HRESULT.S_OK;
+			if (string.IsNullOrEmpty(appId))
+				throw new ArgumentException("App ID cannot be null or empty.", nameof(appId));
 
-				hr.ThrowIfFailedOnDebug();
-
-				return pszAppId.ToString();
-			}
+			AppId = appId;
+			//_jumpList = new ConcurrentDictionary<string, IObjectArray>();
 		}
 
-		public ConcurrentBag<JumpListItem> JumpListItems { get; private set; } = [];
-
-		public ConcurrentBag<JumpListItem> RemovedItems { get; private set; } = [];
-
-		public ConcurrentBag<JumpListItem> RejectedItems { get; private set; } = [];
-
-		// A special "Frequent" category managed by Windows
-		public bool ShowFrequentCategory { get; set; }
-
-		// A special "Recent" category managed by Windows
-		public bool ShowRecentCategory { get; set; }
-
-		private static JumpListManager? _Default = null;
-		public static JumpListManager Default { get; } = _Default ??= new JumpListManager();
-
-		public JumpListManager()
+		public IEnumerable<WindowsStorable> GetAutomaticDestinations()
 		{
-			Guid CLSID_CustomDestinationList = typeof(DestinationList).GUID;
-			Guid IID_ICustomDestinationList = ICustomDestinationList.IID_Guid;
-			HRESULT hr = PInvoke.CoCreateInstance(
-				&CLSID_CustomDestinationList,
-				null,
-				CLSCTX.CLSCTX_INPROC_SERVER,
-				&IID_ICustomDestinationList,
-				(void**)pCustomDestinationList.GetAddressOf());
-
-			// Should not happen but as a sanity check at an early stage
-			hr.ThrowOnFailure();
+			return [];
 		}
 
-		public HRESULT Save()
+		public IEnumerable<WindowsStorable> GetCustomDestinations()
 		{
-			Debug.Assert(Thread.CurrentThread.GetApartmentState() is ApartmentState.STA);
-
-			HRESULT hr = pCustomDestinationList.Get()->SetAppID(AppId);
-
-			uint cMinSlots = 0;
-			ComPtr<IObjectArray> pDeletedItemsObjectArray = default;
-			Guid IID_IObjectArray = IObjectArray.IID_Guid;
-
-			hr = pCustomDestinationList.Get()->BeginList(&cMinSlots, &IID_IObjectArray, (void**)pDeletedItemsObjectArray.GetAddressOf());
-
-			// TODO: Validate items
-
-			// TODO: Group them as categories
-
-			// TODO: Append a custom category or to the Tasks
-
-			if (ShowFrequentCategory)
-				pCustomDestinationList.Get()->AppendKnownCategory(KNOWNDESTCATEGORY.KDC_FREQUENT);
-
-			if (ShowRecentCategory)
-				pCustomDestinationList.Get()->AppendKnownCategory(KNOWNDESTCATEGORY.KDC_RECENT);
-
-			return HRESULT.S_OK;
+			return [];
 		}
 
 		public void Dispose()
 		{
-			pCustomDestinationList.Dispose();
 		}
 	}
 }

src/Files.App.Storage/Storables/WindowsStorage/WindowsStorableHelpers.Process.cs

@@ -0,0 +1,28 @@
+// Copyright (c) Files Community
+// Licensed under the MIT License.
+
+using Windows.Win32;
+using Windows.Win32.Foundation;
+using Windows.Win32.System.SystemInformation;
+
+namespace Files.App.Storage
+{
+	public unsafe static partial class WindowsStorableHelpers
+	{
+		public static bool IsOnArmProcessor()
+		{
+			IMAGE_FILE_MACHINE dwMachineType = default;
+
+			// Assumes the current process token has "PROCESS_QUERY_INFORMATION" or "PROCESS_QUERY_LIMITED_INFORMATION" access right
+			bool fResult = PInvoke.IsWow64Process2(PInvoke.GetCurrentProcess(), null, &dwMachineType);
+			if (!fResult)
+				Debug.WriteLine($"{nameof(PInvoke.IsWow64Process2)} has failed.");
+
+			return dwMachineType is
+				IMAGE_FILE_MACHINE.IMAGE_FILE_MACHINE_THUMB or
+				IMAGE_FILE_MACHINE.IMAGE_FILE_MACHINE_ARMNT or
+				IMAGE_FILE_MACHINE.IMAGE_FILE_MACHINE_ARM64 or
+				IMAGE_FILE_MACHINE.IMAGE_FILE_MACHINE_ARM;
+		}
+	}
+}

src/Files.App.Storage/Storables/WindowsStorage/WindowsStorableHelpers.Storage.cs

@@ -84,5 +84,12 @@ public static bool TryShowFormatDriveDialog(HWND hWnd, uint driveLetterIndex, SH
 			var result = PInvoke.SHFormatDrive(hWnd, driveLetterIndex, id, options);
 			return result is 0xFFFF;
 		}
+
+		public static bool TryRenameVolumeLabel(string path, string newLabel)
+		{
+			// TODO: Use shell32.dll!CMountPointRename (CLSID: 60173D16-A550-47f0-A14B-C6F9E4DA0831, IID: 92F8D886-AB61-4113-BD4F-2E894397386F)
+
+			return false;
+		}
 	}
 }

src/Files.App/Helpers/Win32/Win32Helper.Process.cs

@@ -13,6 +13,7 @@ namespace Files.App.Helpers
 	public static partial class Win32Helper
 	{
 		private static bool? isRunningOnArm = null;
+		[Obsolete]
 		public static bool IsRunningOnArm
 		{
 			get
@@ -158,6 +159,7 @@ public static List<Process> WhoIsLocking(string[] resources)
 			return processes;
 		}
 
+		[Obsolete]
 		private static bool IsArmProcessor()
 		{
 			var handle = Process.GetCurrentProcess().Handle;