Fix: Fixed crash that sometimes occurred when opening pinned items (#17611)

Author: workbysaran

src/Files.App/ViewModels/HomeViewModel.cs

@@ -105,7 +105,7 @@ private void ReloadWidgets()
 
 		public void RefreshWidgetList()
 		{
-			for (int i = 0; i < WidgetItems.Count; i++)
+			for (int i = WidgetItems.Count - 1; i >= 0; i--)
 			{
 				if (!WidgetItems[i].WidgetItemModel.IsWidgetSettingEnabled)
 					RemoveWidgetAt(i);
@@ -116,8 +116,11 @@ public void RefreshWidgetList()
 
 		public async Task RefreshWidgetProperties()
 		{
-			foreach (var viewModel in WidgetItems.Select(x => x.WidgetItemModel))
-				await viewModel.RefreshWidgetAsync();
+			await MainWindow.Instance.DispatcherQueue.EnqueueOrInvokeAsync(async () =>
+			{
+				foreach (var viewModel in WidgetItems.Select(x => x.WidgetItemModel).ToList())
+					await viewModel.RefreshWidgetAsync();
+			});
 		}
 
 		private bool InsertWidget(WidgetContainerItem widgetModel, int atIndex)
@@ -136,19 +139,28 @@ private bool InsertWidget(WidgetContainerItem widgetModel, int atIndex)
 
 			if (atIndex > WidgetItems.Count)
 			{
-				WidgetItems.Add(widgetModel);
+				MainWindow.Instance.DispatcherQueue.EnqueueOrInvokeAsync(() =>
+				{
+					WidgetItems.Add(widgetModel);
+				});
 			}
 			else
 			{
-				WidgetItems.Insert(atIndex, widgetModel);
+				MainWindow.Instance.DispatcherQueue.EnqueueOrInvokeAsync(() =>
+				{
+					WidgetItems.Insert(atIndex, widgetModel);
+				});
 			}
 
 			return true;
 		}
 
 		public bool CanAddWidget(string widgetName)
 		{
-			return !(WidgetItems.Any((item) => item.WidgetItemModel.WidgetName == widgetName));
+			return MainWindow.Instance.DispatcherQueue.EnqueueOrInvokeAsync(() =>
+			{
+				return !(WidgetItems.Any((item) => item.WidgetItemModel.WidgetName == widgetName));
+			}).GetAwaiter().GetResult();
 		}
 
 		private void RemoveWidgetAt(int index)
@@ -158,25 +170,35 @@ private void RemoveWidgetAt(int index)
 				return;
 			}
 
-			WidgetItems[index].Dispose();
-			WidgetItems.RemoveAt(index);
+			MainWindow.Instance.DispatcherQueue.EnqueueOrInvokeAsync(() =>
+			{
+				WidgetItems[index].Dispose();
+				WidgetItems.RemoveAt(index);
+			});
 		}
 
 		public void RemoveWidget<TWidget>() where TWidget : IWidgetViewModel
 		{
-			int indexToRemove = -1;
-
-			for (int i = 0; i < WidgetItems.Count; i++)
+			MainWindow.Instance.DispatcherQueue.EnqueueOrInvokeAsync(() =>
 			{
-				if (typeof(TWidget).IsAssignableFrom(WidgetItems[i].WidgetControl.GetType()))
+				int indexToRemove = -1;
+
+				for (int i = 0; i < WidgetItems.Count; i++)
 				{
-					// Found matching types
-					indexToRemove = i;
-					break;
+					if (typeof(TWidget).IsAssignableFrom(WidgetItems[i].WidgetControl.GetType()))
+					{
+						// Found matching types
+						indexToRemove = i;
+						break;
+					}
 				}
-			}
 
-			RemoveWidgetAt(indexToRemove);
+				if (indexToRemove >= 0)
+				{
+					WidgetItems[indexToRemove].Dispose();
+					WidgetItems.RemoveAt(indexToRemove);
+				}
+			});
 		}
 
 		// Command methods
@@ -191,10 +213,13 @@ private async Task ExecuteReloadWidgetsCommand()
 
 		public void Dispose()
 		{
-			for (int i = 0; i < WidgetItems.Count; i++)
-				WidgetItems[i].Dispose();
+			MainWindow.Instance.DispatcherQueue.EnqueueOrInvokeAsync(() =>
+			{
+				for (int i = 0; i < WidgetItems.Count; i++)
+					WidgetItems[i].Dispose();
 
-			WidgetItems.Clear();
+				WidgetItems.Clear();
+			});
 		}
 	}
 }