Code Quality: Ignore exceptions in AppLifecycleHelper.HandleAppUnhandledException (#15958)

Author: hishitetsu

src/Files.App/Helpers/Application/AppLifecycleHelper.cs

@@ -250,94 +250,99 @@ public static void SaveSessionTabs()
 		/// </summary>
 		public static void HandleAppUnhandledException(Exception? ex, bool showToastNotification)
 		{
-			var generalSettingsService = Ioc.Default.GetRequiredService<IGeneralSettingsService>();
-
-			StringBuilder formattedException = new()
-			{
-				Capacity = 200
-			};
-
-			formattedException.AppendLine("--------- UNHANDLED EXCEPTION ---------");
-
-			if (ex is not null)
+			SafetyExtensions.IgnoreExceptions(() =>
 			{
-				ex.Data[Mechanism.HandledKey] = false;
-				ex.Data[Mechanism.MechanismKey] = "Application.UnhandledException";
+				var generalSettingsService = Ioc.Default.GetRequiredService<IGeneralSettingsService>();
 
-				SentrySdk.CaptureException(ex, scope =>
+				StringBuilder formattedException = new()
 				{
-					scope.User.Id = generalSettingsService?.UserId;
-					scope.Level = SentryLevel.Fatal;
-				});
+					Capacity = 200
+				};
 
-				formattedException.AppendLine($">>>> HRESULT: {ex.HResult}");
+				formattedException.AppendLine("--------- UNHANDLED EXCEPTION ---------");
 
-				if (ex.Message is not null)
-				{
-					formattedException.AppendLine("--- MESSAGE ---");
-					formattedException.AppendLine(ex.Message);
-				}
-				if (ex.StackTrace is not null)
+				if (ex is not null)
 				{
-					formattedException.AppendLine("--- STACKTRACE ---");
-					formattedException.AppendLine(ex.StackTrace);
+					ex.Data[Mechanism.HandledKey] = false;
+					ex.Data[Mechanism.MechanismKey] = "Application.UnhandledException";
+
+					SentrySdk.CaptureException(ex, scope =>
+					{
+						scope.User.Id = generalSettingsService?.UserId;
+						scope.Level = SentryLevel.Fatal;
+					});
+
+					formattedException.AppendLine($">>>> HRESULT: {ex.HResult}");
+
+					if (ex.Message is not null)
+					{
+						formattedException.AppendLine("--- MESSAGE ---");
+						formattedException.AppendLine(ex.Message);
+					}
+					if (ex.StackTrace is not null)
+					{
+						formattedException.AppendLine("--- STACKTRACE ---");
+						formattedException.AppendLine(ex.StackTrace);
+					}
+					if (ex.Source is not null)
+					{
+						formattedException.AppendLine("--- SOURCE ---");
+						formattedException.AppendLine(ex.Source);
+					}
+					if (ex.InnerException is not null)
+					{
+						formattedException.AppendLine("--- INNER ---");
+						formattedException.AppendLine(ex.InnerException.ToString());
+					}
 				}
-				if (ex.Source is not null)
-				{
-					formattedException.AppendLine("--- SOURCE ---");
-					formattedException.AppendLine(ex.Source);
-				}
-				if (ex.InnerException is not null)
+				else
 				{
-					formattedException.AppendLine("--- INNER ---");
-					formattedException.AppendLine(ex.InnerException.ToString());
+					formattedException.AppendLine("Exception data is not available.");
 				}
-			}
-			else
-			{
-				formattedException.AppendLine("Exception data is not available.");
-			}
 
-			formattedException.AppendLine("---------------------------------------");
+				formattedException.AppendLine("---------------------------------------");
 
-			Debug.WriteLine(formattedException.ToString());
+				Debug.WriteLine(formattedException.ToString());
 
-			// Please check "Output Window" for exception details (View -> Output Window) (CTRL + ALT + O)
-			Debugger.Break();
+				// Please check "Output Window" for exception details (View -> Output Window) (CTRL + ALT + O)
+				Debugger.Break();
+
+				App.Logger?.LogError(ex, ex?.Message ?? "An unhandled error occurred.");
+			});
 
 			// Save the current tab list in case it was overwriten by another instance
-			SaveSessionTabs();
-			App.Logger?.LogError(ex, ex?.Message ?? "An unhandled error occurred.");
+			SafetyExtensions.IgnoreExceptions(SaveSessionTabs);
 
 			if (!showToastNotification)
 				return;
 
-			SafetyExtensions.IgnoreExceptions(() =>
-			{
-				AppToastNotificationHelper.ShowUnhandledExceptionToast();
-			});
-
-			// Restart the app
-			var userSettingsService = Ioc.Default.GetRequiredService<IUserSettingsService>();
-			var lastSessionTabList = userSettingsService.GeneralSettingsService.LastSessionTabList;
+			SafetyExtensions.IgnoreExceptions(AppToastNotificationHelper.ShowUnhandledExceptionToast);
 
-			if (userSettingsService.GeneralSettingsService.LastCrashedTabList?.SequenceEqual(lastSessionTabList) ?? false)
-			{
-				// Avoid infinite restart loop
-				userSettingsService.GeneralSettingsService.LastSessionTabList = null;
-			}
-			else
+			SafetyExtensions.IgnoreExceptions(() =>
 			{
-				userSettingsService.AppSettingsService.RestoreTabsOnStartup = true;
-				userSettingsService.GeneralSettingsService.LastCrashedTabList = lastSessionTabList;
+				// Restart the app
+				var userSettingsService = Ioc.Default.GetRequiredService<IUserSettingsService>();
+				var lastSessionTabList = userSettingsService.GeneralSettingsService.LastSessionTabList;
 
-				// Try to re-launch and start over
-				MainWindow.Instance.DispatcherQueue.EnqueueOrInvokeAsync(async () =>
+				if (userSettingsService.GeneralSettingsService.LastCrashedTabList?.SequenceEqual(lastSessionTabList) ?? false)
 				{
-					await Launcher.LaunchUriAsync(new Uri("files-uwp:"));
-				})
-				.Wait(100);
-			}
+					// Avoid infinite restart loop
+					userSettingsService.GeneralSettingsService.LastSessionTabList = null;
+				}
+				else
+				{
+					userSettingsService.AppSettingsService.RestoreTabsOnStartup = true;
+					userSettingsService.GeneralSettingsService.LastCrashedTabList = lastSessionTabList;
+
+					// Try to re-launch and start over
+					MainWindow.Instance.DispatcherQueue.EnqueueOrInvokeAsync(async () =>
+					{
+						await Launcher.LaunchUriAsync(new Uri("files-uwp:"));
+					})
+					.Wait(100);
+				}
+			});
+
 			Process.GetCurrentProcess().Kill();
 		}