Code Quality: Refactor service initialization (#17529)

Author: yaira2

src/Files.App/Helpers/Application/AppLifecycleHelper.cs

@@ -105,23 +105,26 @@ public static async Task InitializeAppComponentsAsync()
 
 			// Start off a list of tasks we need to run before we can continue startup
 			await Task.WhenAll(
-				OptionalTaskAsync(CloudDrivesManager.UpdateDrivesAsync(), generalSettingsService.ShowCloudDrivesSection),
-				App.LibraryManager.UpdateLibrariesAsync(),
-				OptionalTaskAsync(WSLDistroManager.UpdateDrivesAsync(), generalSettingsService.ShowWslSection),
-				OptionalTaskAsync(App.FileTagsManager.UpdateFileTagsAsync(), generalSettingsService.ShowFileTagsSection),
 				App.QuickAccessManager.InitializeAsync()
 			);
 
-			await Task.WhenAll(
-				jumpListService.InitializeAsync(),
-				addItemService.InitializeAsync(),
-				ContextMenu.WarmUpQueryContextMenuAsync()
-			);
+			// Start non-critical tasks without waiting for them to complete
+			_ = Task.Run(async () =>
+			{
+				await Task.WhenAll(
+					OptionalTaskAsync(CloudDrivesManager.UpdateDrivesAsync(), generalSettingsService.ShowCloudDrivesSection),
+					App.LibraryManager.UpdateLibrariesAsync(),
+					OptionalTaskAsync(WSLDistroManager.UpdateDrivesAsync(), generalSettingsService.ShowWslSection),
+					OptionalTaskAsync(App.FileTagsManager.UpdateFileTagsAsync(), generalSettingsService.ShowFileTagsSection),
+					jumpListService.InitializeAsync(),
+					addItemService.InitializeAsync(),
+					ContextMenu.WarmUpQueryContextMenuAsync(),
+					CheckAppUpdate()
+				);
+			});
 
 			FileTagsHelper.UpdateTagsDb();
 
-			await CheckAppUpdate();
-
 			static Task OptionalTaskAsync(Task task, bool condition)
 			{
 				if (condition)

src/Files.App/Utils/Cloud/CloudDrivesManager.cs

@@ -11,12 +11,10 @@ namespace Files.App.Utils.Cloud
 	public static class CloudDrivesManager
 	{
 		private static readonly ILogger _logger = Ioc.Default.GetRequiredService<ILogger<App>>();
-
 		private static readonly ICloudDetector _detector = Ioc.Default.GetRequiredService<ICloudDetector>();
-
 		public static EventHandler<NotifyCollectionChangedEventArgs> DataChanged;
-
 		private static readonly List<DriveItem> _Drives = [];
+
 		public static IReadOnlyList<DriveItem> Drives
 		{
 			get
@@ -72,6 +70,25 @@ public static async Task UpdateDrivesAsync()
 					ShowProperties = true,
 				};
 
+				_ = LoadIconAsync(cloudProviderItem, provider);
+				lock (_Drives)
+				{
+					if (_Drives.Any(x => x.Path == cloudProviderItem.Path))
+						continue;
+
+					_Drives.Add(cloudProviderItem);
+				}
+				DataChanged?.Invoke(
+					SectionType.CloudDrives,
+					new NotifyCollectionChangedEventArgs(NotifyCollectionChangedAction.Add, cloudProviderItem)
+				);
+			}
+		}
+
+		private static async Task LoadIconAsync(DriveItem cloudProviderItem, ICloudProvider provider)
+		{
+			try
+			{
 				var iconData = provider.IconData;
 
 				if (iconData is null)
@@ -92,20 +109,11 @@ public static async Task UpdateDrivesAsync()
 					await MainWindow.Instance.DispatcherQueue.EnqueueOrInvokeAsync(async ()
 						=> cloudProviderItem.Icon = await iconData.ToBitmapAsync());
 				}
-
-				lock (_Drives)
-				{
-					if (_Drives.Any(x => x.Path == cloudProviderItem.Path))
-						continue;
-
-					_Drives.Add(cloudProviderItem);
-				}
-
-				DataChanged?.Invoke(
-					SectionType.CloudDrives,
-					new NotifyCollectionChangedEventArgs(NotifyCollectionChangedAction.Add, cloudProviderItem)
-				);
+			}
+			catch (Exception ex)
+			{
+				_logger?.LogWarning(ex, "Failed to load icon for cloud provider \"{ProviderName}\"", provider.Name);
 			}
 		}
 	}
-}
+}