Fix: Fixed issue with environment variables not working for shortcuts (#11130)

Author: hecksmosis

src/Files.App/Helpers/UIFilesystemHelpers.cs

@@ -414,7 +414,7 @@ public static async Task CreateShortcutFromDialogAsync(IShellPage associatedInst
 		/// <param name="runAsAdmin"></param>
 		public static void UpdateShortcutItemProperties(ShortcutItem item, string targetPath, string arguments, string workingDir, bool runAsAdmin)
 		{
-			item.TargetPath = targetPath;
+			item.TargetPath = Environment.ExpandEnvironmentVariables(targetPath);
 			item.Arguments = arguments;
 			item.WorkingDirectory = workingDir;
 			item.RunAsAdmin = runAsAdmin;

src/Files.App/ViewModels/Properties/FolderProperties.cs

@@ -61,7 +61,7 @@ public override void GetBaseProperties()
 					ViewModel.ShortcutItemOpenLinkCommand = new RelayCommand(async () =>
 					{
 						await App.Window.DispatcherQueue.EnqueueAsync(
-							() => NavigationHelpers.OpenPathInNewTab(Path.GetDirectoryName(ViewModel.ShortcutItemPath)));
+							() => NavigationHelpers.OpenPathInNewTab(Path.GetDirectoryName(Environment.ExpandEnvironmentVariables(ViewModel.ShortcutItemPath))));
 					}, () =>
 					{
 						return !string.IsNullOrWhiteSpace(ViewModel.ShortcutItemPath);