Code Quality: Fixed detection for RTL

Author: yaira2

src/Files.App/Helpers/Application/AppLanguageHelper.cs

@@ -27,6 +27,21 @@ public static class AppLanguageHelper
 		/// </summary>
 		public static AppLanguageItem PreferredLanguage { get; private set; }
 
+		/// <summary>
+		/// Gets the preferred language.
+		/// </summary>
+		public static bool IsPreferredLanguageRtl
+		{
+			get
+			{
+				if (PreferredLanguage.Code is null)
+					return false;
+
+				var culture = new CultureInfo(PreferredLanguage.Code);
+				return culture.TextInfo.IsRightToLeft;
+			}
+		}
+
 		/// <summary>
 		/// Initializes the <see cref="AppLanguageHelper"/> class.
 		/// </summary>

src/Files.App/UserControls/TabBar/TabBar.xaml.cs

@@ -363,7 +363,7 @@ private async void DragAreaRectangle_Loaded(object sender, RoutedEventArgs e)
 			if (HorizontalTabView.ActualWidth <= 0 && TabBarAddNewTabButton.Width <= 0)
 				await Task.Delay(100);
 
-			var titleBarInset = ((FilePropertiesHelpers.FlowDirectionSettingIsRightToLeft
+			var titleBarInset = ((AppLanguageHelper.IsPreferredLanguageRtl
 				? MainWindow.Instance.AppWindow.TitleBar.LeftInset
 				: MainWindow.Instance.AppWindow.TitleBar.RightInset) / DragAreaRectangle.XamlRoot.RasterizationScale) + 40;
 

src/Files.App/Utils/Storage/Helpers/FilePropertiesHelpers.cs

@@ -21,12 +21,6 @@ public static class FilePropertiesHelpers
 	{
 		private static IAppThemeModeService AppThemeModeService { get; } = Ioc.Default.GetRequiredService<IAppThemeModeService>();
 
-		/// <summary>
-		/// Whether LayoutDirection (FlowDirection) is set to right-to-left (RTL)
-		/// </summary>
-		public static readonly bool FlowDirectionSettingIsRightToLeft =
-			new ResourceManager().CreateResourceContext().QualifierValues["LayoutDirection"] == "RTL";
-
 		/// <summary>
 		/// Get window handle (hWnd) of the given properties window instance
 		/// </summary>

src/Files.App/Views/MainPage.xaml.cs

@@ -41,7 +41,7 @@ public MainPage()
 			SidebarAdaptiveViewModel.PaneFlyout = (MenuFlyout)Resources["SidebarContextMenu"];
 			ViewModel = Ioc.Default.GetRequiredService<MainPageViewModel>();
 
-			if (FilePropertiesHelpers.FlowDirectionSettingIsRightToLeft)
+			if (AppLanguageHelper.IsPreferredLanguageRtl)
 				FlowDirection = FlowDirection.RightToLeft;
 
 			ViewModel.PropertyChanged += ViewModel_PropertyChanged;

src/Files.App/Views/Properties/MainPropertiesPage.xaml.cs

@@ -26,7 +26,7 @@ public MainPropertiesPage()
 		{
 			InitializeComponent();
 
-			if (FilePropertiesHelpers.FlowDirectionSettingIsRightToLeft)
+			if (AppLanguageHelper.IsPreferredLanguageRtl)
 				FlowDirection = FlowDirection.RightToLeft;
 		}
 

src/Files.App/Views/Shells/BaseShellPage.cs

@@ -176,7 +176,7 @@ public BaseShellPage(CurrentInstanceViewModel instanceViewModel)
 
 			DisplayFilesystemConsentDialogAsync();
 
-			if (FilePropertiesHelpers.FlowDirectionSettingIsRightToLeft)
+			if (AppLanguageHelper.IsPreferredLanguageRtl)
 				FlowDirection = FlowDirection.RightToLeft;
 
 			ToolbarViewModel.ToolbarPathItemInvoked += ShellPage_NavigationRequested;