Fix: Fixed InvalidOperationException in ShellViewModel.FolderSizeProvider_SizeChanged (#16242)

Author: hishitetsu

src/Files.App/Services/SizeProvider/CachedSizeProvider.cs

@@ -37,6 +37,7 @@ public async Task UpdateAsync(string path, CancellationToken cancellationToken)
 				RaiseSizeChanged(path, 0, SizeChangedValueState.None);
 			}
 
+			var stopwatch = Stopwatch.StartNew();
 			ulong size = await Calculate(path);
 
 			sizes[path] = size;
@@ -81,8 +82,10 @@ async Task<ulong> Calculate(string path, int level = 0)
 							await Task.Yield();
 							sizes[localPath] = localSize;
 						}
-						if (level is 0)
+						if (level is 0 && stopwatch.ElapsedMilliseconds > 500)
 						{
+							// Limit updates to every 0.5 seconds to prevent crashes due to frequent updates
+							stopwatch.Restart();
 							RaiseSizeChanged(path, size, SizeChangedValueState.Intermediate);
 						}
 

src/Files.App/ViewModels/ShellViewModel.cs

@@ -603,7 +603,7 @@ private async void FolderSizeProvider_SizeChanged(object? sender, Services.SizeP
 			try
 			{
 				var matchingItem = filesAndFolders.ToList().FirstOrDefault(x => x.ItemPath == e.Path);
-				if (matchingItem is not null)
+				if (matchingItem is not null && (e.ValueState is not SizeChangedValueState.Intermediate || (long)e.NewSize > matchingItem.FileSizeBytes))
 				{
 					await dispatcherQueue.EnqueueOrInvokeAsync(() =>
 					{