Fix: Fixed crash when trying to create bitmap from null IconData in SidebarPinnedModel.cs (#12333)

hecksmosis · hishitetsu · commit 95d9d6c078bf · 2023-05-12T15:58:56.000+09:00
diff --git a/src/Files.App/DataModels/SidebarPinnedModel.cs b/src/Files.App/DataModels/SidebarPinnedModel.cs
@@ -115,7 +115,9 @@ public async Task<LocationItem> CreateLocationItemFromPathAsync(string path)
 				{
 					var iconData = await FileThumbnailHelper.LoadIconFromStorageItemAsync(res.Result, 96u, ThumbnailMode.ListView);
 					locationItem.IconData = iconData;
-					locationItem.Icon = await App.Window.DispatcherQueue.EnqueueOrInvokeAsync(() => locationItem.IconData.ToBitmapAsync());
+
+					if (locationItem.IconData is not null)
+						locationItem.Icon = await App.Window.DispatcherQueue.EnqueueOrInvokeAsync(() => locationItem.IconData.ToBitmapAsync());
 				}
 
 				if (locationItem.IconData is null)

Original file line number	Diff line number	Diff line change
`@@ -115,7 +115,9 @@ public async Task<LocationItem> CreateLocationItemFromPathAsync(string path)`
`115`	`115`	`{`
`116`	`116`	`var iconData = await FileThumbnailHelper.LoadIconFromStorageItemAsync(res.Result, 96u, ThumbnailMode.ListView);`
`117`	`117`	`locationItem.IconData = iconData;`
`118`		`- locationItem.Icon = await App.Window.DispatcherQueue.EnqueueOrInvokeAsync(() => locationItem.IconData.ToBitmapAsync());`
	`118`	`+`
	`119`	`+ if (locationItem.IconData is not null)`
	`120`	`+ locationItem.Icon = await App.Window.DispatcherQueue.EnqueueOrInvokeAsync(() => locationItem.IconData.ToBitmapAsync());`
`119`	`121`	`}`
`120`	`122`
`121`	`123`	`if (locationItem.IconData is null)`