Feature: Added iCloud Drive and Photos detection (#10819)

Author: RuiNtD

src/Files.App/Filesystem/Cloud/Detector/AppleCloudDetector.cs

@@ -28,7 +28,6 @@ private static IEnumerable<ICloudDetector> EnumerateDetectors()
 			yield return new GoogleDriveCloudDetector();
 			yield return new DropBoxCloudDetector();
 			yield return new BoxCloudDetector();
-			yield return new AppleCloudDetector();
 			yield return new GenericCloudDetector();
 			yield return new SynologyDriveCloudDetector();
 		}

src/Files.App/Filesystem/Cloud/Detector/CloudDetector.cs

@@ -78,6 +78,12 @@ private static Task<IEnumerable<ICloudProvider>> DetectGenericCloudDrive()
 						driveType = appName;
 					}
 
+					// iCloud specific
+					if (driveType.StartsWith("iCloudDrive"))
+						driveType = "iCloudDrive";
+					if (driveType.StartsWith("iCloudPhotos"))
+						driveType = "iCloudPhotos";
+
 					using var bagKey = clsidSubKey.OpenSubKey(@"Instance\InitPropertyBag");
 					var syncedFolder = (string)bagKey?.GetValue("TargetFolderPath");
 					if (syncedFolder is null)
@@ -92,6 +98,8 @@ private static Task<IEnumerable<ICloudProvider>> DetectGenericCloudDrive()
 						"Amazon Drive" => CloudProviders.AmazonDrive,
 						"Nextcloud" => CloudProviders.Nextcloud,
 						"Jottacloud" => CloudProviders.Jottacloud,
+						"iCloudDrive" => CloudProviders.AppleCloudDrive,
+						"iCloudPhotos" => CloudProviders.AppleCloudPhotos,
 						_ => null,
 					};
 					if (driveID is null)
@@ -108,6 +116,8 @@ private static Task<IEnumerable<ICloudProvider>> DetectGenericCloudDrive()
 							CloudProviders.AmazonDrive => $"Amazon Drive",
 							CloudProviders.Nextcloud => !string.IsNullOrEmpty(nextCloudValue) ? nextCloudValue : "Nextcloud",
 							CloudProviders.Jottacloud => $"Jottacloud",
+							CloudProviders.AppleCloudDrive => $"iCloud Drive",
+							CloudProviders.AppleCloudPhotos => $"iCloud Photos",
 							_ => null
 						},
 						SyncFolder = syncedFolder,

src/Files.App/Helpers/CloudDrivesDetector.cs

@@ -7,7 +7,8 @@ public enum CloudProviders
 		Mega,
 		GoogleDrive,
 		DropBox,
-		AppleCloud,
+		AppleCloudDrive,
+		AppleCloudPhotos,
 		AmazonDrive,
 		Nextcloud,
 		Yandex,