Minor improvements to recent files item loading (#2386)

Author: lukeblevins

Files/UserControls/MultitaskingControl/HorizontalMultitaskingControl.xaml

@@ -18,7 +18,10 @@
         <ResourceDictionary>
             <ResourceDictionary.MergedDictionaries>
                 <ResourceDictionary>
-                    <MenuFlyout x:Key="TabFlyout" x:Name="TabItemContextMenu" Opening="TabItemContextMenu_Opening">
+                    <MenuFlyout
+                        x:Key="TabFlyout"
+                        x:Name="TabItemContextMenu"
+                        Opening="TabItemContextMenu_Opening">
                         <MenuFlyoutItem
                             x:Uid="HorizontalMultitaskingControlNewTab"
                             Click="{x:Bind views:MainPage.AddNewTabAtIndex}"

Files/UserControls/StatusBarControl.xaml

@@ -63,7 +63,10 @@
                                 <FontIcon FontFamily="{StaticResource FluentUIGlyphs}" Glyph="&#xEB54;" />
                             </MenuFlyoutItem.Icon>
                             <MenuFlyoutItem.KeyboardAccelerators>
-                                <KeyboardAccelerator Modifiers="Control" Key="A" IsEnabled="False" />
+                                <KeyboardAccelerator
+                                    Key="A"
+                                    IsEnabled="False"
+                                    Modifiers="Control" />
                             </MenuFlyoutItem.KeyboardAccelerators>
                         </MenuFlyoutItem>
                         <MenuFlyoutItem

Files/UserControls/Widgets/RecentFiles.xaml

@@ -2,9 +2,7 @@
     x:Class="Files.RecentFiles"
     xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"
     xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
-    xmlns:controls="using:Microsoft.Toolkit.Uwp.UI.Controls"
     xmlns:d="http://schemas.microsoft.com/expression/blend/2008"
-    xmlns:list="using:Locations"
     xmlns:local="using:Files"
     xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006"
     Background="{ThemeResource ApplicationPageBackgroundThemeBrush}"
@@ -51,6 +49,7 @@
                     IsRightTapEnabled="True"
                     ItemClick="RecentsView_ItemClick"
                     ItemContainerStyle="{StaticResource ListViewItemContainerStyle1}"
+                    ItemContainerTransitions="{x:Null}"
                     ItemsSource="{x:Bind recentItemsCollection}"
                     SelectionMode="None">
                     <ListView.ItemTemplate>

Files/UserControls/Widgets/RecentFiles.xaml.cs

@@ -5,10 +5,12 @@
 using System.Collections.ObjectModel;
 using System.ComponentModel;
 using System.IO;
+using System.Linq;
 using System.Runtime.CompilerServices;
 using System.Runtime.InteropServices;
 using System.Threading.Tasks;
 using Windows.Storage;
+using Windows.Storage.AccessCache;
 using Windows.UI.Xaml;
 using Windows.UI.Xaml.Controls;
 using Windows.UI.Xaml.Media.Imaging;
@@ -55,36 +57,16 @@ private void OpenFileLocation_Click(object sender, RoutedEventArgs e)
 
         public async void PopulateRecentsList()
         {
-            var mostRecentlyUsed = Windows.Storage.AccessCache.StorageApplicationPermissions.MostRecentlyUsedList;
-            bool IsRecentsListEmpty = true;
-            foreach (var entry in mostRecentlyUsed.Entries)
-            {
-                try
-                {
-                    var item = await mostRecentlyUsed.GetItemAsync(entry.Token);
-                    if (item.IsOfType(StorageItemTypes.File))
-                    {
-                        IsRecentsListEmpty = false;
-                    }
-                }
-                catch (Exception) { }
-            }
+            var mostRecentlyUsed = StorageApplicationPermissions.MostRecentlyUsedList;
 
-            if (IsRecentsListEmpty)
-            {
-                Empty.Visibility = Visibility.Visible;
-            }
-            else
-            {
-                Empty.Visibility = Visibility.Collapsed;
-            }
+            Empty.Visibility = Visibility.Collapsed;
 
-            foreach (Windows.Storage.AccessCache.AccessListEntry entry in mostRecentlyUsed.Entries)
+            foreach (AccessListEntry entry in mostRecentlyUsed.Entries)
             {
                 string mruToken = entry.Token;
                 try
                 {
-                    IStorageItem item = await mostRecentlyUsed.GetItemAsync(mruToken);
+                    IStorageItem item = await mostRecentlyUsed.GetItemAsync(mruToken, AccessCacheOptions.FastLocationsOnly);
                     await AddItemToRecentListAsync(item, entry);
                 }
                 catch (UnauthorizedAccessException)
@@ -138,14 +120,14 @@ private async Task AddItemToRecentListAsync(IStorageItem item, Windows.Storage.A
                 ItemType = StorageItemTypes.File;
                 ItemImage = new BitmapImage();
                 StorageFile file = (StorageFile)item;
-                var thumbnail = await file.GetThumbnailAsync(Windows.Storage.FileProperties.ThumbnailMode.SingleItem, 30, Windows.Storage.FileProperties.ThumbnailOptions.UseCurrentScale);
+                var thumbnail = await file.GetThumbnailAsync(Windows.Storage.FileProperties.ThumbnailMode.ListView, 24, Windows.Storage.FileProperties.ThumbnailOptions.UseCurrentScale);
                 if (thumbnail == null)
                 {
                     ItemEmptyImgVis = Visibility.Visible;
                 }
                 else
                 {
-                    await ItemImage.SetSourceAsync(thumbnail.CloneStream());
+                    await ItemImage.SetSourceAsync(thumbnail);
                     ItemEmptyImgVis = Visibility.Collapsed;
                 }
                 ItemFolderImgVis = Visibility.Collapsed;
@@ -214,7 +196,7 @@ private void MenuFlyoutItem_Click(object sender, RoutedEventArgs e)
         {
             recentItemsCollection.Clear();
             RecentsView.ItemsSource = null;
-            var mru = Windows.Storage.AccessCache.StorageApplicationPermissions.MostRecentlyUsedList;
+            var mru = StorageApplicationPermissions.MostRecentlyUsedList;
             mru.Clear();
             Empty.Visibility = Visibility.Visible;
         }

Files/Views/LayoutModes/GenericFileBrowser.xaml

@@ -149,7 +149,10 @@
                     <FontIcon FontFamily="{StaticResource FluentUIGlyphs}" Glyph="&#xe9b2;" />
                 </MenuFlyoutItem.Icon>
                 <MenuFlyoutItem.KeyboardAccelerators>
-                    <KeyboardAccelerator Modifiers="Control" Key="V" IsEnabled="False" />
+                    <KeyboardAccelerator
+                        Key="V"
+                        IsEnabled="False"
+                        Modifiers="Control" />
                 </MenuFlyoutItem.KeyboardAccelerators>
             </MenuFlyoutItem>
             <MenuFlyoutSeparator />
@@ -172,7 +175,10 @@
                     <FontIcon FontFamily="{StaticResource FluentUIGlyphs}" Glyph="&#xe903;" />
                 </MenuFlyoutSubItem.Icon>
                 <MenuFlyoutSubItem.KeyboardAccelerators>
-                    <KeyboardAccelerator Modifiers="Control,Shift" Key="N" IsEnabled="False" />
+                    <KeyboardAccelerator
+                        Key="N"
+                        IsEnabled="False"
+                        Modifiers="Control,Shift" />
                 </MenuFlyoutSubItem.KeyboardAccelerators>
                 <MenuFlyoutItem
                     x:Name="NewFolder"
@@ -424,7 +430,10 @@
                     <FontIcon FontFamily="{StaticResource CustomGlyph}" Glyph="&#xF105;" />
                 </MenuFlyoutItem.Icon>
                 <MenuFlyoutItem.KeyboardAccelerators>
-                    <KeyboardAccelerator Modifiers="Control" Key="X" IsEnabled="False" />
+                    <KeyboardAccelerator
+                        Key="X"
+                        IsEnabled="False"
+                        Modifiers="Control" />
                 </MenuFlyoutItem.KeyboardAccelerators>
             </MenuFlyoutItem>
             <MenuFlyoutItem
@@ -436,7 +445,10 @@
                     <FontIcon FontFamily="{StaticResource FluentUIGlyphs}" Glyph="&#xe9d6;" />
                 </MenuFlyoutItem.Icon>
                 <MenuFlyoutItem.KeyboardAccelerators>
-                    <KeyboardAccelerator Modifiers="Control" Key="C" IsEnabled="False" />
+                    <KeyboardAccelerator
+                        Key="C"
+                        IsEnabled="False"
+                        Modifiers="Control" />
                 </MenuFlyoutItem.KeyboardAccelerators>
             </MenuFlyoutItem>
             <MenuFlyoutItem

Files/Views/Pages/PropertiesGeneral.xaml

@@ -362,8 +362,8 @@
                 <CheckBox
                     x:Uid="PropertiesDialogReadOnly"
                     Content="Read-only"
-                    IsEnabled="{x:Bind ViewModel.IsReadOnlyEnabled, Mode=OneWay}"
-                    IsChecked="{x:Bind ViewModel.IsReadOnly, Mode=TwoWay}"/>
+                    IsChecked="{x:Bind ViewModel.IsReadOnly, Mode=TwoWay}"
+                    IsEnabled="{x:Bind ViewModel.IsReadOnlyEnabled, Mode=OneWay}" />
                 <CheckBox
                     x:Uid="PropertiesDialogHidden"
                     Content="Hidden"