Code Quality: Ignore exceptions in AppLifecycleHelper.HandleAppUnhandledException - part 2 (#16036)

hishitetsu · web-flow · commit 99c390e0e94b · 2024-08-20T10:13:46.000-04:00
diff --git a/src/Files.Shared/Extensions/SafetyExtensions.cs b/src/Files.Shared/Extensions/SafetyExtensions.cs
@@ -20,7 +20,11 @@ public static bool IgnoreExceptions(Action action, ILogger? logger = null, Type?
 			{
 				if (exceptionToIgnore is null || exceptionToIgnore.IsAssignableFrom(ex.GetType()))
 				{
-					logger?.LogInformation(ex, ex.Message);
+					try
+					{
+						logger?.LogInformation(ex, ex.Message);
+					}
+					catch { }
 
 					return false;
 				}
@@ -41,7 +45,11 @@ public static async Task<bool> IgnoreExceptions(Func<Task> action, ILogger? logg
 			{
 				if (exceptionToIgnore is null || exceptionToIgnore.IsAssignableFrom(ex.GetType()))
 				{
-					logger?.LogInformation(ex, ex.Message);
+					try
+					{
+						logger?.LogInformation(ex, ex.Message);
+					}
+					catch { }
 
 					return false;
 				}
@@ -60,7 +68,11 @@ public static async Task<bool> IgnoreExceptions(Func<Task> action, ILogger? logg
 			{
 				if (exceptionToIgnore is null || exceptionToIgnore.IsAssignableFrom(ex.GetType()))
 				{
-					logger?.LogInformation(ex, ex.Message);
+					try
+					{
+						logger?.LogInformation(ex, ex.Message);
+					}
+					catch { }
 
 					return default;
 				}
@@ -79,7 +91,11 @@ public static async Task<bool> IgnoreExceptions(Func<Task> action, ILogger? logg
 			{
 				if (exceptionToIgnore is null || exceptionToIgnore.IsAssignableFrom(ex.GetType()))
 				{
-					logger?.LogInformation(ex, ex.Message);
+					try
+					{
+						logger?.LogInformation(ex, ex.Message);
+					}
+					catch { }
 
 					return default;
 				}

Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,11 @@ public static bool IgnoreExceptions(Action action, ILogger? logger = null, Type?`
`20`	`20`	`{`
`21`	`21`	`if (exceptionToIgnore is null \|\| exceptionToIgnore.IsAssignableFrom(ex.GetType()))`
`22`	`22`	`{`
`23`		`- logger?.LogInformation(ex, ex.Message);`
	`23`	`+ try`
	`24`	`+ {`
	`25`	`+ logger?.LogInformation(ex, ex.Message);`
	`26`	`+ }`
	`27`	`+ catch { }`
`24`	`28`
`25`	`29`	`return false;`
`26`	`30`	`}`
`@@ -41,7 +45,11 @@ public static async Task<bool> IgnoreExceptions(Func<Task> action, ILogger? logg`
`41`	`45`	`{`
`42`	`46`	`if (exceptionToIgnore is null \|\| exceptionToIgnore.IsAssignableFrom(ex.GetType()))`
`43`	`47`	`{`
`44`		`- logger?.LogInformation(ex, ex.Message);`
	`48`	`+ try`
	`49`	`+ {`
	`50`	`+ logger?.LogInformation(ex, ex.Message);`
	`51`	`+ }`
	`52`	`+ catch { }`
`45`	`53`
`46`	`54`	`return false;`
`47`	`55`	`}`
`@@ -60,7 +68,11 @@ public static async Task<bool> IgnoreExceptions(Func<Task> action, ILogger? logg`
`60`	`68`	`{`
`61`	`69`	`if (exceptionToIgnore is null \|\| exceptionToIgnore.IsAssignableFrom(ex.GetType()))`
`62`	`70`	`{`
`63`		`- logger?.LogInformation(ex, ex.Message);`
	`71`	`+ try`
	`72`	`+ {`
	`73`	`+ logger?.LogInformation(ex, ex.Message);`
	`74`	`+ }`
	`75`	`+ catch { }`
`64`	`76`
`65`	`77`	`return default;`
`66`	`78`	`}`
`@@ -79,7 +91,11 @@ public static async Task<bool> IgnoreExceptions(Func<Task> action, ILogger? logg`
`79`	`91`	`{`
`80`	`92`	`if (exceptionToIgnore is null \|\| exceptionToIgnore.IsAssignableFrom(ex.GetType()))`
`81`	`93`	`{`
`82`		`- logger?.LogInformation(ex, ex.Message);`
	`94`	`+ try`
	`95`	`+ {`
	`96`	`+ logger?.LogInformation(ex, ex.Message);`
	`97`	`+ }`
	`98`	`+ catch { }`
`83`	`99`
`84`	`100`	`return default;`
`85`	`101`	`}`