Fix crash due to wring thread (#4194)

Author: gave92

Files/BaseLayout.cs

@@ -150,10 +150,6 @@ internal set
 
         private List<ShellNewEntry> cachedNewContextMenuEntries { get; set; }
 
-        private DispatcherQueueController timerQueueController;
-
-        private DispatcherQueue timerQueue;
-
         private DispatcherQueueTimer dragOverTimer;
 
         public BaseLayout()
@@ -170,9 +166,7 @@ public BaseLayout()
                 IsQuickLookEnabled = true;
             }
 
-            timerQueueController = DispatcherQueueController.CreateOnDedicatedThread();
-            timerQueue = timerQueueController.DispatcherQueue;
-            dragOverTimer = timerQueue.CreateTimer();
+            dragOverTimer = DispatcherQueue.GetForCurrentThread().CreateTimer();
         }
 
         protected abstract void InitializeCommandsViewModel();

Files/UserControls/NavigationToolbar.xaml.cs

@@ -555,20 +555,14 @@ public bool PreviewPaneEnabled
 
         private List<ShellNewEntry> cachedNewContextMenuEntries { get; set; }
 
-        private DispatcherQueueController timerQueueController;
-
-        private DispatcherQueue timerQueue;
-
         private DispatcherQueueTimer dragOverTimer;
 
         public NavigationToolbar()
         {
             this.InitializeComponent();
             this.Loading += NavigationToolbar_Loading;
 
-            timerQueueController = DispatcherQueueController.CreateOnDedicatedThread();
-            timerQueue = timerQueueController.DispatcherQueue;
-            dragOverTimer = timerQueue.CreateTimer();
+            dragOverTimer = DispatcherQueue.GetForCurrentThread().CreateTimer();
         }
 
         private async void NavigationToolbar_Loading(FrameworkElement sender, object args)

Files/UserControls/SidebarControl.xaml.cs

@@ -73,20 +73,14 @@ public ICommand EmptyRecycleBinCommand
             set => SetValue(EmptyRecycleBinCommandProperty, value);
         }
 
-        private DispatcherQueueController timerQueueController;
-
-        private DispatcherQueue timerQueue;
-
         private DispatcherQueueTimer dragOverTimer;
 
         public SidebarControl()
         {
             this.InitializeComponent();
             SidebarNavView.Loaded += SidebarNavView_Loaded;
 
-            timerQueueController = DispatcherQueueController.CreateOnDedicatedThread();
-            timerQueue = timerQueueController.DispatcherQueue;
-            dragOverTimer = timerQueue.CreateTimer();
+            dragOverTimer = DispatcherQueue.GetForCurrentThread().CreateTimer();
         }
 
         private INavigationControlItem selectedSidebarItem;

Files/Views/LayoutModes/GenericFileBrowser.xaml.cs

@@ -93,10 +93,6 @@ public DataGridColumn SortedColumn
             }
         }
 
-        private DispatcherQueueController timerQueueController;
-
-        private DispatcherQueue timerQueue;
-
         private DispatcherQueueTimer tapDebounceTimer;
 
         public GenericFileBrowser()
@@ -111,9 +107,7 @@ public GenericFileBrowser()
             selectionRectangle.SelectionEnded += SelectionRectangle_SelectionEnded;
             AllView.PointerCaptureLost += AllView_ItemPress;
 
-            timerQueueController = DispatcherQueueController.CreateOnDedicatedThread();
-            timerQueue = timerQueueController.DispatcherQueue;
-            tapDebounceTimer = timerQueue.CreateTimer();
+            tapDebounceTimer = DispatcherQueue.GetForCurrentThread().CreateTimer();
         }
 
         protected override void InitializeCommandsViewModel()
@@ -307,7 +301,7 @@ private void ViewModel_PropertyChanged(object sender, PropertyChangedEventArgs e
 
         private TextBox renamingTextBox;
 
-        private async void AllView_BeginningEdit(object sender, DataGridBeginningEditEventArgs e)
+        private void AllView_BeginningEdit(object sender, DataGridBeginningEditEventArgs e)
         {
             if (ParentShellPageInstance.FilesystemViewModel.WorkingDirectory.StartsWith(AppSettings.RecycleBinPath))
             {
@@ -333,16 +327,12 @@ private async void AllView_BeginningEdit(object sender, DataGridBeginningEditEve
                     // We have an edit due to the first tap in the double-click mode
                     // Let's wait to see if there is another tap (double click).
 
-                    tapDebounceTimer.Debounce(async () =>
+                    tapDebounceTimer.Debounce(() =>
                     {
-                        await CoreApplication.MainView.DispatcherQueue.EnqueueAsync(() =>
-                        {
-                            tapDebounceTimer.Stop();
+                        tapDebounceTimer.Stop();
 
-                            AllView.BeginEdit();
-                        });
+                        AllView.BeginEdit();
                     }, TimeSpan.FromMilliseconds(700), false);
-                    
                 }
             }
             else