Fix: Fixed an issue where changing icons didn't work when admin access was required (#15625)

Author: yaira2

src/Files.App/Utils/Storage/Operations/FileOperationsHelpers.cs

@@ -4,7 +4,6 @@
 using Files.App.Utils.Storage.Operations;
 using Files.Shared.Helpers;
 using Microsoft.Extensions.Logging;
-using Microsoft.Win32;
 using System.Collections.Concurrent;
 using System.IO;
 using System.Runtime.InteropServices;
@@ -492,7 +491,7 @@ public static Task SetClipboard(string[] filesToCopy, DataPackageOperation opera
 						Destination = e.DestFolder.GetParsingPath() is not null && !string.IsNullOrEmpty(e.Name) ? Path.Combine(e.DestFolder.GetParsingPath(), e.Name) : null,
 						HResult = (int)e.Result
 					});
-					
+
 					UpdateFileTagsDb(e, "move");
 				};
 
@@ -580,10 +579,10 @@ public static Task SetClipboard(string[] filesToCopy, DataPackageOperation opera
 					{
 						using ShellItem shi = new(fileToCopyPath[i]);
 						using ShellFolder shd = new(Path.GetDirectoryName(copyDestination[i]));
-						
+
 						var fileName = GetIncrementalName(overwriteOnCopy, copyDestination[i], fileToCopyPath[i]);
 						// Perform a copy operation
-						op.QueueCopyOperation(shi, shd, fileName);						
+						op.QueueCopyOperation(shi, shd, fileName);
 					}))
 					{
 						shellOperationResult.Items.Add(new ShellOperationItemResult()
@@ -623,7 +622,7 @@ public static Task SetClipboard(string[] filesToCopy, DataPackageOperation opera
 						Destination = e.DestFolder.GetParsingPath() is not null && !string.IsNullOrEmpty(e.Name) ? Path.Combine(e.DestFolder.GetParsingPath(), e.Name) : null,
 						HResult = (int)e.Result
 					});
-					
+
 					UpdateFileTagsDb(e, "copy");
 				};
 
@@ -774,6 +773,38 @@ public static bool SetLinkIcon(string filePath, string iconFile, int iconIndex)
 				link.SaveAs(filePath); // Overwrite if exists
 				return true;
 			}
+			catch (UnauthorizedAccessException)
+			{
+				string psScript = $@"
+					$FilePath = '{filePath}'
+					$IconFile = '{iconFile}'
+					$IconIndex = '{iconIndex}'
+
+					$Shell = New-Object -ComObject WScript.Shell
+					$Shortcut = $Shell.CreateShortcut($FilePath)
+					$Shortcut.IconLocation = ""$IconFile, $IconIndex""
+					$Shortcut.Save()
+				";
+
+				var base64EncodedScript = Convert.ToBase64String(System.Text.Encoding.Unicode.GetBytes(psScript));
+
+				ProcessStartInfo startInfo = new ProcessStartInfo()
+				{
+					FileName = "powershell.exe",
+					Arguments = $"-NoProfile -EncodedCommand {base64EncodedScript}",
+					Verb = "runas",
+					CreateNoWindow = true,
+					WindowStyle = ProcessWindowStyle.Hidden,
+					UseShellExecute = true
+				};
+
+				// Start the process
+				Process process = new Process() { StartInfo = startInfo };
+				process.Start();
+				process.WaitForExit();
+
+				return true;
+			}
 			catch (Exception ex)
 			{
 				// Could not create shortcut
@@ -1023,7 +1054,7 @@ protected override void Dispose(bool disposing)
 		private static string GetIncrementalName(bool overWriteOnCopy, string? filePathToCheck, string? filePathToCopy)
 		{
 			if (filePathToCheck == null)
-				return null;			
+				return null;
 
 			if ((!Path.Exists(filePathToCheck)) || overWriteOnCopy || filePathToCheck == filePathToCopy)
 				return Path.GetFileName(filePathToCheck);
@@ -1039,6 +1070,6 @@ private static string GetIncrementalName(bool overWriteOnCopy, string? filePathT
 				index++;
 
 			return Path.GetFileName(genFilePath(index));
-		}		
+		}
 	}
 }