Move to helper

Author: ferrariofilippo

src/Files.App/Data/Factories/PropertiesNavigationViewItemFactory.cs

@@ -3,25 +3,12 @@
 
 using Files.Shared.Helpers;
 using Microsoft.UI.Xaml;
-using System.Collections.Frozen;
 using Windows.Storage;
 
 namespace Files.App.Data.Factories
 {
 	public static class PropertiesNavigationViewItemFactory
 	{
-		private static readonly FrozenSet<string> _signableTypes = new HashSet<string>()
-		{
-			".aab", ".apk", ".application", ".appx", ".appxbundle", ".arx", ".cab", ".cat", ".cbx",
-			".cpl", ".crx", ".dbx", ".deploy", ".dll", ".doc", ".docm", ".dot", ".dotm", ".drx",
-			".ear", ".efi", ".exe", ".jar", ".js", ".manifest", ".mpp", ".mpt", ".msi", ".msix",
-			".msixbundle", ".msm", ".msp", ".nupkg", ".ocx", ".pot", ".potm", ".ppa", ".ppam", ".pps",
-			".ppsm", ".ppt", ".pptm", ".ps1", ".psm1", ".psi", ".pub", ".sar", ".stl", ".sys", ".vbs",
-			".vdw", ".vdx", ".vsd", ".vsdm", ".vss", ".vssm", ".vst", ".vstm", ".vsto", ".vsix", ".vsx", ".vtx",
-			".vxd", ".war", ".wiz", ".wsf", ".xap", ".xla", ".xlam", ".xls", ".xlsb", ".xlsm", ".xlt",
-			".xltm", ".xlsm", ".xsn"
-		}.ToFrozenSet();
-
 		public static ObservableCollection<NavigationViewItemButtonStyleItem> Initialize(object item)
 		{
 			ObservableCollection<NavigationViewItemButtonStyleItem> PropertiesNavigationViewItems = [];
@@ -123,7 +110,11 @@ public static ObservableCollection<NavigationViewItemButtonStyleItem> Initialize
 				var detailsItemEnabled = !(isFolder && !listedItem.IsArchive) && !isLibrary && !listedItem.IsRecycleBinItem;
 				var customizationItemEnabled = !isLibrary && (isFolder && !listedItem.IsArchive || isShortcut && !listedItem.IsLinkItem);
 				var compatibilityItemEnabled = FileExtensionHelpers.IsExecutableFile(listedItem is IShortcutItem sht ? sht.TargetPath : fileExt, true);
-				var signaturesItemEnabled = !isFolder && !isLibrary && !listedItem.IsRecycleBinItem && _signableTypes.Contains(fileExt);
+				var signaturesItemEnabled = 
+					!isFolder &&
+					!isLibrary &&
+					!listedItem.IsRecycleBinItem &&
+					FileExtensionHelpers.IsSignableFile(fileExt, true);
 
 				if (!securityItemEnabled)
 					PropertiesNavigationViewItems.Remove(securityItem);

src/Files.Shared/Helpers/FileExtensionHelpers.cs

@@ -2,6 +2,8 @@
 // Licensed under the MIT License.
 
 using System;
+using System.Collections.Frozen;
+using System.Collections.Generic;
 using System.IO;
 using System.Linq;
 
@@ -12,6 +14,18 @@ namespace Files.Shared.Helpers
 	/// </summary>
 	public static class FileExtensionHelpers
 	{
+		private static readonly FrozenSet<string> _signableTypes = new HashSet<string>()
+		{
+			".aab", ".apk", ".application", ".appx", ".appxbundle", ".arx", ".cab", ".cat", ".cbx",
+			".cpl", ".crx", ".dbx", ".deploy", ".dll", ".doc", ".docm", ".dot", ".dotm", ".drx",
+			".ear", ".efi", ".exe", ".jar", ".js", ".manifest", ".mpp", ".mpt", ".msi", ".msix",
+			".msixbundle", ".msm", ".msp", ".nupkg", ".ocx", ".pot", ".potm", ".ppa", ".ppam", ".pps",
+			".ppsm", ".ppt", ".pptm", ".ps1", ".psm1", ".psi", ".pub", ".sar", ".stl", ".sys", ".vbs",
+			".vdw", ".vdx", ".vsd", ".vsdm", ".vss", ".vssm", ".vst", ".vstm", ".vsto", ".vsix", ".vsx", ".vtx",
+			".vxd", ".war", ".wiz", ".wsf", ".xap", ".xla", ".xlam", ".xls", ".xlsb", ".xlsm", ".xlt",
+			".xltm", ".xlsm", ".xsn"
+		}.ToFrozenSet();
+
 		/// <summary>
 		/// Check if the file extension matches one of the specified extensions.
 		/// </summary>
@@ -273,5 +287,20 @@ public static bool IsSystemFile(string? filePathToCheck)
 			return HasExtension(filePathToCheck, ".dll", ".exe", ".sys", ".inf");
 		}
 
+		/// <summary>
+		/// Check if the file is signable.
+		/// </summary>
+		/// <param name="filePathToCheck"></param>
+		/// <returns><c>true</c> if the filePathToCheck is a signable file; otherwise, <c>false</c>.</returns>
+		public static bool IsSignableFile(string? filePathToCheck, bool isExtension = false)
+		{
+			if (string.IsNullOrWhiteSpace(filePathToCheck))
+				return false;
+
+			if (!isExtension)
+				filePathToCheck = Path.GetExtension(filePathToCheck);
+
+			return _signableTypes.Contains(filePathToCheck);
+		}
 	}
 }