Fix: Prompt for credentials when a network share access is denied (#14904)

nmangue · web-flow · commit a83507e56f8a · 2024-03-05T07:41:22.000-08:00
diff --git a/src/Files.App/Utils/Global/NetworkDrivesAPI.cs b/src/Files.App/Utils/Global/NetworkDrivesAPI.cs
@@ -135,7 +135,7 @@ public static async Task<bool> AuthenticateNetworkShare(string path)
 
 			Win32Error connectionError = WNetAddConnection3(HWND.NULL, nr, null, null, 0);  // if creds are saved, this will return NO_ERROR
 
-			if (connectionError == Win32Error.ERROR_LOGON_FAILURE)
+			if (connectionError == Win32Error.ERROR_LOGON_FAILURE || connectionError == Win32Error.ERROR_ACCESS_DENIED)
 			{
 				var dialog = DynamicDialogFactory.GetFor_CredentialEntryDialog(path);
 				await dialog.ShowAsync();

Original file line number	Diff line number	Diff line change
`@@ -135,7 +135,7 @@ public static async Task<bool> AuthenticateNetworkShare(string path)`
`135`	`135`
`136`	`136`	`Win32Error connectionError = WNetAddConnection3(HWND.NULL, nr, null, null, 0); // if creds are saved, this will return NO_ERROR`
`137`	`137`
`138`		`- if (connectionError == Win32Error.ERROR_LOGON_FAILURE)`
	`138`	`+ if (connectionError == Win32Error.ERROR_LOGON_FAILURE \|\| connectionError == Win32Error.ERROR_ACCESS_DENIED)`
`139`	`139`	`{`
`140`	`140`	`var dialog = DynamicDialogFactory.GetFor_CredentialEntryDialog(path);`
`141`	`141`	`await dialog.ShowAsync();`