Fix: Fixed an issue with creating folder shortcuts (#16040)

hishitetsu · web-flow · commit a90fbace8f06 · 2024-08-20T18:35:45.000-04:00
diff --git a/src/Files.App/Utils/Storage/Operations/FileOperationsHelpers.cs b/src/Files.App/Utils/Storage/Operations/FileOperationsHelpers.cs
@@ -740,7 +740,11 @@ public static Task<bool> CreateOrUpdateLinkAsync(string linkSavePath, string tar
 				if (FileExtensionHelpers.IsShortcutFile(linkSavePath))
 				{
 					using var newLink = new ShellLink(targetPath, arguments, workingDirectory);
-					newLink.RunAsAdministrator = runAsAdmin;
+
+					// Check if the target is a file
+					if (File.Exists(targetPath))
+						newLink.RunAsAdministrator = runAsAdmin;
+
 					newLink.SaveAs(linkSavePath); // Overwrite if exists
 					return Task.FromResult(true);
 				}

Original file line number	Diff line number	Diff line change
`@@ -740,7 +740,11 @@ public static Task<bool> CreateOrUpdateLinkAsync(string linkSavePath, string tar`
`740`	`740`	`if (FileExtensionHelpers.IsShortcutFile(linkSavePath))`
`741`	`741`	`{`
`742`	`742`	`using var newLink = new ShellLink(targetPath, arguments, workingDirectory);`
`743`		`- newLink.RunAsAdministrator = runAsAdmin;`
	`743`	`+`
	`744`	`+ // Check if the target is a file`
	`745`	`+ if (File.Exists(targetPath))`
	`746`	`+ newLink.RunAsAdministrator = runAsAdmin;`
	`747`	`+`
`744`	`748`	`newLink.SaveAs(linkSavePath); // Overwrite if exists`
`745`	`749`	`return Task.FromResult(true);`
`746`	`750`	`}`