Introduced GetShellNewItems

Author: 0x5bfa

src/Files.App.CsWin32/ManualGuid.cs

@@ -44,6 +44,12 @@ public static Guid* IID_IStorageProviderStatusUISourceFactory
 
 		[GuidRVAGen.Guid("BCC18B79-BA16-442F-80C4-8A59C30C463B")]
 		public static partial Guid* IID_IShellItemImageFactory { get; }
+
+		[GuidRVAGen.Guid("000214E8-0000-0000-C000-000000000046")]
+		public static partial Guid* IID_IShellExtInit { get; }
+
+		[GuidRVAGen.Guid("000214F4-0000-0000-C000-000000000046")]
+		public static partial Guid* IID_IContextMenu2 { get; }
 	}
 
 	public static unsafe partial class CLSID
@@ -62,6 +68,9 @@ public static unsafe partial class CLSID
 
 		[GuidRVAGen.Guid("45BA127D-10A8-46EA-8AB7-56EA9078943C")]
 		public static partial Guid* CLSID_ApplicationActivationManager { get; }
+
+		[GuidRVAGen.Guid("D969A300-E7FF-11d0-A93B-00A0C90F2719")]
+		public static partial Guid* CLSID_NewMenu { get; }
 	}
 
 	public static unsafe partial class BHID

src/Files.App.CsWin32/NativeMethods.txt

@@ -230,3 +230,8 @@ HKEY_CURRENT_USER
 RegOpenKeyEx
 RegEnumKeyEx
 RegGetValue
+IShellExtInit
+IContextMenu2
+GetSubMenu
+GetMenuItemCount
+GetMenuItemInfo

src/Files.App.Storage/Storables/WindowsStorage/ContextMenuType.cs

@@ -0,0 +1,21 @@
+// Copyright (c) Files Community
+// Licensed under the MIT License.
+
+namespace Files.App.Storage
+{
+	public enum ContextMenuType
+	{
+		Enabled = 0x00000000,
+		Unchecked = 0x00000000,
+		Unhighlighted = 0x00000000,
+
+		Grayed = 0x00000003,
+		Disabled = 0x00000003,
+
+		Checked = 0x00000008,
+
+		Highlighted = 0x00000080,
+
+		Default = 0x00001000,
+	}
+}

src/Files.App.Storage/Storables/WindowsStorage/ShellNewItem.cs

@@ -6,30 +6,14 @@ namespace Files.App.Storage
 	/// <summary>
 	/// Represents a ShellNew item with its type, file extension, description, and icon.
 	/// </summary>
-	/// <remarks>
-	/// This class maps to an undocumented struct, SHELLNEW_ITEM.
-	/// </remarks>
-	// TODO: Should this class be a record instead?
 	public partial class ShellNewItem
 	{
-		/// <summary>
-		/// Gets the type of a new shell item.
-		/// </summary>
-		public ShellNewItemType Type { get; set; } = ShellNewItemType.Invalid;
+		public ContextMenuType Type { get; set; } = ContextMenuType.Enabled;
 
-		/// <summary>
-		/// Gets string file extension (e.g. ".txt").
-		/// </summary>
-		public string? Extension { get; set; }
+		public uint Id { get; set; }
 
-		/// <summary>
-		/// Gets string description as a string.
-		/// </summary>
-		public string? Description { get; set; }
-
-		/// <summary>
-		/// Gets icon data as a byte array.
-		/// </summary>
 		public byte[]? Icon { get; set; }
+
+		public string? Name { get; set; }
 	}
 }

src/Files.App.Storage/Storables/WindowsStorage/ShellNewItemType.cs

@@ -62,6 +62,7 @@ public static bool GetRegistryValue<T>(HKEY hRootKey, string szSubKey, string sz
 
 					switch (dwValueType)
 					{
+						default:
 						case REG_VALUE_TYPE.REG_NONE:
 						case REG_VALUE_TYPE.REG_BINARY:
 							{
@@ -76,8 +77,8 @@ public static bool GetRegistryValue<T>(HKEY hRootKey, string szSubKey, string sz
 							{
 								valueData = cbData switch
 								{
-									4U => valueData = Unsafe.As<uint, T>(ref *(uint*)pData),
-									8U => valueData = Unsafe.As<ulong, T>(ref *(ulong*)pData),
+									4U => Unsafe.As<uint, T>(ref *(uint*)pData),
+									8U => Unsafe.As<ulong, T>(ref *(ulong*)pData),
 									_ => throw new InvalidCastException($"Registry value size of data \"{nameof(pData)}\" of \"{nameof(pszValueName)}\" is invalid (size: \"{cbData}\")."),
 								};
 							}
@@ -96,32 +97,35 @@ public static bool GetRegistryValue<T>(HKEY hRootKey, string szSubKey, string sz
 							break;
 						case REG_VALUE_TYPE.REG_MULTI_SZ:
 							{
-								byte* dwPtrPosition = pData;
+								byte* pDataPtrSeeker = pData;
 								uint dwSeparatorCount = 0U;
+								uint dwArrayIndex = 0U;
+								string[] stringDataArray = new string[dwSeparatorCount + 1];
 
-								while (dwPtrPosition < pData + cbData)
+								while (pDataPtrSeeker < pData + cbData)
 								{
-									if ((char)*dwPtrPosition is '\0')
+									if ((char)*pDataPtrSeeker is '\0')
 										dwSeparatorCount++;
 
-									dwPtrPosition++;
+									pDataPtrSeeker++;
 								}
 
-								dwPtrPosition = pData;
-								uint dwArrayIndex = 0U;
-								string[] stringDataArray = new string[dwSeparatorCount + 1];
+								// Reset pointer to the start of the data
+								pDataPtrSeeker = pData;
 
-								while (dwPtrPosition < pData + cbData)
+								while (pDataPtrSeeker < pData + cbData)
 								{
-									if ((char)*dwPtrPosition is '\0')
+									if ((char)*pDataPtrSeeker is '\0')
 									{
 										dwArrayIndex++;
 										continue;
 									}
 
 									stringDataArray[dwArrayIndex] = new((char*)pData);
-									dwPtrPosition += stringDataArray[dwArrayIndex].Length;
+									pDataPtrSeeker += stringDataArray[dwArrayIndex].Length;
 								}
+
+								valueData = (T)(object)stringDataArray;
 							}
 							break;
 					}

src/Files.App.Storage/Storables/WindowsStorage/ShellNewManager.cs

@@ -2,17 +2,20 @@
 // Licensed under the MIT License.
 
 using System.Runtime.CompilerServices;
+using System.Runtime.InteropServices;
 using System.Text;
 using Windows.Win32;
 using Windows.Win32.Foundation;
+using Windows.Win32.System.Com;
 using Windows.Win32.System.SystemServices;
 using Windows.Win32.UI.Shell;
+using Windows.Win32.UI.Shell.Common;
 using Windows.Win32.UI.Shell.PropertiesSystem;
 using Windows.Win32.UI.WindowsAndMessaging;
 
 namespace Files.App.Storage
 {
-	public static partial class WindowsStorableHelpers
+	public unsafe static partial class WindowsStorableHelpers
 	{
 		public unsafe static HRESULT GetPropertyValue<TValue>(this IWindowsStorable storable, string propKey, out TValue value)
 		{
@@ -143,5 +146,60 @@ public unsafe static HRESULT TryGetShellTooltip(this IWindowsStorable storable,
 
 			return HRESULT.S_OK;
 		}
+
+		public static IEnumerable<ShellNewItem> GetShellNewItems(this IWindowsStorable storable)
+		{
+			HRESULT hr = default;
+
+			using ComPtr<IContextMenu> pNewMenu = default;
+			using ComPtr<IShellExtInit> pShellExtInit = default;
+			using ComPtr<IContextMenu2> pContextMenu2 = default;
+
+			// Instantiate CNewMenu as IContextMenu, IContextMenu2, and IShellExtInit
+			hr = PInvoke.CoCreateInstance(CLSID.CLSID_NewMenu, null, CLSCTX.CLSCTX_INPROC_SERVER, IID.IID_IContextMenu, (void**)pNewMenu.GetAddressOf());
+			hr = pNewMenu.Get()->QueryInterface(IID.IID_IContextMenu2, (void**)pContextMenu2.GetAddressOf());
+			hr = pNewMenu.Get()->QueryInterface(IID.IID_IShellExtInit, (void**)pShellExtInit.GetAddressOf());
+
+			// Initialize CNewMenu with the PIDL of the folder
+			ITEMIDLIST* pFolderPidl = default;
+			hr = PInvoke.SHGetIDListFromObject((IUnknown*)storable.ThisPtr, &pFolderPidl);
+			hr = pShellExtInit.Get()->Initialize(pFolderPidl, null, default);
+
+			// Inserts "New (&W)"
+			HMENU hMenu = PInvoke.CreatePopupMenu();
+			hr = pNewMenu.Get()->QueryContextMenu(hMenu, 0, 1, 256, 0);
+
+			// Invokes CNewMenu::_InitMenuPopup(), which populates the hSubMenu
+			HMENU hSubMenu = PInvoke.GetSubMenu(hMenu, 0);
+			hr = pContextMenu2.Get()->HandleMenuMsg(PInvoke.WM_INITMENUPOPUP, (WPARAM)(nuint)hSubMenu.Value, 0);
+
+			// Enumerate and populate the list
+			List<ShellNewItem> shellNewItems = [];
+			uint dwCount = (uint)PInvoke.GetMenuItemCount(hSubMenu);
+			for (uint dwIndex = 0; dwIndex < dwCount; dwIndex++)
+			{
+				MENUITEMINFOW mii = default;
+				mii.cbSize = (uint)sizeof(MENUITEMINFOW);
+				mii.fMask = MENU_ITEM_MASK.MIIM_STRING | MENU_ITEM_MASK.MIIM_ID | MENU_ITEM_MASK.MIIM_STATE;
+				mii.dwTypeData = (char*)NativeMemory.Alloc(256U);
+				mii.cch = 256;
+
+				if (PInvoke.GetMenuItemInfo(hSubMenu, dwIndex, true, &mii))
+				{
+					Console.WriteLine($"{dwIndex:X}: {mii.wID:X}, {mii.fState}, {mii.dwTypeData}");
+
+					shellNewItems.Add(new()
+					{
+						Id = mii.wID,
+						Name = mii.dwTypeData.ToString(),
+						Type = (ContextMenuType)mii.fState,
+					});
+				}
+
+				NativeMemory.Free(mii.dwTypeData);
+			}
+
+			return shellNewItems;
+		}
 	}
 }