Feature: Added Terminal action to context menu (#15990)

Author: yaira2

src/Files.App/Actions/Open/OpenTerminalAction.cs

@@ -22,9 +22,12 @@ public virtual HotKey HotKey
 		public RichGlyph Glyph
 			=> new("\uE756");
 
-		public bool IsExecutable
+		public virtual bool IsExecutable
 			=> GetIsExecutable();
 
+		public virtual bool IsAccessibleGlobally
+			=> true;
+
 		public OpenTerminalAction()
 		{
 			context = Ioc.Default.GetRequiredService<IContentPageContext>();
@@ -74,7 +77,7 @@ public Task ExecuteAsync(object? parameter = null)
 			};
 		}
 
-		protected string[] GetPaths()
+		protected virtual string[] GetPaths()
 		{
 			if (context.HasSelection)
 			{

src/Files.App/Actions/Open/OpenTerminalFromHomeAction.cs

@@ -0,0 +1,39 @@
+// Copyright (c) 2024 Files Community
+// Licensed under the MIT License. See the LICENSE.
+
+namespace Files.App.Actions
+{
+	internal sealed class OpenTerminalFromHomeAction : OpenTerminalAction
+	{
+		private IHomePageContext HomePageContext { get; } = Ioc.Default.GetRequiredService<IHomePageContext>();
+
+		public override string Label
+			=> "OpenTerminal".GetLocalizedResource();
+
+		public override string Description
+			=> "OpenTerminalDescription".GetLocalizedResource();
+
+		public override bool IsExecutable =>
+			HomePageContext.IsAnyItemRightClicked &&
+			HomePageContext.RightClickedItem is not null &&
+			(HomePageContext.RightClickedItem is WidgetFileTagCardItem fileTagItem
+				? fileTagItem.IsFolder
+				: true) &&
+			HomePageContext.RightClickedItem.Path is not null &&
+			HomePageContext.RightClickedItem.Path != Constants.UserEnvironmentPaths.RecycleBinPath;
+
+		public override bool IsAccessibleGlobally
+			=> false;
+
+		public override HotKey HotKey
+			=> HotKey.None;
+
+		protected override string[] GetPaths()
+		{
+			if (HomePageContext.IsAnyItemRightClicked && HomePageContext.RightClickedItem?.Path is not null)
+				return [HomePageContext.RightClickedItem.Path];
+
+			return [];
+		}
+	}
+}

src/Files.App/Actions/Open/OpenTerminalFromSidebarAction.cs

@@ -0,0 +1,36 @@
+// Copyright (c) 2024 Files Community
+// Licensed under the MIT License. See the LICENSE.
+
+namespace Files.App.Actions
+{
+	internal sealed class OpenTerminalFromSidebarAction : OpenTerminalAction
+	{
+		private ISidebarContext SidebarContext { get; } = Ioc.Default.GetRequiredService<ISidebarContext>();
+
+		public override string Label
+			=> "OpenTerminal".GetLocalizedResource();
+
+		public override string Description
+			=> "OpenTerminalDescription".GetLocalizedResource();
+
+		public override bool IsExecutable =>
+			SidebarContext.IsItemRightClicked &&
+			SidebarContext.RightClickedItem is not null &&
+			SidebarContext.RightClickedItem.MenuOptions.ShowShellItems &&
+			!SidebarContext.RightClickedItem.MenuOptions.ShowEmptyRecycleBin;
+
+		public override bool IsAccessibleGlobally
+			=> false;
+
+		public override HotKey HotKey
+			=> HotKey.None;
+
+		protected override string[] GetPaths()
+		{
+			if (SidebarContext.IsItemRightClicked && SidebarContext.RightClickedItem is not null)
+				return [SidebarContext.RightClickedItem.Path];
+
+			return [];
+		}
+	}
+}

src/Files.App/Data/Commands/Manager/CommandCodes.cs

@@ -108,6 +108,8 @@ public enum CommandCodes
 		OpenSettings,
 		OpenTerminal,
 		OpenTerminalAsAdmin,
+		OpenTerminalFromSidebar,
+		OpenTerminalFromHome,
 		OpenCommandPalette,
 		EditInNotepad,
 

src/Files.App/Data/Commands/Manager/CommandManager.cs

@@ -113,6 +113,8 @@ public IRichCommand this[HotKey hotKey]
 		public IRichCommand OpenSettings => commands[CommandCodes.OpenSettings];
 		public IRichCommand OpenTerminal => commands[CommandCodes.OpenTerminal];
 		public IRichCommand OpenTerminalAsAdmin => commands[CommandCodes.OpenTerminalAsAdmin];
+		public IRichCommand OpenTerminalFromSidebar => commands[CommandCodes.OpenTerminalFromSidebar];
+		public IRichCommand OpenTerminalFromHome => commands[CommandCodes.OpenTerminalFromHome];
 		public IRichCommand OpenCommandPalette => commands[CommandCodes.OpenCommandPalette];
 		public IRichCommand EditInNotepad => commands[CommandCodes.EditInNotepad];
 		public IRichCommand LayoutDecreaseSize => commands[CommandCodes.LayoutDecreaseSize];
@@ -300,6 +302,8 @@ public IEnumerator<IRichCommand> GetEnumerator() =>
 			[CommandCodes.OpenSettings] = new OpenSettingsAction(),
 			[CommandCodes.OpenTerminal] = new OpenTerminalAction(),
 			[CommandCodes.OpenTerminalAsAdmin] = new OpenTerminalAsAdminAction(),
+			[CommandCodes.OpenTerminalFromSidebar] = new OpenTerminalFromSidebarAction(),
+			[CommandCodes.OpenTerminalFromHome] = new OpenTerminalFromHomeAction(),
 			[CommandCodes.OpenCommandPalette] = new OpenCommandPaletteAction(),
 			[CommandCodes.EditInNotepad] = new EditInNotepadAction(),
 			[CommandCodes.LayoutDecreaseSize] = new LayoutDecreaseSizeAction(),

src/Files.App/Data/Commands/Manager/ICommandManager.cs

@@ -98,6 +98,8 @@ public interface ICommandManager : IEnumerable<IRichCommand>
 		IRichCommand OpenSettings { get; }
 		IRichCommand OpenTerminal { get; }
 		IRichCommand OpenTerminalAsAdmin { get; }
+		IRichCommand OpenTerminalFromSidebar { get; }
+		IRichCommand OpenTerminalFromHome { get; }
 		IRichCommand OpenCommandPalette { get; }
 		IRichCommand EditInNotepad { get; }
 

src/Files.App/Data/Factories/ContentPageContextFlyoutFactory.cs

@@ -578,6 +578,16 @@ public static List<ContextMenuFlyoutItemViewModel> GetBaseItemMenuItems(
 					ShowItem = isDriveRoot,
 					IsEnabled = false
 				},
+				new ContextMenuFlyoutItemViewModelBuilder(Commands.EditInNotepad).Build(),				
+				new ContextMenuFlyoutItemViewModel()
+				{
+					ItemType = ContextMenuFlyoutItemType.Separator,
+					ShowItem = !itemsSelected && Commands.OpenTerminal.IsExecutable || areAllItemsFolders && Commands.OpenTerminal.IsExecutable
+				},
+				new ContextMenuFlyoutItemViewModelBuilder(Commands.OpenTerminal)
+				{
+					IsVisible = !itemsSelected && Commands.OpenTerminal.IsExecutable || areAllItemsFolders && Commands.OpenTerminal.IsExecutable
+				}.Build(),
 				// Shell extensions are not available on the FTP server or in the archive,
 				// but following items are intentionally added because icons in the context menu will not appear
 				// unless there is at least one menu item with an icon that is not an ThemedIconModel. (#12943)
@@ -590,7 +600,6 @@ public static List<ContextMenuFlyoutItemViewModel> GetBaseItemMenuItems(
 					ShowInRecycleBin = true,
 					ShowInSearchPage = true,
 				},
-				new ContextMenuFlyoutItemViewModelBuilder(Commands.EditInNotepad).Build(),
 				new ContextMenuFlyoutItemViewModel()
 				{
 					Text = "Loading".GetLocalizedResource(),

src/Files.App/Data/Factories/ShellContextFlyoutHelper.cs

@@ -45,6 +45,7 @@ Func<string, bool> FilterMenuItems(bool showOpenMenu)
 					Win32Helper.ExtractStringFromDLL("shell32.dll", 5385), // Unpin from Start
 					Win32Helper.ExtractStringFromDLL("shell32.dll", 5386), // Pin to taskbar
 					Win32Helper.ExtractStringFromDLL("shell32.dll", 5387), // Unpin from taskbar
+					"{9F156763-7844-4DC4-B2B1-901F640F5155}", // Open in Terminal
 				};
 
 				bool filterMenuItemsImpl(string menuItem) => !string.IsNullOrEmpty(menuItem)

src/Files.App/ViewModels/UserControls/SidebarViewModel.cs

@@ -1065,6 +1065,12 @@ private List<ContextMenuFlyoutItemViewModel> GetLocationItemMenuItems(INavigatio
 					ShowItem = options.ShowProperties
 				},
 				new ContextMenuFlyoutItemViewModel()
+				{
+					ItemType = ContextMenuFlyoutItemType.Separator,
+					ShowItem = Commands.OpenTerminalFromSidebar.IsExecutable
+				},
+				new ContextMenuFlyoutItemViewModelBuilder(Commands.OpenTerminalFromSidebar).Build(),
+				new ContextMenuFlyoutItemViewModel()
 				{
 					ItemType = ContextMenuFlyoutItemType.Separator,
 					Tag = "OverflowSeparator",

src/Files.App/ViewModels/UserControls/Widgets/DrivesWidgetViewModel.cs

@@ -146,6 +146,12 @@ public override List<ContextMenuFlyoutItemViewModel> GetItemMenuItems(WidgetCard
 					Tag = "ManageBitLockerPlaceholder",
 					IsEnabled = false
 				},
+				new ContextMenuFlyoutItemViewModel()
+				{
+					ItemType = ContextMenuFlyoutItemType.Separator,
+					ShowItem = CommandManager.OpenTerminalFromHome.IsExecutable
+				},
+				new ContextMenuFlyoutItemViewModelBuilder(CommandManager.OpenTerminalFromHome).Build(),
 				new()
 				{
 					ItemType = ContextMenuFlyoutItemType.Separator,